<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/24287">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">common: make the arguments of phy_{link,instance}_name() const<br><br>Change-Id: Ic01d131148065c9143d3a90f8020e2e133941292<br>Related: CID#236092 "Dereference before null check"<br>---<br>M include/osmo-bts/phy_link.h<br>M src/common/phy_link.c<br>2 files changed, 4 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/87/24287/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmo-bts/phy_link.h b/include/osmo-bts/phy_link.h</span><br><span>index becc442..bd1a0c3 100644</span><br><span>--- a/include/osmo-bts/phy_link.h</span><br><span>+++ b/include/osmo-bts/phy_link.h</span><br><span>@@ -155,7 +155,7 @@</span><br><span> struct phy_link *phy_link_by_num(int num);</span><br><span> struct phy_link *phy_link_create(void *ctx, int num);</span><br><span> void phy_link_destroy(struct phy_link *plink);</span><br><span style="color: hsl(0, 100%, 40%);">-const char *phy_link_name(struct phy_link *plink);</span><br><span style="color: hsl(120, 100%, 40%);">+const char *phy_link_name(const struct phy_link *plink);</span><br><span> void phy_link_state_set(struct phy_link *plink, enum phy_link_state state);</span><br><span> enum phy_link_state phy_link_state_get(struct phy_link *plink);</span><br><span> const char *phy_link_state_name(enum phy_link_state state);</span><br><span>@@ -165,7 +165,7 @@</span><br><span> struct phy_instance *phy_instance_create(struct phy_link *plink, int num);</span><br><span> void phy_instance_link_to_trx(struct phy_instance *pinst, struct gsm_bts_trx *trx);</span><br><span> void phy_instance_destroy(struct phy_instance *pinst);</span><br><span style="color: hsl(0, 100%, 40%);">-const char *phy_instance_name(struct phy_instance *pinst);</span><br><span style="color: hsl(120, 100%, 40%);">+const char *phy_instance_name(const struct phy_instance *pinst);</span><br><span> </span><br><span> static inline struct phy_instance *trx_phy_instance(const struct gsm_bts_trx *trx)</span><br><span> {</span><br><span>diff --git a/src/common/phy_link.c b/src/common/phy_link.c</span><br><span>index 411f870..93c6f2c 100644</span><br><span>--- a/src/common/phy_link.c</span><br><span>+++ b/src/common/phy_link.c</span><br><span>@@ -146,7 +146,7 @@</span><br><span> }</span><br><span> </span><br><span> static char name_buf[32];</span><br><span style="color: hsl(0, 100%, 40%);">-const char *phy_link_name(struct phy_link *plink)</span><br><span style="color: hsl(120, 100%, 40%);">+const char *phy_link_name(const struct phy_link *plink)</span><br><span> {</span><br><span>     snprintf(name_buf, sizeof(name_buf), "phy%u", plink->num);</span><br><span>      return name_buf;</span><br><span>@@ -167,7 +167,7 @@</span><br><span>       return 0;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-const char *phy_instance_name(struct phy_instance *pinst)</span><br><span style="color: hsl(120, 100%, 40%);">+const char *phy_instance_name(const struct phy_instance *pinst)</span><br><span> {</span><br><span>    snprintf(name_buf, sizeof(name_buf), "phy%u.%u", pinst->phy_link->num,</span><br><span>                pinst->num);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/24287">change 24287</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/24287"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic01d131148065c9143d3a90f8020e2e133941292 </div>
<div style="display:none"> Gerrit-Change-Number: 24287 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>