<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24208">View Change</a></p><div style="white-space:pre-wrap">Approvals:
laforge: Looks good to me, approved
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">pcu: Introduce test TC_t3141<br><br>Change-Id: I5f30e93de4a109d60577394da4e00a15ab23d1d6<br>Related: OS#1940<br>---<br>M pcu/GPRS_Components.ttcn<br>M pcu/PCU_Tests.ttcn<br>2 files changed, 116 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pcu/GPRS_Components.ttcn b/pcu/GPRS_Components.ttcn</span><br><span>index d3ace4d..5cf9104 100644</span><br><span>--- a/pcu/GPRS_Components.ttcn</span><br><span>+++ b/pcu/GPRS_Components.ttcn</span><br><span>@@ -241,6 +241,17 @@</span><br><span> return 51 * ((st.t3 - st.t2) mod 26) + st.t3 + 51 * 26 * st.t1;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+function fn2bn(GsmFrameNumber fn) return uint32_t {</span><br><span style="color: hsl(120, 100%, 40%);">+ return (fn mod 52) / 4;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+function f_next_pdch_block(GsmFrameNumber fn) return GsmFrameNumber</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ var uint32_t bn := fn2bn(fn) + 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ fn := fn - (fn mod 52);</span><br><span style="color: hsl(120, 100%, 40%);">+ fn := fn + bn * 4 + bn / 3;</span><br><span style="color: hsl(120, 100%, 40%);">+ return fn mod GsmMaxFrameNumber;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> function f_ultbf_new_from_rr_imm_ass(in GsmRrMessage rr_imm_ass)</span><br><span> runs on MS_BTS_IFACE_CT return UlTbf {</span><br><span> var UlTbf ul_tbf := valueof(t_UlTbf_def);</span><br><span>diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn</span><br><span>index 4df5515..3d374d0 100644</span><br><span>--- a/pcu/PCU_Tests.ttcn</span><br><span>+++ b/pcu/PCU_Tests.ttcn</span><br><span>@@ -1270,6 +1270,110 @@</span><br><span> f_dl_data_exp_cs(f_rlcmac_block_int2cs_mcs(g_mcs_max_dl, true), bssgp_ms_racap_egprs_def);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* Verify PCU drops TBF after some time of inactivity. */</span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_t3141() runs on RAW_PCU_Test_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ var PCUIF_info_ind info_ind;</span><br><span style="color: hsl(120, 100%, 40%);">+ var template (value) TsTrxBtsNum nr;</span><br><span style="color: hsl(120, 100%, 40%);">+ var BTS_PDTCH_Block data_msg;</span><br><span style="color: hsl(120, 100%, 40%);">+ var GprsMS ms;</span><br><span style="color: hsl(120, 100%, 40%);">+ var uint3_t rx_usf;</span><br><span style="color: hsl(120, 100%, 40%);">+ timer T_3141 := 1.0;</span><br><span style="color: hsl(120, 100%, 40%);">+ var boolean ul_tbf_usf_req := false;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Initialize NS/BSSGP side */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init_bssgp();</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Initialize GPRS MS side */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init_gprs_ms();</span><br><span style="color: hsl(120, 100%, 40%);">+ ms := g_ms[0]; /* We only use first MS in this test */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ info_ind := valueof(ts_PCUIF_INFO_default(c_PCUIF_Flags_noMCS));</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Only use 1 PDCH to simplify test: */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_PCUIF_PDCHMask_set(info_ind, '00000001'B, 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_PCUIF_PDCHMask_set(info_ind, '00000000'B, (1 .. 7));</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Initialize the PCU interface abstraction */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init_raw(testcasename(), info_ind);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_vty_config2(PCUVTY, {"pcu"}, "timer T3141 1");</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Establish BSSGP connection to the PCU */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_bssgp_establish();</span><br><span style="color: hsl(120, 100%, 40%);">+ f_bssgp_client_llgmm_assign(TLLI_UNUSED, ms.tlli);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Establish a one-phase access Uplink TBF */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_ms_establish_ul_tbf(ms);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ T_3141.start;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Now we wait for PCU to transmit our USF */</span><br><span style="color: hsl(120, 100%, 40%);">+ nr := ts_TsTrxBtsNum;</span><br><span style="color: hsl(120, 100%, 40%);">+ BTS.send(ts_PCUIF_RTS_REQ(nr.bts_nr, nr.trx_nr, nr.ts_nr,</span><br><span style="color: hsl(120, 100%, 40%);">+ sapi := PCU_IF_SAPI_PDTCH, fn := 0,</span><br><span style="color: hsl(120, 100%, 40%);">+ arfcn := f_trxnr2arfcn(valueof(nr.trx_nr)),</span><br><span style="color: hsl(120, 100%, 40%);">+ block_nr := nr.blk_nr));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ alt {</span><br><span style="color: hsl(120, 100%, 40%);">+ [] BTS.receive(tr_PCUIF_DATA_PDTCH(nr.bts_nr,</span><br><span style="color: hsl(120, 100%, 40%);">+ tr_PCUIF_DATA(nr.trx_nr, nr.ts_nr, sapi := PCU_IF_SAPI_PDTCH),</span><br><span style="color: hsl(120, 100%, 40%);">+ ?)) -> value data_msg {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (ms.ul_tbf.usf[valueof(nr.ts_nr)] == USF_UNUSED) {</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail, "Unexpected ts_nr ", valueof(nr.ts_nr), " without USF allocated");</span><br><span style="color: hsl(120, 100%, 40%);">+ f_shutdown(__BFILE__, __LINE__);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ rx_usf := f_rlcmac_dl_block_get_usf(data_msg.dl_block);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (rx_usf == ms.ul_tbf.usf[valueof(nr.ts_nr)]) {</span><br><span style="color: hsl(120, 100%, 40%);">+ /* PCU requests our USF, transmit WITHOUT tlli to avoid contention resolution success */</span><br><span style="color: hsl(120, 100%, 40%);">+ ul_tbf_usf_req := true;</span><br><span style="color: hsl(120, 100%, 40%);">+ f_ms_tx_ul_data_block(ms, f_rnd_octstring(10), cv := 15, with_tlli := false, fn := f_next_pdch_block(data_msg.raw.fn))</span><br><span style="color: hsl(120, 100%, 40%);">+ } else if (rx_usf == USF_UNUSED) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (data_msg.raw.fn >= ms.ul_tbf.start_time_fn) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (ul_tbf_usf_req) {</span><br><span style="color: hsl(120, 100%, 40%);">+ /* TBF was dropped by T3141, success */</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(pass);</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ } else {</span><br><span style="color: hsl(120, 100%, 40%);">+ log("PCU never requested USF, unexpected");</span><br><span style="color: hsl(120, 100%, 40%);">+ f_shutdown(__BFILE__, __LINE__);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ } /* else: Keep waiting for TBF to be active by network */</span><br><span style="color: hsl(120, 100%, 40%);">+ } else {</span><br><span style="color: hsl(120, 100%, 40%);">+ log("PCU requests ", rx_usf, ", we have ", ms.ul_tbf.usf[valueof(nr.ts_nr)]);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_shutdown(__BFILE__, __LINE__);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Make sure we don't receive a Ul ACK/NACK with TLLI set: */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (match(data_msg.dl_block,</span><br><span style="color: hsl(120, 100%, 40%);">+ tr_RLCMAC_UL_ACK_NACK_GPRS(ms.ul_tbf.tfi,</span><br><span style="color: hsl(120, 100%, 40%);">+ tr_UlAckNackGprs(tlli := ?,</span><br><span style="color: hsl(120, 100%, 40%);">+ acknack_desc := ?,</span><br><span style="color: hsl(120, 100%, 40%);">+ rel99 := *))))</span><br><span style="color: hsl(120, 100%, 40%);">+ {</span><br><span style="color: hsl(120, 100%, 40%);">+ log("Received UL ACK/NACK with TLLI set");</span><br><span style="color: hsl(120, 100%, 40%);">+ f_shutdown(__BFILE__, __LINE__);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ nr := ts_TsTrxBtsNum;</span><br><span style="color: hsl(120, 100%, 40%);">+ BTS.send(ts_PCUIF_RTS_REQ(nr.bts_nr, nr.trx_nr, nr.ts_nr,</span><br><span style="color: hsl(120, 100%, 40%);">+ sapi := PCU_IF_SAPI_PDTCH, fn := 0,</span><br><span style="color: hsl(120, 100%, 40%);">+ arfcn := f_trxnr2arfcn(valueof(nr.trx_nr)),</span><br><span style="color: hsl(120, 100%, 40%);">+ block_nr := nr.blk_nr));</span><br><span style="color: hsl(120, 100%, 40%);">+ repeat;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ [] T_3141.timeout {</span><br><span style="color: hsl(120, 100%, 40%);">+ log("T_3141 expired but TBF is still active, unexpected");</span><br><span style="color: hsl(120, 100%, 40%);">+ f_shutdown(__BFILE__, __LINE__);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ [] BTS.receive {</span><br><span style="color: hsl(120, 100%, 40%);">+ /* We should never receive non-dummy messages, aka UL ACK/NACK,</span><br><span style="color: hsl(120, 100%, 40%);">+ * because we never sent the TLLI to the PCU */</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail, "Unexpected BTS message");</span><br><span style="color: hsl(120, 100%, 40%);">+ f_shutdown(__BFILE__, __LINE__);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_shutdown(__BFILE__, __LINE__, final := true);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* Validate what happens when RACH to get UL TBF and then PCU receives no UL</span><br><span> * data. It should end up in N3101 reaching N3101_MAX and finally triggering</span><br><span> * T3169. See OS#5033 */</span><br><span>@@ -5758,6 +5862,7 @@</span><br><span> execute( TC_mcs_max_ul() );</span><br><span> execute( TC_mcs_initial_dl() );</span><br><span> execute( TC_mcs_max_dl() );</span><br><span style="color: hsl(120, 100%, 40%);">+ execute( TC_t3141() );</span><br><span> execute( TC_n3101_max_t3169() );</span><br><span> execute( TC_n3103_max_t3169() );</span><br><span> execute( TC_x2031_t3191() );</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24208">change 24208</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24208"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I5f30e93de4a109d60577394da4e00a15ab23d1d6 </div>
<div style="display:none"> Gerrit-Change-Number: 24208 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>