<p>Falkenber9 has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/pysim/+/24249">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">pySim-read: adjust meaning of HPLMN/OPLMN flags in EF_SPN<br><br>The updated wording better reflects the actual meaning<br>of a set or unset flag, especially as OPLMN is inverted.<br><br>Change-Id: I65c6f0e9bc1a12a4a74c4274eebb8e612296888f<br>---<br>M pySim-read.py<br>M pysim-testdata/Fairwaves-SIM.ok<br>M pysim-testdata/Wavemobile-SIM.ok<br>M pysim-testdata/fakemagicsim.ok<br>M pysim-testdata/sysmoISIM-SJA2.ok<br>M pysim-testdata/sysmoUSIM-SJS1.ok<br>M pysim-testdata/sysmosim-gr1.ok<br>7 files changed, 14 insertions(+), 14 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/49/24249/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pySim-read.py b/pySim-read.py</span><br><span>index 9feef9d..88a5651 100755</span><br><span>--- a/pySim-read.py</span><br><span>+++ b/pySim-read.py</span><br><span>@@ -126,8 +126,8 @@</span><br><span> (res, sw) = card.read_spn()</span><br><span> if sw == '9000':</span><br><span> print("SPN: %s" % (res[0] or "Not available"))</span><br><span style="color: hsl(0, 100%, 40%);">- print("Display HPLMN: %s" % (res[1],))</span><br><span style="color: hsl(0, 100%, 40%);">- print("Display OPLMN: %s" % (res[2],))</span><br><span style="color: hsl(120, 100%, 40%);">+ print("Show in HPLMN: %s" % (res[1],))</span><br><span style="color: hsl(120, 100%, 40%);">+ print("Hide in OPLMN: %s" % (res[2],))</span><br><span> else:</span><br><span> print("SPN: Can't read, response code = %s" % (sw,))</span><br><span> except Exception as e:</span><br><span>diff --git a/pysim-testdata/Fairwaves-SIM.ok b/pysim-testdata/Fairwaves-SIM.ok</span><br><span>index eebf965..2a912e2 100644</span><br><span>--- a/pysim-testdata/Fairwaves-SIM.ok</span><br><span>+++ b/pysim-testdata/Fairwaves-SIM.ok</span><br><span>@@ -7,8 +7,8 @@</span><br><span> GID2: ffffffffffffffff</span><br><span> SMSP: e1ffffffffffffffffffffffff0581005155f5ffffffffffff000000ffffffffffffffffffffffffffff</span><br><span> SPN: Fairwaves</span><br><span style="color: hsl(0, 100%, 40%);">-Display HPLMN: False</span><br><span style="color: hsl(0, 100%, 40%);">-Display OPLMN: False</span><br><span style="color: hsl(120, 100%, 40%);">+Show in HPLMN: False</span><br><span style="color: hsl(120, 100%, 40%);">+Hide in OPLMN: False</span><br><span> PLMNsel: ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff</span><br><span> PLMNwAcT:</span><br><span> ffffff0000 # unused</span><br><span>diff --git a/pysim-testdata/Wavemobile-SIM.ok b/pysim-testdata/Wavemobile-SIM.ok</span><br><span>index a6bdeaa..0eb8cc8 100644</span><br><span>--- a/pysim-testdata/Wavemobile-SIM.ok</span><br><span>+++ b/pysim-testdata/Wavemobile-SIM.ok</span><br><span>@@ -7,8 +7,8 @@</span><br><span> GID2: Can't read file -- SW match failed! Expected 9000 and got 6a82.</span><br><span> SMSP: e1ffffffffffffffffffffffff0581005155f5ffffffffffff000000ffffffffffffffffffffffffffff</span><br><span> SPN: wavemobile</span><br><span style="color: hsl(0, 100%, 40%);">-Display HPLMN: False</span><br><span style="color: hsl(0, 100%, 40%);">-Display OPLMN: False</span><br><span style="color: hsl(120, 100%, 40%);">+Show in HPLMN: False</span><br><span style="color: hsl(120, 100%, 40%);">+Hide in OPLMN: False</span><br><span> PLMNsel: 00f110ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff</span><br><span> PLMNwAcT:</span><br><span> 00f110ffff # MCC: 001 MNC: 01 AcT: UTRAN, E-UTRAN WB-S1, E-UTRAN NB-S1, GSM, GSM COMPACT, cdma2000 HRPD, cdma2000 1xRTT</span><br><span>diff --git a/pysim-testdata/fakemagicsim.ok b/pysim-testdata/fakemagicsim.ok</span><br><span>index 11296f5..805b360 100644</span><br><span>--- a/pysim-testdata/fakemagicsim.ok</span><br><span>+++ b/pysim-testdata/fakemagicsim.ok</span><br><span>@@ -8,8 +8,8 @@</span><br><span> GID2: Can't read file -- SW match failed! Expected 9000 and got 9404.</span><br><span> SMSP: ffffffffffffffffffffffffe1ffffffffffffffffffffffff0581005155f5ffffffffffff000000</span><br><span> SPN: Magic</span><br><span style="color: hsl(0, 100%, 40%);">-Display HPLMN: True</span><br><span style="color: hsl(0, 100%, 40%);">-Display OPLMN: False</span><br><span style="color: hsl(120, 100%, 40%);">+Show in HPLMN: True</span><br><span style="color: hsl(120, 100%, 40%);">+Hide in OPLMN: False</span><br><span> PLMNsel: 00f110ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff</span><br><span> PLMNwAcT: Can't read file -- SW match failed! Expected 9000 and got 9404.</span><br><span> OPLMNwAcT: Can't read file -- SW match failed! Expected 9000 and got 9404.</span><br><span>diff --git a/pysim-testdata/sysmoISIM-SJA2.ok b/pysim-testdata/sysmoISIM-SJA2.ok</span><br><span>index 8a5d30a..87cb857 100644</span><br><span>--- a/pysim-testdata/sysmoISIM-SJA2.ok</span><br><span>+++ b/pysim-testdata/sysmoISIM-SJA2.ok</span><br><span>@@ -7,8 +7,8 @@</span><br><span> GID2: ffffffffffffffffffff</span><br><span> SMSP: ffffffffffffffffffffffffffffffffffffffffffffffffe1ffffffffffffffffffffffff0581005155f5ffffffffffff000000</span><br><span> SPN: Magic</span><br><span style="color: hsl(0, 100%, 40%);">-Display HPLMN: True</span><br><span style="color: hsl(0, 100%, 40%);">-Display OPLMN: True</span><br><span style="color: hsl(120, 100%, 40%);">+Show in HPLMN: True</span><br><span style="color: hsl(120, 100%, 40%);">+Hide in OPLMN: True</span><br><span> PLMNsel: 00f110ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff</span><br><span> PLMNwAcT:</span><br><span> 00f110ffff # MCC: 001 MNC: 01 AcT: UTRAN, E-UTRAN WB-S1, E-UTRAN NB-S1, GSM, GSM COMPACT, cdma2000 HRPD, cdma2000 1xRTT</span><br><span>diff --git a/pysim-testdata/sysmoUSIM-SJS1.ok b/pysim-testdata/sysmoUSIM-SJS1.ok</span><br><span>index ab15f10..e65f276 100644</span><br><span>--- a/pysim-testdata/sysmoUSIM-SJS1.ok</span><br><span>+++ b/pysim-testdata/sysmoUSIM-SJS1.ok</span><br><span>@@ -7,8 +7,8 @@</span><br><span> GID2: ffffffffffffffffffff</span><br><span> SMSP: ffffffffffffffffffffffffffffffffffffffffffffffffe1ffffffffffffffffffffffff0581005155f5ffffffffffff000000</span><br><span> SPN: Magic</span><br><span style="color: hsl(0, 100%, 40%);">-Display HPLMN: True</span><br><span style="color: hsl(0, 100%, 40%);">-Display OPLMN: True</span><br><span style="color: hsl(120, 100%, 40%);">+Show in HPLMN: True</span><br><span style="color: hsl(120, 100%, 40%);">+Hide in OPLMN: True</span><br><span> PLMNsel: 00f110ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff</span><br><span> PLMNwAcT:</span><br><span> 00f110ffff # MCC: 001 MNC: 01 AcT: UTRAN, E-UTRAN WB-S1, E-UTRAN NB-S1, GSM, GSM COMPACT, cdma2000 HRPD, cdma2000 1xRTT</span><br><span>diff --git a/pysim-testdata/sysmosim-gr1.ok b/pysim-testdata/sysmosim-gr1.ok</span><br><span>index 3aff2a3..60c568b 100644</span><br><span>--- a/pysim-testdata/sysmosim-gr1.ok</span><br><span>+++ b/pysim-testdata/sysmosim-gr1.ok</span><br><span>@@ -8,8 +8,8 @@</span><br><span> GID2: Can't read file -- SW match failed! Expected 9000 and got 9404.</span><br><span> SMSP: ffffffffffffffffffffffffe1ffffffffffffffffffffffff0581005155f5ffffffffffff000000</span><br><span> SPN: Not available</span><br><span style="color: hsl(0, 100%, 40%);">-Display HPLMN: False</span><br><span style="color: hsl(0, 100%, 40%);">-Display OPLMN: False</span><br><span style="color: hsl(120, 100%, 40%);">+Show in HPLMN: False</span><br><span style="color: hsl(120, 100%, 40%);">+Hide in OPLMN: False</span><br><span> PLMNsel: 00f110ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff</span><br><span> PLMNwAcT: Can't read file -- SW match failed! Expected 9000 and got 9404.</span><br><span> OPLMNwAcT: Can't read file -- SW match failed! Expected 9000 and got 9404.</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/pysim/+/24249">change 24249</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/pysim/+/24249"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: pysim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I65c6f0e9bc1a12a4a74c4274eebb8e612296888f </div>
<div style="display:none"> Gerrit-Change-Number: 24249 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Falkenber9 <robert.falkenberg@tu-dortmund.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>