<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24246">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  fixeria: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bts: add first a5/4 tests<br><br>Not much to do here, bts just passes the key.<br><br>Related: SYS#5324<br>Change-Id: I38e8a1cf15eb41a621b457b39024283a767c94be<br>---<br>M bts/BTS_Tests.ttcn<br>M bts/expected-results.xml<br>2 files changed, 12 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn</span><br><span>index 8ae8eb2..eff1277 100644</span><br><span>--- a/bts/BTS_Tests.ttcn</span><br><span>+++ b/bts/BTS_Tests.ttcn</span><br><span>@@ -6706,6 +6706,11 @@</span><br><span>       pars.encr := valueof(ts_RSL_IE_EncrInfo(RSL_ALG_ID_A5_3, f_rnd_octstring(8)));</span><br><span>       f_testmatrix_each_chan(pars, refers(f_TC_chan_act_encr));</span><br><span> }</span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_chan_act_a54() runs on test_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+  var ConnHdlrPars pars := valueof(t_Pars(t_RslChanNr_Bm(1), ts_RSL_ChanMode_SIGN));</span><br><span style="color: hsl(120, 100%, 40%);">+    pars.encr := valueof(ts_RSL_IE_EncrInfo(RSL_ALG_ID_A5_4, f_rnd_octstring(16)));</span><br><span style="color: hsl(120, 100%, 40%);">+       f_testmatrix_each_chan(pars, refers(f_TC_chan_act_encr));</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span> </span><br><span> /* Test channel activation with A5/n right from the beginning and RSL MODE MODIFY</span><br><span>  which should break the en/decryption on purpose by supplying a new key that is unknown to the MS*/</span><br><span>@@ -6827,6 +6832,11 @@</span><br><span>        pars.encr := valueof(ts_RSL_IE_EncrInfo(RSL_ALG_ID_A5_3, f_rnd_octstring(8)));</span><br><span>       f_testmatrix_each_chan(pars, refers(f_TC_encr_cmd));</span><br><span> }</span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_encr_cmd_a54() runs on test_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+       var ConnHdlrPars pars := valueof(t_Pars(t_RslChanNr_Bm(1), ts_RSL_ChanMode_SIGN));</span><br><span style="color: hsl(120, 100%, 40%);">+    pars.encr := valueof(ts_RSL_IE_EncrInfo(RSL_ALG_ID_A5_4, f_rnd_octstring(16)));</span><br><span style="color: hsl(120, 100%, 40%);">+       f_testmatrix_each_chan(pars, refers(f_TC_encr_cmd));</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span> </span><br><span> private function f_assert_lapdm(octetstring enc, template LapdmFrame exp_match, charstring name := "") {</span><br><span>    var LapdmFrame lf;</span><br><span>diff --git a/bts/expected-results.xml b/bts/expected-results.xml</span><br><span>index 6142e40..b81358d 100644</span><br><span>--- a/bts/expected-results.xml</span><br><span>+++ b/bts/expected-results.xml</span><br><span>@@ -124,9 +124,11 @@</span><br><span>   <testcase classname='BTS_Tests' name='TC_chan_act_a51' time='MASKED'/></span><br><span>   <testcase classname='BTS_Tests' name='TC_chan_act_a52' time='MASKED'/></span><br><span>   <testcase classname='BTS_Tests' name='TC_chan_act_a53' time='MASKED'/></span><br><span style="color: hsl(120, 100%, 40%);">+  <testcase classname='BTS_Tests' name='TC_chan_act_a54' time='MASKED'/></span><br><span>   <testcase classname='BTS_Tests' name='TC_encr_cmd_a51' time='MASKED'/></span><br><span>   <testcase classname='BTS_Tests' name='TC_encr_cmd_a52' time='MASKED'/></span><br><span>   <testcase classname='BTS_Tests' name='TC_encr_cmd_a53' time='MASKED'/></span><br><span style="color: hsl(120, 100%, 40%);">+  <testcase classname='BTS_Tests' name='TC_encr_cmd_a54' time='MASKED'/></span><br><span>   <testcase classname='BTS_Tests' name='TC_err_rep_wrong_mdisc' time='MASKED'/></span><br><span>   <testcase classname='BTS_Tests' name='TC_err_rep_wrong_msg_type' time='MASKED'/></span><br><span>   <testcase classname='BTS_Tests' name='TC_err_rep_wrong_sequence' time='MASKED'/></span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24246">change 24246</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24246"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I38e8a1cf15eb41a621b457b39024283a767c94be </div>
<div style="display:none"> Gerrit-Change-Number: 24246 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Hoernchen <ewild@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>