<p>fixeria <strong>uploaded patch set #2</strong> to this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/24179">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">[VAMOS] Re-organize osmo-bts-trx specific structures<br><br>Together with the 'generic' structures which used to be shared between<br>osmo-bsc and osmo-bts some time ago, we also have the following<br>osmo-bts-trx specific structures (in hierarchical order):<br><br> - struct l1sched_trx (struct gsm_bts_trx),<br> - struct l1sched_ts (struct gsm_bts_trx_ts),<br> - struct l1sched_chan_state (struct gsm_lchan).<br><br>These structures are not integrated into the tree of the generic<br>structures, but maintained in a _separate tree_ instead. Until<br>recently, only the 'l1sched_trx' had a pointer to generic<br>'gsm_bts_trx', so in order to find the corresponding 'gsm_lchan' for<br>'l1sched_chan_state' one would need to traverse all the way up to<br>'l1sched_trx' and then tracerse another three backwards.<br><br> + gsm_network<br> |<br> --+ gsm_bts (0..255)<br> |<br> --+ l1sched_trx --------------------> gsm_bts_trx (0..255)<br> | |<br> --+ l1sched_trx_ts --+ gsm_bts_trx_ts (8)<br> | |<br> --+ l1sched_chan_state --+ gsm_lchan (up to 8)<br><br>I find this architecture a bit over-complicated, especially given<br>that 'l1sched_trx' is kind of a dummy node containing nothing else<br>than a pointer to 'gsm_bts_trx' and the list of 'l1sched_trx_ts'.<br><br>In this path I slightly change the architecture as follows:<br><br> + gsm_network<br> |<br> --+ gsm_bts (0..255)<br> |<br> --+ gsm_bts_trx (0..255)<br> |<br> --+ l1sched_trx_ts <----------------> gsm_bts_trx_ts (8)<br> | |<br> --+ l1sched_chan_state --+ gsm_lchan (up to 8)<br><br>Note that unfortunately we cannot 1:1 map 'l1sched_chan_state' to<br>'gsm_lchan' (like we do for 'l1sched_trx_ts' and 'gsm_bts_trx_ts')<br>because there is no direct mapping. The former is a higl-level<br>representation of a logical channel, while the later represents<br>one specific logical channel type like FCCH, SDCCH/0 or SACCH/0.<br><br>osmo-bts-virtual re-uses the osmo-bts-trx hierarchy, so it's also<br>affected by this change.<br><br>Change-Id: I7c4379e43a25e9d858d582a99bf6c4b65c9af481<br>---<br>M include/osmo-bts/gsm_data.h<br>M include/osmo-bts/phy_link.h<br>M include/osmo-bts/scheduler.h<br>M include/osmo-bts/scheduler_backend.h<br>M src/common/scheduler.c<br>M src/osmo-bts-trx/l1_if.c<br>M src/osmo-bts-trx/l1_if.h<br>M src/osmo-bts-trx/loops.c<br>M src/osmo-bts-trx/loops.h<br>M src/osmo-bts-trx/sched_lchan_fcch_sch.c<br>M src/osmo-bts-trx/sched_lchan_pdtch.c<br>M src/osmo-bts-trx/sched_lchan_rach.c<br>M src/osmo-bts-trx/sched_lchan_tchf.c<br>M src/osmo-bts-trx/sched_lchan_tchh.c<br>M src/osmo-bts-trx/sched_lchan_xcch.c<br>M src/osmo-bts-trx/scheduler_trx.c<br>M src/osmo-bts-trx/trx_if.c<br>M src/osmo-bts-virtual/bts_model.c<br>M src/osmo-bts-virtual/l1_if.c<br>M src/osmo-bts-virtual/l1_if.h<br>M src/osmo-bts-virtual/scheduler_virtbts.c<br>21 files changed, 400 insertions(+), 510 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/79/24179/2</pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/24179">change 24179</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/24179"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I7c4379e43a25e9d858d582a99bf6c4b65c9af481 </div>
<div style="display:none"> Gerrit-Change-Number: 24179 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-CC: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newpatchset </div>