<p>keith <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-mgw/+/24198">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, but someone else must approve
pespin: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Log some useful messages at ERROR/INFO instead of DEBUG<br><br>Change-Id: I22cbecab8d9f7a1980387f16c9a8da444aaa0311<br>---<br>M src/libosmo-mgcp/mgcp_e1.c<br>1 file changed, 5 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libosmo-mgcp/mgcp_e1.c b/src/libosmo-mgcp/mgcp_e1.c</span><br><span>index 7d4a29e..7e810bc 100644</span><br><span>--- a/src/libosmo-mgcp/mgcp_e1.c</span><br><span>+++ b/src/libosmo-mgcp/mgcp_e1.c</span><br><span>@@ -337,7 +337,7 @@</span><br><span> /* Find associated trunk */</span><br><span> trunk = mgcp_trunk_by_line_num(cfg, ts->line->num);</span><br><span> if (!trunk) {</span><br><span style="color: hsl(0, 100%, 40%);">- LOGP(DE1, LOGL_DEBUG, "E1-RX: unable to find a trunk for E1-line %u!\n", ts->line->num);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DE1, LOGL_ERROR, "E1-RX: unable to find a trunk for E1-line %u!\n", ts->line->num);</span><br><span> return;</span><br><span> }</span><br><span> </span><br><span>@@ -376,14 +376,14 @@</span><br><span> cfg = trunk->cfg;</span><br><span> </span><br><span> if (trunk->e1.ts_in_use[ts_nr - 1]) {</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPTRUNK(trunk, DE1, LOGL_DEBUG, "E1 timeslot %u already set up, skipping...\n", ts_nr);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPTRUNK(trunk, DE1, LOGL_INFO, "E1 timeslot %u already set up, skipping...\n", ts_nr);</span><br><span> return 0;</span><br><span> }</span><br><span> </span><br><span> /* Get E1 line */</span><br><span> e1_line = e1inp_line_find(trunk->e1.vty_line_nr);</span><br><span> if (!e1_line) {</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPTRUNK(trunk, DE1, LOGL_DEBUG, "no such E1 line %u - check VTY config!\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPTRUNK(trunk, DE1, LOGL_ERROR, "no such E1 line %u - check VTY config!\n",</span><br><span> trunk->e1.vty_line_nr);</span><br><span> return -EINVAL;</span><br><span> }</span><br><span>@@ -401,7 +401,7 @@</span><br><span> return -EINVAL;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- LOGPTRUNK(trunk, DE1, LOGL_DEBUG, "E1 timeslot %u set up successfully.\n", ts_nr);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPTRUNK(trunk, DE1, LOGL_INFO, "E1 timeslot %u set up successfully.\n", ts_nr);</span><br><span> trunk->e1.ts_in_use[ts_nr - 1] = true;</span><br><span> </span><br><span> return 0;</span><br><span>@@ -545,7 +545,7 @@</span><br><span> endp->e1.scd.mux.in_cb_queue_empty = e1_i460_mux_empty_cb;</span><br><span> endp->e1.scd.mux.user_data = endp;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- LOGPENDP(endp, DE1, LOGL_DEBUG, "adding I.460 subchannel: ts=%u, bit_offset=%u, rate=%uk, num_bits=%lu\n", ts,</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPENDP(endp, DE1, LOGL_INFO, "adding I.460 subchannel: ts=%u, bit_offset=%u, rate=%uk, num_bits=%lu\n", ts,</span><br><span> offs, e1_rates[ss], endp->e1.scd.demux.num_bits);</span><br><span> endp->e1.schan = osmo_i460_subchan_add(endp, &endp->trunk->e1.i460_ts[ts - 1], &endp->e1.scd);</span><br><span> if (!endp->e1.schan) {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-mgw/+/24198">change 24198</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-mgw/+/24198"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-mgw </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I22cbecab8d9f7a1980387f16c9a8da444aaa0311 </div>
<div style="display:none"> Gerrit-Change-Number: 24198 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: keith <keith@rhizomatica.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: keith <keith@rhizomatica.org> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>