<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-mgw/+/24144">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">tweak termination DLCX log msg<br><br>Sending a DLCX upon FSM cleanup is not unusual. Move the log about that<br>DLCX to INFO, and also print the endpoint and conn identifier.<br><br>Change-Id: Id723d949f101b66fb75296d01489d9dac350c7c8<br>---<br>M src/libosmo-mgcp-client/mgcp_client_fsm.c<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libosmo-mgcp-client/mgcp_client_fsm.c b/src/libosmo-mgcp-client/mgcp_client_fsm.c</span><br><span>index 9e4a100..1c0cd59 100644</span><br><span>--- a/src/libosmo-mgcp-client/mgcp_client_fsm.c</span><br><span>+++ b/src/libosmo-mgcp-client/mgcp_client_fsm.c</span><br><span>@@ -525,8 +525,8 @@</span><br><span>          * If in ST_DLCX_RESP, a DLCX was already sent and we did not get a</span><br><span>   * response. No point in sending another one. */</span><br><span>     if (fi->state != ST_DLCX_RESP && strlen(mgcp_ctx->conn_id)) {</span><br><span style="color: hsl(0, 100%, 40%);">-             LOGPFSML(fi, LOGL_NOTICE,</span><br><span style="color: hsl(0, 100%, 40%);">-                        "MGW/DLCX: FSM termination with connections still present, sending unconditional DLCX...\n");</span><br><span style="color: hsl(120, 100%, 40%);">+              LOGPFSML(fi, LOGL_INFO, "Conn cleanup, sending DLCX for %s %s\n", mgcp_ctx->conn_peer_remote.endpoint,</span><br><span style="color: hsl(120, 100%, 40%);">+                    mgcp_ctx->conn_id);</span><br><span>              msg = make_dlcx_msg(mgcp_ctx);</span><br><span>               if (!msg)</span><br><span>                    LOGPFSML(fi, LOGL_ERROR, "MGW/DLCX: Error composing DLCX message\n");</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-mgw/+/24144">change 24144</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-mgw/+/24144"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-mgw </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Id723d949f101b66fb75296d01489d9dac350c7c8 </div>
<div style="display:none"> Gerrit-Change-Number: 24144 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>