<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/pysim/+/24158">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ModemATCommandLink: improve response time for "+CME ERROR"<br><br>Change-Id: I41af33c1898f5ed3d1c5238e45f956c6ceab2826<br>---<br>M pySim/transport/modem_atcmd.py<br>1 file changed, 10 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pySim/transport/modem_atcmd.py b/pySim/transport/modem_atcmd.py</span><br><span>index 3d39a20..04f9221 100644</span><br><span>--- a/pySim/transport/modem_atcmd.py</span><br><span>+++ b/pySim/transport/modem_atcmd.py</span><br><span>@@ -67,12 +67,16 @@</span><br><span>            t_start = time.time()</span><br><span>                while True:</span><br><span>                  rsp = rsp + self._sl.read(self._sl.in_waiting)</span><br><span style="color: hsl(0, 100%, 40%);">-                  if rsp.endswith(b'OK\r\n'):</span><br><span style="color: hsl(0, 100%, 40%);">-                             log.debug('Command finished with result: OK')</span><br><span style="color: hsl(0, 100%, 40%);">-                           break</span><br><span style="color: hsl(0, 100%, 40%);">-                   if rsp.endswith(b'ERROR\r\n'):</span><br><span style="color: hsl(0, 100%, 40%);">-                          log.error('Command finished with result: ERROR')</span><br><span style="color: hsl(0, 100%, 40%);">-                                break</span><br><span style="color: hsl(120, 100%, 40%);">+                 lines = rsp.split(b'\r\n')</span><br><span style="color: hsl(120, 100%, 40%);">+                    if len(lines) >= 2:</span><br><span style="color: hsl(120, 100%, 40%);">+                                res = lines[-2]</span><br><span style="color: hsl(120, 100%, 40%);">+                               if res == b'OK':</span><br><span style="color: hsl(120, 100%, 40%);">+                                      log.debug('Command finished with result: %s', res)</span><br><span style="color: hsl(120, 100%, 40%);">+                                    break</span><br><span style="color: hsl(120, 100%, 40%);">+                         if res == b'ERROR' or res.startswith(b'+CME ERROR:'):</span><br><span style="color: hsl(120, 100%, 40%);">+                                 log.error('Command failed with result: %s', res)</span><br><span style="color: hsl(120, 100%, 40%);">+                                      break</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>                      if time.time() - t_start >= timeout:</span><br><span>                              log.info('Command finished with timeout >= %ss', timeout)</span><br><span>                                 break</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/pysim/+/24158">change 24158</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/pysim/+/24158"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: pysim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I41af33c1898f5ed3d1c5238e45f956c6ceab2826 </div>
<div style="display:none"> Gerrit-Change-Number: 24158 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Falkenber9 <robert.falkenberg@tu-dortmund.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>