<p>Hoernchen <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-trx/+/24147">View Change</a></p><div style="white-space:pre-wrap">Approvals:
fixeria: Looks good to me, but someone else must approve
pespin: Looks good to me, but someone else must approve
Hoernchen: Looks good to me, approved
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">add hidden fn adjustment command<br><br>This is only useful if the rf path delays the signal by at least one<br>frame, and therefore a fairly experimental command that might be removed<br>or reworked in the future and should not be relied upon.<br><br>Change-Id: I29964acffad5bad4f5bcad7f631e435a72979c46<br>---<br>M CommonLibs/config_defs.h<br>M CommonLibs/trx_vty.c<br>M Transceiver52M/Transceiver.cpp<br>3 files changed, 19 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/CommonLibs/config_defs.h b/CommonLibs/config_defs.h</span><br><span>index 17352c3..33be73f 100644</span><br><span>--- a/CommonLibs/config_defs.h</span><br><span>+++ b/CommonLibs/config_defs.h</span><br><span>@@ -48,6 +48,7 @@</span><br><span> double offset;</span><br><span> double freq_offset_khz;</span><br><span> double rssi_offset;</span><br><span style="color: hsl(120, 100%, 40%);">+ int ul_fn_offset;</span><br><span> bool force_rssi_offset; /* Force value set in VTY? */</span><br><span> bool swap_channels;</span><br><span> bool ext_rach;</span><br><span>diff --git a/CommonLibs/trx_vty.c b/CommonLibs/trx_vty.c</span><br><span>index d1da450..30f55c8 100644</span><br><span>--- a/CommonLibs/trx_vty.c</span><br><span>+++ b/CommonLibs/trx_vty.c</span><br><span>@@ -271,6 +271,20 @@</span><br><span> return CMD_SUCCESS;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+DEFUN_ATTR(cfg_ul_fn_offset, cfg_ul_fn_offset_cmd,</span><br><span style="color: hsl(120, 100%, 40%);">+ "ul-fn-offset <-10-10>",</span><br><span style="color: hsl(120, 100%, 40%);">+ "Adjusts the uplink frame FN by the specified amount\n"</span><br><span style="color: hsl(120, 100%, 40%);">+ "Frame Number offset\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ CMD_ATTR_HIDDEN)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ struct trx_ctx *trx = trx_from_vty(vty);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ trx->cfg.ul_fn_offset = atoi(argv[0]);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ return CMD_SUCCESS;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> DEFUN(cfg_swap_channels, cfg_swap_channels_cmd,</span><br><span> "swap-channels (disable|enable)",</span><br><span> "Swap primary and secondary channels of the PHY (if any)\n"</span><br><span>@@ -624,6 +638,8 @@</span><br><span> vty_out(vty, " filler access-burst-delay %u%s", trx->cfg.rach_delay, VTY_NEWLINE);</span><br><span> if (trx->cfg.stack_size != 0)</span><br><span> vty_out(vty, " stack-size %u%s", trx->cfg.stack_size, VTY_NEWLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (trx->cfg.ul_fn_offset != 0)</span><br><span style="color: hsl(120, 100%, 40%);">+ vty_out(vty, " ul-fn-offset %u%s", trx->cfg.ul_fn_offset, VTY_NEWLINE);</span><br><span> trx_rate_ctr_threshold_write_config(vty, " ");</span><br><span> </span><br><span> for (i = 0; i < trx->cfg.num_chans; i++) {</span><br><span>@@ -787,6 +803,7 @@</span><br><span> install_element(TRX_NODE, &cfg_stack_size_cmd);</span><br><span> </span><br><span> install_element(TRX_NODE, &cfg_chan_cmd);</span><br><span style="color: hsl(120, 100%, 40%);">+ install_element(TRX_NODE, &cfg_ul_fn_offset_cmd);</span><br><span> install_node(&chan_node, dummy_config_write);</span><br><span> install_element(CHAN_NODE, &cfg_chan_rx_path_cmd);</span><br><span> install_element(CHAN_NODE, &cfg_chan_tx_path_cmd);</span><br><span>diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp</span><br><span>index 91f06ec..9e7bd5a 100644</span><br><span>--- a/Transceiver52M/Transceiver.cpp</span><br><span>+++ b/Transceiver52M/Transceiver.cpp</span><br><span>@@ -649,7 +649,7 @@</span><br><span> }</span><br><span> </span><br><span> /* Set time and determine correlation type */</span><br><span style="color: hsl(0, 100%, 40%);">- burstTime = radio_burst->getTime();</span><br><span style="color: hsl(120, 100%, 40%);">+ burstTime = radio_burst->getTime() + cfg->ul_fn_offset;</span><br><span> CorrType type = expectedCorrType(burstTime, chan);</span><br><span> </span><br><span> /* Initialize struct bi */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-trx/+/24147">change 24147</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-trx/+/24147"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-trx </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I29964acffad5bad4f5bcad7f631e435a72979c46 </div>
<div style="display:none"> Gerrit-Change-Number: 24147 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Hoernchen <ewild@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Hoernchen <ewild@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>