<p>fixeria <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmocom-bb/+/24015">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
dexter: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">trx_toolkit/gsm_shared.py: s/GSM_BURST_LEN/GMSK_BURST_LEN/g<br><br>Change-Id: I7268196eb9fd822f0e7b65899e4c83c48a20ba5b<br>---<br>M src/target/trx_toolkit/data_msg.py<br>M src/target/trx_toolkit/gsm_shared.py<br>M src/target/trx_toolkit/rand_burst_gen.py<br>3 files changed, 7 insertions(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/target/trx_toolkit/data_msg.py b/src/target/trx_toolkit/data_msg.py</span><br><span>index f5d570f..5e42964 100644</span><br><span>--- a/src/target/trx_toolkit/data_msg.py</span><br><span>+++ b/src/target/trx_toolkit/data_msg.py</span><br><span>@@ -347,7 +347,7 @@</span><br><span> raise ValueError("Tx burst bits are not set")</span><br><span> </span><br><span> # FIXME: properly handle IDLE / NOPE indications</span><br><span style="color: hsl(0, 100%, 40%);">- if len(self.burst) not in (GSM_BURST_LEN, EDGE_BURST_LEN):</span><br><span style="color: hsl(120, 100%, 40%);">+ if len(self.burst) not in (GMSK_BURST_LEN, EDGE_BURST_LEN):</span><br><span> raise ValueError("Tx burst has odd length %u" % len(self.burst))</span><br><span> </span><br><span> def rand_pwr(self, min = None, max = None):</span><br><span>@@ -411,9 +411,9 @@</span><br><span> if length >= EDGE_BURST_LEN:</span><br><span> self.burst = list(burst[:EDGE_BURST_LEN])</span><br><span> else:</span><br><span style="color: hsl(0, 100%, 40%);">- self.burst = list(burst[:GSM_BURST_LEN])</span><br><span style="color: hsl(120, 100%, 40%);">+ self.burst = list(burst[:GMSK_BURST_LEN])</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- def rand_burst(self, length = GSM_BURST_LEN):</span><br><span style="color: hsl(120, 100%, 40%);">+ def rand_burst(self, length = GMSK_BURST_LEN):</span><br><span> ''' Generate a random message specific burst. '''</span><br><span> self.burst = [random.randint(0, 1) for _ in range(length)]</span><br><span> </span><br><span>@@ -578,7 +578,7 @@</span><br><span> raise ValueError("Rx burst bits are not set")</span><br><span> </span><br><span> # ... and can be either of GSM (GMSK) or EDGE (8-PSK)</span><br><span style="color: hsl(0, 100%, 40%);">- if len(self.burst) not in (GSM_BURST_LEN, EDGE_BURST_LEN):</span><br><span style="color: hsl(120, 100%, 40%);">+ if len(self.burst) not in (GMSK_BURST_LEN, EDGE_BURST_LEN):</span><br><span> raise ValueError("Rx burst has odd length %u" % len(self.burst))</span><br><span> </span><br><span> def _validate_burst_v1(self):</span><br><span>diff --git a/src/target/trx_toolkit/gsm_shared.py b/src/target/trx_toolkit/gsm_shared.py</span><br><span>index aac152e..7c50245 100644</span><br><span>--- a/src/target/trx_toolkit/gsm_shared.py</span><br><span>+++ b/src/target/trx_toolkit/gsm_shared.py</span><br><span>@@ -29,8 +29,8 @@</span><br><span> GSM_HYPERFRAME = 2048 * GSM_SUPERFRAME</span><br><span> </span><br><span> # Burst length</span><br><span style="color: hsl(0, 100%, 40%);">-GSM_BURST_LEN = 148</span><br><span style="color: hsl(0, 100%, 40%);">-EDGE_BURST_LEN = GSM_BURST_LEN * 3</span><br><span style="color: hsl(120, 100%, 40%);">+GMSK_BURST_LEN = 148</span><br><span style="color: hsl(120, 100%, 40%);">+EDGE_BURST_LEN = GMSK_BURST_LEN * 3</span><br><span> </span><br><span> class BurstType(Enum):</span><br><span> """ Burst types defined in 3GPP TS 45.002 """</span><br><span>diff --git a/src/target/trx_toolkit/rand_burst_gen.py b/src/target/trx_toolkit/rand_burst_gen.py</span><br><span>index 0eb2e8f..b9846ab 100644</span><br><span>--- a/src/target/trx_toolkit/rand_burst_gen.py</span><br><span>+++ b/src/target/trx_toolkit/rand_burst_gen.py</span><br><span>@@ -80,7 +80,7 @@</span><br><span> </span><br><span> # Generate a frequency correction burst</span><br><span> def gen_fb(self):</span><br><span style="color: hsl(0, 100%, 40%);">- return [0] * GSM_BURST_LEN</span><br><span style="color: hsl(120, 100%, 40%);">+ return [0] * GMSK_BURST_LEN</span><br><span> </span><br><span> # Generate a synchronization burst</span><br><span> def gen_sb(self, tsc = None):</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmocom-bb/+/24015">change 24015</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmocom-bb/+/24015"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmocom-bb </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I7268196eb9fd822f0e7b65899e4c83c48a20ba5b </div>
<div style="display:none"> Gerrit-Change-Number: 24015 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>