<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/pysim/+/24023">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  fixeria: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">transport/AT: Make sure PDU has upper case hex digits<br><br>Some modems may reject AT+CSIM if PDU contains lower<br>case hex digits [a-f]. Modem response is "ERROR"<br>without any error code.<br><br>This patch converts each PDU to upper case.<br><br>Tested with Sierra Wireless EM7565.<br>Example:<br>AT+CSIM=14,"00a40004023F00"<br>ERROR<br>AT+CSIM=14,"00A40004023F00"<br>+CSIM: 4,"612F"<br><br>OK<br><br><br>Change-Id: I318e36abc7ae975c62d32b7fe0ec949bf5997d13<br>---<br>M pySim/transport/modem_atcmd.py<br>1 file changed, 3 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pySim/transport/modem_atcmd.py b/pySim/transport/modem_atcmd.py</span><br><span>index ecf463c..eef38cb 100644</span><br><span>--- a/pySim/transport/modem_atcmd.py</span><br><span>+++ b/pySim/transport/modem_atcmd.py</span><br><span>@@ -99,6 +99,9 @@</span><br><span>                 pass # Nothing to do really ...</span><br><span> </span><br><span>  def _send_apdu_raw(self, pdu):</span><br><span style="color: hsl(120, 100%, 40%);">+                # Make sure pdu has upper case hex digits [A-F]</span><br><span style="color: hsl(120, 100%, 40%);">+               pdu = pdu.upper()</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>          # Prepare the command as described in 8.17</span><br><span>           cmd = 'AT+CSIM=%d,\"%s\"' % (len(pdu), pdu)</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/pysim/+/24023">change 24023</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/pysim/+/24023"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: pysim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I318e36abc7ae975c62d32b7fe0ec949bf5997d13 </div>
<div style="display:none"> Gerrit-Change-Number: 24023 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Falkenber9 <robert.falkenberg@tu-dortmund.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>