<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/pysim/+/24025">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">[pylint] Mark abstract CardKeyProvider.get() method as such<br><br>pySim/card_key_provider.py:67:2: E1111:<br> Assigning result of a function call, where the function<br>       has no return (assignment-from-no-return)<br><br>Change-Id: I43bab69f53300fbe837944735cd999fab5405d7a<br>---<br>M pySim/card_key_provider.py<br>1 file changed, 3 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/25/24025/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pySim/card_key_provider.py b/pySim/card_key_provider.py</span><br><span>index 05de0be..67b0b28 100644</span><br><span>--- a/pySim/card_key_provider.py</span><br><span>+++ b/pySim/card_key_provider.py</span><br><span>@@ -30,11 +30,12 @@</span><br><span> </span><br><span> from typing import List, Dict, Optional</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+import abc</span><br><span> import csv</span><br><span> </span><br><span> card_key_providers = [] # type: List['CardKeyProvider']</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-class CardKeyProvider(object):</span><br><span style="color: hsl(120, 100%, 40%);">+class CardKeyProvider(abc.ABC):</span><br><span>        """Base class, not containing any concrete implementation."""</span><br><span> </span><br><span>      VALID_FIELD_NAMES = ['ICCID', 'ADM1', 'IMSI', 'PIN1', 'PIN2', 'PUK1', 'PUK2']</span><br><span>@@ -67,6 +68,7 @@</span><br><span>            result = self.get(fields, key, value)</span><br><span>                return result.get(field)</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+  @abc.abstractmethod</span><br><span>  def get(self, fields:List[str], key:str, value:str) -> Dict[str,str]:</span><br><span>             """Get multiple card-individual fields for identified card.</span><br><span> </span><br><span>@@ -77,7 +79,6 @@</span><br><span>           Returns:</span><br><span>                     dictionary of {field, value} strings for each requested field from 'fields'</span><br><span>          """</span><br><span style="color: hsl(0, 100%, 40%);">-              pass</span><br><span> </span><br><span> class CardKeyProviderCsv(CardKeyProvider):</span><br><span>       """Card key provider implementation that allows to query against a specified CSV file"""</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/pysim/+/24025">change 24025</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/pysim/+/24025"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: pysim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I43bab69f53300fbe837944735cd999fab5405d7a </div>
<div style="display:none"> Gerrit-Change-Number: 24025 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>