<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/pysim/+/24032">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">[pylint] Fix referencing undefined variable 'shutil'<br><br>Let's just use the scope limited TemporaryDirectory() instead, so<br>the temporary directory will be removed by Python automatically.<br><br>pySim/filesystem.py:679:16: E0602: Undefined variable 'shutil' (undefined-variable)<br><br>Change-Id: I4ea833fd79f4342c33899124379be509ba1e35ed<br>---<br>M pySim/filesystem.py<br>1 file changed, 1 insertion(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/32/24032/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pySim/filesystem.py b/pySim/filesystem.py</span><br><span>index dec521e..edfe85d 100644</span><br><span>--- a/pySim/filesystem.py</span><br><span>+++ b/pySim/filesystem.py</span><br><span>@@ -659,8 +659,7 @@</span><br><span>         def do_edit_record_decoded(self, opts):</span><br><span>             """Edit the JSON representation of one record in an editor."""</span><br><span>             (orig_json, sw) = self._cmd.rs.read_record_dec(opts.record_nr)</span><br><span style="color: hsl(0, 100%, 40%);">-            dirname = tempfile.mkdtemp(prefix='pysim_')</span><br><span style="color: hsl(0, 100%, 40%);">-            try:</span><br><span style="color: hsl(120, 100%, 40%);">+            with tempfile.TemporaryDirectory(prefix='pysim_') as dirname:</span><br><span>                 filename = '%s/file' % dirname</span><br><span>                 # write existing data as JSON to file</span><br><span>                 with open(filename, 'w') as text_file:</span><br><span>@@ -675,8 +674,6 @@</span><br><span>                     (data, sw) = self._cmd.rs.update_record_dec(opts.record_nr, edited_json)</span><br><span>                     if data:</span><br><span>                         self._cmd.poutput_json(data)</span><br><span style="color: hsl(0, 100%, 40%);">-            finally:</span><br><span style="color: hsl(0, 100%, 40%);">-                shutil.rmtree(dirname)</span><br><span> </span><br><span> </span><br><span>     def __init__(self, fid:str, sfid:str=None, name:str=None, desc:str=None,</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/pysim/+/24032">change 24032</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/pysim/+/24032"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: pysim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I4ea833fd79f4342c33899124379be509ba1e35ed </div>
<div style="display:none"> Gerrit-Change-Number: 24032 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>