<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmo-sccp/+/23991">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ss7_vty: Print actual connected port number in case of IPA server<br><br>In IPA, unlike M3UA/SUA, we often have clients connecting from<br>random/unknown ports. In such cases, the configured remote port is '0'.<br><br>Let's use getsockname to determine the actual source ip/port of the<br>connected client (if any) during "show ... asp"<br><br>Change-Id: I1327a46d0b74c572d2ad828a958090af53b9fa37<br>Closes: SYS#5429<br>---<br>M src/osmo_ss7_vty.c<br>1 file changed, 11 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/91/23991/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo_ss7_vty.c b/src/osmo_ss7_vty.c</span><br><span>index b3aa9ef..4db3c53 100644</span><br><span>--- a/src/osmo_ss7_vty.c</span><br><span>+++ b/src/osmo_ss7_vty.c</span><br><span>@@ -37,6 +37,8 @@</span><br><span> #include <osmocom/vty/telnet_interface.h></span><br><span> #include <osmocom/vty/misc.h></span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/netif/stream.h></span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> #include <osmocom/sigtran/osmo_ss7.h></span><br><span> #include <osmocom/sigtran/protocol/mtp.h></span><br><span> </span><br><span>@@ -765,7 +767,15 @@</span><br><span>   vty_out(vty, "------------  ------------  -------------  ---- ----------------------- ----------%s", VTY_NEWLINE);</span><br><span> </span><br><span>     llist_for_each_entry(asp, &inst->asp_list, list) {</span><br><span style="color: hsl(0, 100%, 40%);">-               osmo_ss7_asp_peer_snprintf(buf, sizeof(buf), &asp->cfg.remote);</span><br><span style="color: hsl(120, 100%, 40%);">+                if (asp->cfg.proto == OSMO_SS7_ASP_PROT_IPA && asp->cfg.remote.port == 0 && asp->server) {</span><br><span style="color: hsl(120, 100%, 40%);">+                   struct osmo_fd *ofd = osmo_stream_srv_get_ofd(asp->server);</span><br><span style="color: hsl(120, 100%, 40%);">+                        char hostbuf[64];</span><br><span style="color: hsl(120, 100%, 40%);">+                     char portbuf[16];</span><br><span style="color: hsl(120, 100%, 40%);">+                     osmo_sock_get_ip_and_port(ofd->fd, hostbuf, sizeof(hostbuf),</span><br><span style="color: hsl(120, 100%, 40%);">+                                                 portbuf, sizeof(portbuf), false);</span><br><span style="color: hsl(120, 100%, 40%);">+                   snprintf(buf, sizeof(buf), "%s:%s", hostbuf, portbuf);</span><br><span style="color: hsl(120, 100%, 40%);">+              } else</span><br><span style="color: hsl(120, 100%, 40%);">+                        osmo_ss7_asp_peer_snprintf(buf, sizeof(buf), &asp->cfg.remote);</span><br><span>               vty_out(vty, "%-12s  %-12s  %-13s  %-4s  %-14s  %-10s%s",</span><br><span>                  asp->cfg.name, "?",</span><br><span>                     asp->fi? osmo_fsm_inst_state_name(asp->fi) : "uninitialized",</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmo-sccp/+/23991">change 23991</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmo-sccp/+/23991"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmo-sccp </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I1327a46d0b74c572d2ad828a958090af53b9fa37 </div>
<div style="display:none"> Gerrit-Change-Number: 23991 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>