<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmo-sccp/+/23990">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">osmo_ss7: free the sock_name string once an ASP socket is closed<br><br>It's confusing to keep around a string representation of what peer the<br>socket was previously connected to.<br><br>Change-Id: I00d47fc355bfe24915653767ad75c1f491c060d5<br>---<br>M src/osmo_ss7.c<br>1 file changed, 8 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/90/23990/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo_ss7.c b/src/osmo_ss7.c</span><br><span>index 6d68290..617f6bb 100644</span><br><span>--- a/src/osmo_ss7.c</span><br><span>+++ b/src/osmo_ss7.c</span><br><span>@@ -1759,6 +1759,10 @@</span><br><span>         osmo_fsm_inst_dispatch(asp->fi, XUA_ASP_E_SCTP_COMM_DOWN_IND, asp);</span><br><span>       /* send M-SCTP_RELEASE.ind to XUA Layer Manager */</span><br><span>   xua_asp_send_xlm_prim_simple(asp, OSMO_XLM_PRIM_M_SCTP_RELEASE, PRIM_OP_INDICATION);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+        /* no connection means no socket means no socket name */</span><br><span style="color: hsl(120, 100%, 40%);">+      talloc_free(asp->sock_name);</span><br><span style="color: hsl(120, 100%, 40%);">+       asp->sock_name = NULL;</span><br><span> }</span><br><span> </span><br><span> static void xua_cli_close_and_reconnect(struct osmo_stream_cli *cli)</span><br><span>@@ -1892,6 +1896,10 @@</span><br><span>          osmo_ss7_asp_destroy(asp);</span><br><span>   }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ /* no connection means no socket means no socket name */</span><br><span style="color: hsl(120, 100%, 40%);">+      talloc_free(asp->sock_name);</span><br><span style="color: hsl(120, 100%, 40%);">+       asp->sock_name = NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>  return 0;</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmo-sccp/+/23990">change 23990</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmo-sccp/+/23990"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmo-sccp </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I00d47fc355bfe24915653767ad75c1f491c060d5 </div>
<div style="display:none"> Gerrit-Change-Number: 23990 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>