<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmo-sccp/+/23981">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">xua_asp_fsm: Fix IPA client role<br><br>The IPA server worked as expected, but the IPA client has some clear<br>logic bug that prevented it from working.  It shows that we never<br>really use any of that IPA/SCCPlite stuff after years in spec-compliant<br>SIGTRAN land.<br><br>A client now first waits for the IPA_REQ, sends its IPA_RESP, then<br>waits for the ACK, ...<br><br>Change-Id: Icfc32cad7d65c94dc21754b8f879afcf34d34a92<br>---<br>M src/xua_asp_fsm.c<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/81/23981/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/xua_asp_fsm.c b/src/xua_asp_fsm.c</span><br><span>index ec85d21..8bff976 100644</span><br><span>--- a/src/xua_asp_fsm.c</span><br><span>+++ b/src/xua_asp_fsm.c</span><br><span>@@ -867,7 +867,7 @@</span><br><span>                       }</span><br><span>            } else {</span><br><span>                     /* Client: We simply wait for an ID GET */</span><br><span style="color: hsl(0, 100%, 40%);">-                      osmo_fsm_inst_state_chg(fi, IPA_ASP_S_WAIT_ID_ACK, 10, T_WAIT_ID_ACK);</span><br><span style="color: hsl(120, 100%, 40%);">+                        osmo_fsm_inst_state_chg(fi, IPA_ASP_S_WAIT_ID_GET, 10, T_WAIT_ID_ACK);</span><br><span>               }</span><br><span>            break;</span><br><span>       }</span><br><span>@@ -1081,7 +1081,7 @@</span><br><span>    [IPA_ASP_S_DOWN] = {</span><br><span>                 .in_event_mask = S(XUA_ASP_E_M_ASP_UP_REQ) |</span><br><span>                                  S(XUA_ASP_E_SCTP_EST_IND),</span><br><span style="color: hsl(0, 100%, 40%);">-             .out_state_mask = S(IPA_ASP_S_WAIT_ID_ACK) |</span><br><span style="color: hsl(120, 100%, 40%);">+          .out_state_mask = S(IPA_ASP_S_WAIT_ID_GET) |</span><br><span>                                   S(IPA_ASP_S_WAIT_ID_RESP),</span><br><span>                 .name = "ASP_DOWN",</span><br><span>                .action = ipa_asp_fsm_down,</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmo-sccp/+/23981">change 23981</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmo-sccp/+/23981"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmo-sccp </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Icfc32cad7d65c94dc21754b8f879afcf34d34a92 </div>
<div style="display:none"> Gerrit-Change-Number: 23981 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>