<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/23925">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">fix default_timeout type of osmo_tdef_fsm_inst_state_chg default_timeout<br><br>The api doc indicates the possibility to pass -1, and calling<br>osmo_tdef_get() actually casts the arg to a signed long. To end the<br>confusion, change default_timeout from unsigned long to long.<br><br>Change-Id: I51b9172603984839448346c9836e43c8c802fcf8<br>---<br>M TODO-RELEASE<br>M include/osmocom/core/tdef.h<br>M src/tdef.c<br>3 files changed, 3 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/TODO-RELEASE b/TODO-RELEASE</span><br><span>index 7ba9347..c5d4ee8 100644</span><br><span>--- a/TODO-RELEASE</span><br><span>+++ b/TODO-RELEASE</span><br><span>@@ -10,3 +10,4 @@</span><br><span> libosmovty       _LAST_OSMOVTY_NODE      Raise _LAST_OSMOVTY_NODE by introducing some RESERVED*_NODE</span><br><span> libosmogsm      gsm0808_old_bss_to_new_bss_info ABI break (struct changes size), gsm0808_old_bss_to_new_bss_info_att_tlvdef symbol added</span><br><span> libosmosim   osim_card_hdl           ABI + API breakage due to new struct members</span><br><span style="color: hsl(120, 100%, 40%);">+libosmocore       osmo_tdef_fsm_inst_state_chg    change default_timeout arg from unsigned long to long type (API breakage, not ABI)</span><br><span>diff --git a/include/osmocom/core/tdef.h b/include/osmocom/core/tdef.h</span><br><span>index 627ba3f..d9d2675 100644</span><br><span>--- a/include/osmocom/core/tdef.h</span><br><span>+++ b/include/osmocom/core/tdef.h</span><br><span>@@ -162,7 +162,7 @@</span><br><span>                                  __FILE__, __LINE__)</span><br><span> int _osmo_tdef_fsm_inst_state_chg(struct osmo_fsm_inst *fi, uint32_t state,</span><br><span>                               const struct osmo_tdef_state_timeout *timeouts_array,</span><br><span style="color: hsl(0, 100%, 40%);">-                           const struct osmo_tdef *tdefs, unsigned long default_timeout,</span><br><span style="color: hsl(120, 100%, 40%);">+                                 const struct osmo_tdef *tdefs, signed long default_timeout,</span><br><span>                                  const char *file, int line);</span><br><span> </span><br><span> /*! Manage timer definitions in named groups.</span><br><span>diff --git a/src/tdef.c b/src/tdef.c</span><br><span>index 897a92f..9890f95 100644</span><br><span>--- a/src/tdef.c</span><br><span>+++ b/src/tdef.c</span><br><span>@@ -331,7 +331,7 @@</span><br><span>  */</span><br><span> int _osmo_tdef_fsm_inst_state_chg(struct osmo_fsm_inst *fi, uint32_t state,</span><br><span>                                   const struct osmo_tdef_state_timeout *timeouts_array,</span><br><span style="color: hsl(0, 100%, 40%);">-                           const struct osmo_tdef *tdefs, unsigned long default_timeout,</span><br><span style="color: hsl(120, 100%, 40%);">+                                 const struct osmo_tdef *tdefs, long default_timeout,</span><br><span>                                 const char *file, int line)</span><br><span> {</span><br><span>   const struct osmo_tdef_state_timeout *t = osmo_tdef_get_state_timeout(state, timeouts_array);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/23925">change 23925</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/23925"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I51b9172603984839448346c9836e43c8c802fcf8 </div>
<div style="display:none"> Gerrit-Change-Number: 23925 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>