<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23903">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">pcu: Drop test TC_t3169<br><br>This test was added a long time ago to test what used to be the previous<br>early implementation of T3169, which didn't follow specs as per TS<br>44.060.<br>Since recently, osmo-pcu supports tracking UL PDCH blocks and hence<br>properly implementing N3101 and N3101, finally also implementing T3169<br>correctly.<br>The counters N3101/3 and timer T3169 are already being tested in<br>following tests:<br>TC_n3101_max_t3169<br>TC_n3103_max_t3169<br><br>Since osmo-pcu I2cec531e2633281b88f69ba065c0105580c81076, time-based<br>T3169 is dropped and TC_t3169 doesn't pass anymore, since it had wrong<br>expectancies (because it's not sending RTS to osmo-pcu, hence not<br>triggering USF/RRBP N3101/3 timeouts).<br><br>Change-Id: I023fb406f1df6e67e16982cb11dc1fcb6fb9b544<br>---<br>M pcu/PCU_Tests.ttcn<br>1 file changed, 0 insertions(+), 44 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/03/23903/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn</span><br><span>index 2509e2b..5345bc7 100644</span><br><span>--- a/pcu/PCU_Tests.ttcn</span><br><span>+++ b/pcu/PCU_Tests.ttcn</span><br><span>@@ -1270,49 +1270,6 @@</span><br><span> f_dl_data_exp_cs(f_rlcmac_block_int2cs_mcs(g_mcs_max_dl, true), bssgp_ms_racap_egprs_def);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* Verify PCU drops TBF after some time of inactivity. */</span><br><span style="color: hsl(0, 100%, 40%);">-testcase TC_t3169() runs on RAW_PCU_Test_CT {</span><br><span style="color: hsl(0, 100%, 40%);">- var PCUIF_info_ind info_ind;</span><br><span style="color: hsl(0, 100%, 40%);">- var RlcmacDlBlock dl_block;</span><br><span style="color: hsl(0, 100%, 40%);">- var uint32_t unused_fn;</span><br><span style="color: hsl(0, 100%, 40%);">- var GprsMS ms;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- /* Initialize NS/BSSGP side */</span><br><span style="color: hsl(0, 100%, 40%);">- f_init_bssgp();</span><br><span style="color: hsl(0, 100%, 40%);">- /* Initialize GPRS MS side */</span><br><span style="color: hsl(0, 100%, 40%);">- f_init_gprs_ms();</span><br><span style="color: hsl(0, 100%, 40%);">- ms := g_ms[0]; /* We only use first MS in this test */</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- info_ind := valueof(ts_PCUIF_INFO_default(c_PCUIF_Flags_noMCS));</span><br><span style="color: hsl(0, 100%, 40%);">- /* Set timer to 1 sec (default 5) to speedup test: */</span><br><span style="color: hsl(0, 100%, 40%);">- info_ind.t3169 := 1;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- /* Initialize the PCU interface abstraction */</span><br><span style="color: hsl(0, 100%, 40%);">- f_init_raw(testcasename(), info_ind);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- /* Establish BSSGP connection to the PCU */</span><br><span style="color: hsl(0, 100%, 40%);">- f_bssgp_establish();</span><br><span style="color: hsl(0, 100%, 40%);">- f_bssgp_client_llgmm_assign(TLLI_UNUSED, ms.tlli);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- /* Establish an Uplink TBF */</span><br><span style="color: hsl(0, 100%, 40%);">- f_ms_establish_ul_tbf(ms);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- /* Send one UL block (with TLLI since we are in One-Phase Access</span><br><span style="color: hsl(0, 100%, 40%);">- contention resoultion) and make sure it is ACKED fine */</span><br><span style="color: hsl(0, 100%, 40%);">- f_ms_tx_ul_data_block(ms, f_rnd_octstring(10), cv := 1, with_tlli := true, fn := ms.ul_tbf.start_time_fn)</span><br><span style="color: hsl(0, 100%, 40%);">- f_rx_rlcmac_dl_block_exp_ack_nack(dl_block, unused_fn);</span><br><span style="color: hsl(0, 100%, 40%);">- /* UL block should NOT be received in SGSN, since we didn't get CV=0 */</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- /* Wait until T3169 fires (plus 1 extra sec to make sure) */</span><br><span style="color: hsl(0, 100%, 40%);">- f_sleep(int2float(info_ind.t3169) + 1.0);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- /* Send an UL block once again, the TBF should be gone by now so no ACK */</span><br><span style="color: hsl(0, 100%, 40%);">- f_ms_tx_ul_data_block(ms, f_rnd_octstring(10), cv := 0)</span><br><span style="color: hsl(0, 100%, 40%);">- f_rx_rlcmac_dl_block_exp_dummy(dl_block);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- f_shutdown(__BFILE__, __LINE__, final := true);</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> /* Validate what happens when RACH to get UL TBF and then PCU receives no UL</span><br><span> * data. It should end up in N3101 reaching N3101_MAX and finally triggering</span><br><span> * T3169. See OS#5033 */</span><br><span>@@ -5773,7 +5730,6 @@</span><br><span> execute( TC_mcs_max_ul() );</span><br><span> execute( TC_mcs_initial_dl() );</span><br><span> execute( TC_mcs_max_dl() );</span><br><span style="color: hsl(0, 100%, 40%);">- execute( TC_t3169() );</span><br><span> execute( TC_n3101_max_t3169() );</span><br><span> execute( TC_n3103_max_t3169() );</span><br><span> execute( TC_x2031_t3191() );</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23903">change 23903</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23903"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I023fb406f1df6e67e16982cb11dc1fcb6fb9b544 </div>
<div style="display:none"> Gerrit-Change-Number: 23903 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>