<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmo-sccp/+/23890">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Don't create duplicate routes in osmo_ss7_route_create()<br><br>Let's refuse to create exactly identical routes<br><br>Change-Id: I520415d4499a4017dfdbdfc3cd67522e1bbd1627<br>Related: SYS#5422<br>---<br>M src/osmo_ss7.c<br>1 file changed, 9 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo_ss7.c b/src/osmo_ss7.c</span><br><span>index 7021fa8..98dfc0c 100644</span><br><span>--- a/src/osmo_ss7.c</span><br><span>+++ b/src/osmo_ss7.c</span><br><span>@@ -783,6 +783,15 @@</span><br><span>                  return NULL;</span><br><span>         }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ /* check for duplicates */</span><br><span style="color: hsl(120, 100%, 40%);">+    rt = osmo_ss7_route_find_dpc_mask(rtbl, pc, mask);</span><br><span style="color: hsl(120, 100%, 40%);">+    if (rt && !strcmp(rt->cfg.linkset_name, linkset_name)) {</span><br><span style="color: hsl(120, 100%, 40%);">+           LOGSS7(rtbl->inst, LOGL_ERROR, "Refusing to create duplicate route: "</span><br><span style="color: hsl(120, 100%, 40%);">+                    "pc=%u=%s mask=0x%x via linkset/AS '%s'\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                 pc, osmo_ss7_pointcode_print(rtbl->inst, pc), mask, linkset_name);</span><br><span style="color: hsl(120, 100%, 40%);">+         return rt;</span><br><span style="color: hsl(120, 100%, 40%);">+    }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>  rt = talloc_zero(rtbl, struct osmo_ss7_route);</span><br><span>       if (!rt)</span><br><span>             return NULL;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmo-sccp/+/23890">change 23890</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmo-sccp/+/23890"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmo-sccp </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I520415d4499a4017dfdbdfc3cd67522e1bbd1627 </div>
<div style="display:none"> Gerrit-Change-Number: 23890 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>