<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/23906">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Use negative numbers for non-spec osmo-specific timers<br><br>(values -1 and -2 cannot be used because they are already taken).<br><br>Related: OS#3928<br>Change-Id: Ibcdb05ff5bb8efe6cb95cf94e2c8e418dc8deced<br>---<br>M src/gprs_bssgp_pcu.c<br>M src/gprs_pcu.c<br>2 files changed, 5 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/06/23906/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gprs_bssgp_pcu.c b/src/gprs_bssgp_pcu.c</span><br><span>index 4170a66..06e1814 100644</span><br><span>--- a/src/gprs_bssgp_pcu.c</span><br><span>+++ b/src/gprs_bssgp_pcu.c</span><br><span>@@ -975,7 +975,7 @@</span><br><span> if (!the_pcu->bssgp.bvc_sig_reset) {</span><br><span> LOGP(DBSSGP, LOGL_INFO, "Sending reset on BVCI 0\n");</span><br><span> bssgp_tx_bvc_reset(the_pcu->bssgp.bctx, 0, BSSGP_CAUSE_OML_INTERV);</span><br><span style="color: hsl(0, 100%, 40%);">- secs = osmo_tdef_get(the_pcu->T_defs, 2, OSMO_TDEF_S, -1);</span><br><span style="color: hsl(120, 100%, 40%);">+ secs = osmo_tdef_get(the_pcu->T_defs, -102, OSMO_TDEF_S, -1);</span><br><span> osmo_timer_schedule(&the_pcu->bssgp.bvc_timer, secs, 0);</span><br><span> return;</span><br><span> }</span><br><span>@@ -984,7 +984,7 @@</span><br><span> LOGP(DBSSGP, LOGL_INFO, "Sending reset on BVCI %d\n",</span><br><span> the_pcu->bssgp.bctx->bvci);</span><br><span> bssgp_tx_bvc_reset(the_pcu->bssgp.bctx, the_pcu->bssgp.bctx->bvci, BSSGP_CAUSE_OML_INTERV);</span><br><span style="color: hsl(0, 100%, 40%);">- secs = osmo_tdef_get(the_pcu->T_defs, 2, OSMO_TDEF_S, -1);</span><br><span style="color: hsl(120, 100%, 40%);">+ secs = osmo_tdef_get(the_pcu->T_defs, -102, OSMO_TDEF_S, -1);</span><br><span> osmo_timer_schedule(&the_pcu->bssgp.bvc_timer, secs, 0);</span><br><span> return;</span><br><span> }</span><br><span>@@ -993,7 +993,7 @@</span><br><span> LOGP(DBSSGP, LOGL_INFO, "Sending unblock on BVCI %d\n",</span><br><span> the_pcu->bssgp.bctx->bvci);</span><br><span> bssgp_tx_bvc_unblock(the_pcu->bssgp.bctx);</span><br><span style="color: hsl(0, 100%, 40%);">- secs = osmo_tdef_get(the_pcu->T_defs, 1, OSMO_TDEF_S, -1);</span><br><span style="color: hsl(120, 100%, 40%);">+ secs = osmo_tdef_get(the_pcu->T_defs, -101, OSMO_TDEF_S, -1);</span><br><span> osmo_timer_schedule(&the_pcu->bssgp.bvc_timer, secs, 0);</span><br><span> return;</span><br><span> }</span><br><span>diff --git a/src/gprs_pcu.c b/src/gprs_pcu.c</span><br><span>index 52e9825..226b861 100644</span><br><span>--- a/src/gprs_pcu.c</span><br><span>+++ b/src/gprs_pcu.c</span><br><span>@@ -30,13 +30,13 @@</span><br><span> struct gprs_pcu *the_pcu;</span><br><span> </span><br><span> static struct osmo_tdef T_defs_pcu[] = {</span><br><span style="color: hsl(0, 100%, 40%);">- { .T=1, .default_val=30, .unit=OSMO_TDEF_S, .desc="BSSGP (un)blocking procedures timer (s)", .val=0 },</span><br><span style="color: hsl(0, 100%, 40%);">- { .T=2, .default_val=30, .unit=OSMO_TDEF_S, .desc="BSSGP reset procedure timer (s)", .val=0 },</span><br><span> { .T=3190, .default_val=5, .unit=OSMO_TDEF_S, .desc="Return to packet idle mode after Packet DL Assignment on CCCH (s)", .val=0},</span><br><span> { .T=PCU_TDEF_NEIGH_RESOLVE_TO, .default_val=1000, .unit=OSMO_TDEF_MS, .desc="[ARFCN+BSIC]->[RAC+CI] resolution timeout (ms)", .val=0 },</span><br><span> { .T=PCU_TDEF_SI_RESOLVE_TO, .default_val=1000, .unit=OSMO_TDEF_MS, .desc="RIM RAN-INFO response timeout (ms)", .val=0 },</span><br><span> { .T=PCU_TDEF_NEIGH_CACHE_ALIVE, .default_val=5, .unit=OSMO_TDEF_S, .desc="[ARFCN+BSIC]->[RAC+CI] resolution cache entry storage timeout (s)", .val=0 },</span><br><span> { .T=PCU_TDEF_SI_CACHE_ALIVE, .default_val=5, .unit=OSMO_TDEF_S, .desc="[RAC+CI]->[SI] resolution cache entry storage timeout (s)", .val=0 },</span><br><span style="color: hsl(120, 100%, 40%);">+ { .T=-101, .default_val=30, .unit=OSMO_TDEF_S, .desc="BSSGP (un)blocking procedures timer (s)", .val=0 },</span><br><span style="color: hsl(120, 100%, 40%);">+ { .T=-102, .default_val=30, .unit=OSMO_TDEF_S, .desc="BSSGP reset procedure timer (s)", .val=0 },</span><br><span> { .T=-2000, .default_val=2, .unit=OSMO_TDEF_MS, .desc="Tbf reject for PRR timer (ms)", .val=0 },</span><br><span> { .T=-2001, .default_val=2, .unit=OSMO_TDEF_S, .desc="PACCH assignment timer (s)", .val=0 },</span><br><span> { .T=-2002, .default_val=200, .unit=OSMO_TDEF_MS, .desc="Waiting after IMM.ASS confirm timer (ms)", .val=0 },</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/23906">change 23906</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/23906"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ibcdb05ff5bb8efe6cb95cf94e2c8e418dc8deced </div>
<div style="display:none"> Gerrit-Change-Number: 23906 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>