<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/23761">View Change</a></p><div style="white-space:pre-wrap">Approvals:
laforge: Looks good to me, approved
fixeria: Looks good to me, but someone else must approve
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">SRVCC: Forward Last EUTRAN PLMN Id in Handover Required<br><br>"""<br>The old BSS shall inform the new BSS of the MS's last used E-UTRAN PLMN<br>in the "Last used E-UTRAN PLMN ID" information element included in the<br>"Old BSS to New BSS information" Information Element if this information<br>is present.<br>"""<br><br>Depends: libosmocore.git Change-Id I6280ce1abc283f1491bc6f391b2dd952df33a16b<br>Related: SYS#5337<br>Change-Id: I6cf54f9a16d598f98dc56b25f0fef56225a25a28<br>---<br>M TODO-RELEASE<br>M src/osmo-bsc/osmo_bsc_bssap.c<br>2 files changed, 12 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/TODO-RELEASE b/TODO-RELEASE</span><br><span>index de9e62c..d0e3ff0 100644</span><br><span>--- a/TODO-RELEASE</span><br><span>+++ b/TODO-RELEASE</span><br><span>@@ -9,3 +9,4 @@</span><br><span> #library what description / commit summary line</span><br><span> libosmocore >1.5.1 needs osmo_bts_features_name(), osmo_bts_features_desc()</span><br><span> libosmogsm >1.5.1 enum entry GSM0808_FE_IE_LAST_USED_EUTRAN_PLMN_ID</span><br><span style="color: hsl(120, 100%, 40%);">+libosmogsm >1.5.1 introduced struct needed gsm0808_old_bss_to_new_bss_info->last_eutran_plmn_id</span><br><span>diff --git a/src/osmo-bsc/osmo_bsc_bssap.c b/src/osmo-bsc/osmo_bsc_bssap.c</span><br><span>index fc1484e..c3716ce 100644</span><br><span>--- a/src/osmo-bsc/osmo_bsc_bssap.c</span><br><span>+++ b/src/osmo-bsc/osmo_bsc_bssap.c</span><br><span>@@ -1358,6 +1358,7 @@</span><br><span> {</span><br><span> int rc;</span><br><span> struct msgb *msg;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct gsm_subscriber_connection *conn = lchan->conn;</span><br><span> struct gsm0808_handover_required params = {</span><br><span> .cause = GSM0808_CAUSE_BETTER_CELL,</span><br><span> .cil = *target_cells,</span><br><span>@@ -1365,6 +1366,12 @@</span><br><span> .current_channel_type_1 = gsm0808_current_channel_type_1(lchan->type),</span><br><span> };</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ if (conn->last_eutran_plmn_valid) {</span><br><span style="color: hsl(120, 100%, 40%);">+ params.old_bss_to_new_bss_info_present = true;</span><br><span style="color: hsl(120, 100%, 40%);">+ params.old_bss_to_new_bss_info.last_eutran_plmn_id_present = true;</span><br><span style="color: hsl(120, 100%, 40%);">+ params.old_bss_to_new_bss_info.last_eutran_plmn_id = conn->last_eutran_plmn;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> switch (lchan->type) {</span><br><span> case GSM_LCHAN_TCH_F:</span><br><span> case GSM_LCHAN_TCH_H:</span><br><span>@@ -1383,14 +1390,14 @@</span><br><span> </span><br><span> msg = gsm0808_create_handover_required(¶ms);</span><br><span> if (!msg) {</span><br><span style="color: hsl(0, 100%, 40%);">- LOG_HO(lchan->conn, LOGL_ERROR, "Cannot compose BSSMAP Handover Required message\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ LOG_HO(conn, LOGL_ERROR, "Cannot compose BSSMAP Handover Required message\n");</span><br><span> return -EINVAL;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- rate_ctr_inc(&lchan->conn->sccp.msc->msc_ctrs->ctr[MSC_CTR_BSSMAP_TX_DT1_HANDOVER_REQUIRED]);</span><br><span style="color: hsl(0, 100%, 40%);">- rc = gscon_sigtran_send(lchan->conn, msg);</span><br><span style="color: hsl(120, 100%, 40%);">+ rate_ctr_inc(&conn->sccp.msc->msc_ctrs->ctr[MSC_CTR_BSSMAP_TX_DT1_HANDOVER_REQUIRED]);</span><br><span style="color: hsl(120, 100%, 40%);">+ rc = gscon_sigtran_send(conn, msg);</span><br><span> if (rc) {</span><br><span style="color: hsl(0, 100%, 40%);">- LOG_HO(lchan->conn, LOGL_ERROR, "Cannot send BSSMAP Handover Required message\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ LOG_HO(conn, LOGL_ERROR, "Cannot send BSSMAP Handover Required message\n");</span><br><span> return rc;</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/23761">change 23761</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/23761"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I6cf54f9a16d598f98dc56b25f0fef56225a25a28 </div>
<div style="display:none"> Gerrit-Change-Number: 23761 </div>
<div style="display:none"> Gerrit-PatchSet: 9 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>