<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcap/+/23879">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">use telnet_init_dynif() to allow VTY bind to non-loopack address<br><br>Prior to this patch, you could configure 'bind 1.2.3.4' in the<br>config file, but the telnet interface still binds to 127.0.0.1.<br><br>Change-Id: I9b86b2cf6949917c55ea15277619cfa2b745185d<br>---<br>M src/osmo_client_main.c<br>M src/osmo_server_main.c<br>2 files changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/79/23879/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo_client_main.c b/src/osmo_client_main.c</span><br><span>index 831450d..0951115 100644</span><br><span>--- a/src/osmo_client_main.c</span><br><span>+++ b/src/osmo_client_main.c</span><br><span>@@ -259,7 +259,7 @@</span><br><span> </span><br><span>   osmo_tls_init();</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-    rc = telnet_init(tall_cli_ctx, NULL, OSMO_VTY_PORT_PCAP_CLIENT);</span><br><span style="color: hsl(120, 100%, 40%);">+      rc = telnet_init_dynif(tall_cli_ctx, NULL, vty_get_bind_addr(), OSMO_VTY_PORT_PCAP_CLIENT);</span><br><span>  if (rc < 0) {</span><br><span>             LOGP(DCLIENT, LOGL_ERROR, "Failed to bind telnet interface\n");</span><br><span>            exit(1);</span><br><span>diff --git a/src/osmo_server_main.c b/src/osmo_server_main.c</span><br><span>index 112bd47..b5f573c 100644</span><br><span>--- a/src/osmo_server_main.c</span><br><span>+++ b/src/osmo_server_main.c</span><br><span>@@ -271,7 +271,7 @@</span><br><span> </span><br><span>      osmo_tls_init();</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-    rc = telnet_init(tall_srv_ctx, NULL, OSMO_VTY_PORT_PCAP_SERVER);</span><br><span style="color: hsl(120, 100%, 40%);">+      rc = telnet_init_dynif(tall_srv_ctx, NULL, vty_get_bind_addr(), OSMO_VTY_PORT_PCAP_SERVER);</span><br><span>  if (rc < 0) {</span><br><span>             LOGP(DCLIENT, LOGL_ERROR, "Failed to bind telnet interface\n");</span><br><span>            exit(1);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcap/+/23879">change 23879</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcap/+/23879"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcap </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I9b86b2cf6949917c55ea15277619cfa2b745185d </div>
<div style="display:none"> Gerrit-Change-Number: 23879 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>