<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23877">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">pcu: Take into account TbfStartingTime<br><br>New versions of osmo-pcu will validate the Pkt Resource Request is sent<br>on the correct FN, so we must send first UL block exactly when<br>requested.<br><br>Change-Id: I6dad0f3167ace8d4a763fed971db94f32faf6ced<br>---<br>M pcu/GPRS_Components.ttcn<br>M pcu/PCU_Tests.ttcn<br>2 files changed, 50 insertions(+), 23 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/77/23877/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pcu/GPRS_Components.ttcn b/pcu/GPRS_Components.ttcn</span><br><span>index 57cd837..6fe17cb 100644</span><br><span>--- a/pcu/GPRS_Components.ttcn</span><br><span>+++ b/pcu/GPRS_Components.ttcn</span><br><span>@@ -96,7 +96,8 @@</span><br><span> uint3_t usf[8],</span><br><span> boolean is_egprs,</span><br><span> uint14_t bsn,</span><br><span style="color: hsl(0, 100%, 40%);">- CodingScheme tx_cs_mcs</span><br><span style="color: hsl(120, 100%, 40%);">+ CodingScheme tx_cs_mcs,</span><br><span style="color: hsl(120, 100%, 40%);">+ uint32_t start_time_fn</span><br><span> };</span><br><span> </span><br><span> type record GprsMS {</span><br><span>@@ -160,7 +161,8 @@</span><br><span> usf := { USF_UNUSED, USF_UNUSED, USF_UNUSED, USF_UNUSED, USF_UNUSED, USF_UNUSED, USF_UNUSED, USF_UNUSED },</span><br><span> is_egprs := false,</span><br><span> bsn := 0,</span><br><span style="color: hsl(0, 100%, 40%);">- tx_cs_mcs := CS_1</span><br><span style="color: hsl(120, 100%, 40%);">+ tx_cs_mcs := CS_1,</span><br><span style="color: hsl(120, 100%, 40%);">+ start_time_fn := 0</span><br><span> };</span><br><span> </span><br><span> type component MS_BTS_IFACE_CT {</span><br><span>@@ -233,6 +235,12 @@</span><br><span> return mp_base_arfcn + trx_nr;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* 3GPP TS 44.018 10.5.2.38 Starting Time */</span><br><span style="color: hsl(120, 100%, 40%);">+function f_tbf_starting_time_2_fn_mod_42432(TbfStartingTime st)</span><br><span style="color: hsl(120, 100%, 40%);">+runs on MS_BTS_IFACE_CT return uint32_t {</span><br><span style="color: hsl(120, 100%, 40%);">+ return 51 * ((st.t3 - st.t2) mod 26) + st.t3 + 51 * 26 * st.t1;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> function f_ultbf_new_from_rr_imm_ass(in GsmRrMessage rr_imm_ass)</span><br><span> runs on MS_BTS_IFACE_CT return UlTbf {</span><br><span> var UlTbf ul_tbf := valueof(t_UlTbf_def);</span><br><span>@@ -254,8 +262,11 @@</span><br><span> ul_tbf.tfi := ul_tbf.ass.ccch.dynamic.tfi_assignment;</span><br><span> ul_tbf.tx_cs_mcs := f_rlcmac_block_ChCodingCommand2cs_mcs(ul_tbf.ass.ccch.dynamic.ch_coding_cmd);</span><br><span> ul_tbf.usf[tn_allocated] := ul_tbf.ass.ccch.dynamic.usf;</span><br><span style="color: hsl(120, 100%, 40%);">+ if (ul_tbf.ass.ccch.dynamic.tbf_starting_time_present == '1'B) {</span><br><span style="color: hsl(120, 100%, 40%);">+ ul_tbf.start_time_fn := f_tbf_starting_time_2_fn_mod_42432(ul_tbf.ass.ccch.dynamic.tbf_starting_time);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> } else if (match(ul_tbf.ass.ccch, tr_PacketUlSglAssign)) {</span><br><span style="color: hsl(0, 100%, 40%);">- /* Nothing to do here yet */</span><br><span style="color: hsl(120, 100%, 40%);">+ ul_tbf.start_time_fn := f_tbf_starting_time_2_fn_mod_42432(ul_tbf.ass.ccch.single.tbf_starting_time);</span><br><span> }</span><br><span> } else if (match(rr_imm_ass, tr_IMM_TBF_ASS(dl := false, rest := tr_IaRestOctets_EGPRSULAss(?)))) {</span><br><span> ul_tbf.ass.ccch_egprs := rr_imm_ass.payload.imm_ass.rest_octets.lh.egprs_ul;</span><br><span>@@ -265,8 +276,13 @@</span><br><span> ul_tbf.tfi := ul_tbf.ass.ccch_egprs.dynamic.tfi_assignment;</span><br><span> ul_tbf.tx_cs_mcs := f_rlcmac_block_EgprsChCodingCommand2cs_mcs(ul_tbf.ass.ccch_egprs.dynamic.egprs_ch_coding_cmd);</span><br><span> ul_tbf.usf[tn_allocated] := ul_tbf.ass.ccch_egprs.dynamic.usf;</span><br><span style="color: hsl(120, 100%, 40%);">+ if (ul_tbf.ass.ccch_egprs.dynamic.tbf_starting_time_present == '1'B) {</span><br><span style="color: hsl(120, 100%, 40%);">+ ul_tbf.start_time_fn := f_tbf_starting_time_2_fn_mod_42432(ul_tbf.ass.ccch_egprs.dynamic.tbf_starting_time);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> } else if (match(ul_tbf.ass.ccch_egprs, tr_EgprsUlAssMultiblock)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ ul_tbf.start_time_fn := f_tbf_starting_time_2_fn_mod_42432(ul_tbf.ass.ccch_egprs.multiblock.tbf_starting_time);</span><br><span> /* Nothing to do here yet */</span><br><span style="color: hsl(120, 100%, 40%);">+ /*TODO:*/</span><br><span> }</span><br><span> } else {</span><br><span> setverdict(fail, "Failed to match UL TBF Assignment: ", rr_imm_ass);</span><br><span>@@ -661,7 +677,7 @@</span><br><span> </span><br><span> /* Send random payload for last "num_blocks" blocks in Ul TBF (ending with CV=0). */</span><br><span> function f_ms_tx_ul_data_block_multi(inout GprsMS ms, integer num_blocks := 1, boolean with_tlli := false,</span><br><span style="color: hsl(0, 100%, 40%);">- template (value) TsTrxBtsNum nr := ts_TsTrxBtsNum)</span><br><span style="color: hsl(120, 100%, 40%);">+ uint32_t fn := 0, template (value) TsTrxBtsNum nr := ts_TsTrxBtsNum)</span><br><span> runs on MS_BTS_IFACE_CT return octetstring {</span><br><span> var octetstring total_payload := ''O;</span><br><span> var uint32_t payload_fill_len := f_ultbf_payload_fill_length(ms.ul_tbf, with_tlli, 0);</span><br><span>@@ -673,7 +689,12 @@</span><br><span> if (cv > g_bs_cv_max) {</span><br><span> cv := 15;</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">- f_ms_tx_ul_data_block(ms, payload, cv := cv, with_tlli := with_tlli, nr := nr);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (i == 1) {</span><br><span style="color: hsl(120, 100%, 40%);">+ /* We use FN on i=0 to jump to wanted FN time, then simply submit on next</span><br><span style="color: hsl(120, 100%, 40%);">+ * avaialble frame (fn=0) */</span><br><span style="color: hsl(120, 100%, 40%);">+ fn := 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ f_ms_tx_ul_data_block(ms, payload, cv := cv, with_tlli := with_tlli, fn := fn, nr := nr);</span><br><span> total_payload := total_payload & payload;</span><br><span> }</span><br><span> return total_payload;</span><br><span>diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn</span><br><span>index a466732..2509e2b 100644</span><br><span>--- a/pcu/PCU_Tests.ttcn</span><br><span>+++ b/pcu/PCU_Tests.ttcn</span><br><span>@@ -316,7 +316,7 @@</span><br><span> var RlcmacDlBlock dl_block;</span><br><span> var uint32_t poll_fn;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- f_ms_tx_ul_data_block(g_ms[i], dummy, with_tlli := true, nr := nr);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_ms_tx_ul_data_block(g_ms[i], dummy, with_tlli := true, fn := g_ms[i].ul_tbf.start_time_fn, nr := nr);</span><br><span> f_rx_rlcmac_dl_block_exp_ack_nack(dl_block, poll_fn, nr := nr);</span><br><span> }</span><br><span> }</span><br><span>@@ -354,7 +354,7 @@</span><br><span> pkt_res_req := ts_RlcMacUlCtrl_PKT_RES_REQ(ms.tlli, omit);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- f_ms_tx_ul_block(ms, ts_RLC_UL_CTRL_ACK(valueof(pkt_res_req)), 0, nr := f_ms_tx_TsTrxBtsNum(ms));</span><br><span style="color: hsl(120, 100%, 40%);">+ f_ms_tx_ul_block(ms, ts_RLC_UL_CTRL_ACK(valueof(pkt_res_req)), ms.ul_tbf.start_time_fn, nr := f_ms_tx_TsTrxBtsNum(ms));</span><br><span> /* Store 1st UlTBF context before receiving next one, will</span><br><span> * overwrite the TS allocation on MS with info from new UL TBF:</span><br><span> */</span><br><span>@@ -420,7 +420,7 @@</span><br><span> </span><br><span> /* Send one UL block (with TLLI since we are in One-Phase Access</span><br><span> contention resoultion) and make sure it is ACKED fine */</span><br><span style="color: hsl(0, 100%, 40%);">- f_ms_tx_ul_data_block_multi(ms, 1, with_tlli := true);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_ms_tx_ul_data_block_multi(ms, 1, with_tlli := true, fn := ms.ul_tbf.start_time_fn);</span><br><span> f_rx_rlcmac_dl_block_exp_ack_nack(dl_block, sched_fn);</span><br><span> /* DL ACK/NACK sets poll+rrbp requesting PACKET CONTROL ACK */</span><br><span> f_ms_tx_ul_block(ms, ts_RLCMAC_CTRL_ACK(ms.tlli), sched_fn);</span><br><span>@@ -765,7 +765,7 @@</span><br><span> contention resoultion) and make sure it is ACKED fine. */</span><br><span> /* 16 bytes fills the llc block (because TLLI takes 4 bytes) */</span><br><span> /* Set CV = 15 to signal there's still more than BS_CV_MAX blocks to be sent */</span><br><span style="color: hsl(0, 100%, 40%);">- f_ms_tx_ul_data_block(ms, f_rnd_octstring(16), cv := 15, with_tlli := true)</span><br><span style="color: hsl(120, 100%, 40%);">+ f_ms_tx_ul_data_block(ms, f_rnd_octstring(16), cv := 15, with_tlli := true, fn := ms.ul_tbf.start_time_fn)</span><br><span> f_rx_rlcmac_dl_block_exp_ack_nack(dl_block, sched_fn);</span><br><span> /* DL ACK/NACK sets poll+rrbp requesting PACKET CONTROL ACK */</span><br><span> f_ms_tx_ul_block(ms, ts_RLCMAC_CTRL_ACK(ms.tlli), sched_fn);</span><br><span>@@ -849,7 +849,7 @@</span><br><span> contention resoultion) and make sure it is ACKED fine. */</span><br><span> /* 16 bytes fills the llc block (because TLLI takes 4 bytes) */</span><br><span> /* Set CV = 15 to signal there's still more than BS_CV_MAX blocks to be sent */</span><br><span style="color: hsl(0, 100%, 40%);">- f_ms_tx_ul_data_block(ms, f_rnd_octstring(16), cv := 15, with_tlli := true)</span><br><span style="color: hsl(120, 100%, 40%);">+ f_ms_tx_ul_data_block(ms, f_rnd_octstring(16), cv := 15, with_tlli := true, fn := ms.ul_tbf.start_time_fn)</span><br><span> f_rx_rlcmac_dl_block_exp_ack_nack(dl_block, sched_fn);</span><br><span> /* DL ACK/NACK sets poll+rrbp requesting PACKET CONTROL ACK */</span><br><span> f_ms_tx_ul_block(ms, ts_RLCMAC_CTRL_ACK(ms.tlli), sched_fn);</span><br><span>@@ -921,7 +921,7 @@</span><br><span> contention resoultion) and make sure it is ACKED fine. */</span><br><span> /* 16 bytes fills the llc block (because TLLI takes 4 bytes) */</span><br><span> /* Set CV = 15 to signal there's still more than BS_CV_MAX blocks to be sent */</span><br><span style="color: hsl(0, 100%, 40%);">- f_ms_tx_ul_data_block(ms, f_rnd_octstring(16), cv := 15, with_tlli := true)</span><br><span style="color: hsl(120, 100%, 40%);">+ f_ms_tx_ul_data_block(ms, f_rnd_octstring(16), cv := 15, with_tlli := true, fn := ms.ul_tbf.start_time_fn)</span><br><span> f_rx_rlcmac_dl_block_exp_ack_nack(dl_block, sched_fn);</span><br><span> /* DL ACK/NACK sets poll+rrbp requesting PACKET CONTROL ACK */</span><br><span> f_ms_tx_ul_block(ms, ts_RLCMAC_CTRL_ACK(ms.tlli), sched_fn);</span><br><span>@@ -1299,7 +1299,7 @@</span><br><span> </span><br><span> /* Send one UL block (with TLLI since we are in One-Phase Access</span><br><span> contention resoultion) and make sure it is ACKED fine */</span><br><span style="color: hsl(0, 100%, 40%);">- f_ms_tx_ul_data_block(ms, f_rnd_octstring(10), cv := 1, with_tlli := true)</span><br><span style="color: hsl(120, 100%, 40%);">+ f_ms_tx_ul_data_block(ms, f_rnd_octstring(10), cv := 1, with_tlli := true, fn := ms.ul_tbf.start_time_fn)</span><br><span> f_rx_rlcmac_dl_block_exp_ack_nack(dl_block, unused_fn);</span><br><span> /* UL block should NOT be received in SGSN, since we didn't get CV=0 */</span><br><span> </span><br><span>@@ -1905,7 +1905,7 @@</span><br><span> contention resoultion) and make sure it is ACKED fine. */</span><br><span> total_payload := f_rnd_octstring(f_ultbf_payload_fill_length(ms.ul_tbf, true));</span><br><span> /* Set CV = 15 to signal there's still more than BS_CV_MAX blocks to be sent */</span><br><span style="color: hsl(0, 100%, 40%);">- f_ms_tx_ul_data_block(ms, total_payload, cv := 15, with_tlli := true)</span><br><span style="color: hsl(120, 100%, 40%);">+ f_ms_tx_ul_data_block(ms, total_payload, cv := 15, with_tlli := true, fn := ms.ul_tbf.start_time_fn)</span><br><span> f_rx_rlcmac_dl_block_exp_ack_nack(dl_block, sched_fn);</span><br><span> /* DL ACK/NACK sets poll+rrbp requesting PACKET CONTROL ACK */</span><br><span> f_ms_tx_ul_block(ms, ts_RLCMAC_CTRL_ACK(ms.tlli), sched_fn);</span><br><span>@@ -1966,7 +1966,7 @@</span><br><span> blocks := blocks,</span><br><span> tlli := ms.tlli);</span><br><span> f_ultbf_inc_bsn(ms.ul_tbf);</span><br><span style="color: hsl(0, 100%, 40%);">- f_ms_tx_ul_block(ms, ul_data);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_ms_tx_ul_block(ms, ul_data, ms.ul_tbf.start_time_fn);</span><br><span> </span><br><span> /* ACK and check it was received fine */</span><br><span> f_rx_rlcmac_dl_block_exp_ack_nack(dl_block, sched_fn);</span><br><span>@@ -2122,7 +2122,7 @@</span><br><span> </span><br><span> /* Send one UL block (with TLLI since we are in One-Phase Access</span><br><span> contention resoultion) and make sure it is ACKED fine */</span><br><span style="color: hsl(0, 100%, 40%);">- f_ms_tx_ul_data_block_multi(ms, 1, with_tlli := true);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_ms_tx_ul_data_block_multi(ms, 1, with_tlli := true, fn := ms.ul_tbf.start_time_fn);</span><br><span> f_rx_rlcmac_dl_block_exp_ack_nack(dl_block, sched_fn);</span><br><span> /* DL ACK/NACK sets poll+rrbp requesting PACKET CONTROL ACK */</span><br><span> f_ms_tx_ul_block(ms, ts_RLCMAC_CTRL_ACK(ms.tlli), sched_fn);</span><br><span>@@ -2349,7 +2349,7 @@</span><br><span> /* Send one UL block (with TLLI since we are in One-Phase Access</span><br><span> contention resoultion) and make sure it is ACKED fine. */</span><br><span> payload := f_rnd_octstring(f_ultbf_payload_fill_length(ms.ul_tbf, true)); /* 16 bytes fills the llc block (because TLLI takes 4 bytes) */</span><br><span style="color: hsl(0, 100%, 40%);">- f_ms_tx_ul_data_block(ms, payload, cv := 15, with_tlli := true);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_ms_tx_ul_data_block(ms, payload, cv := 15, with_tlli := true, fn := ms.ul_tbf.start_time_fn);</span><br><span> </span><br><span> f_rx_rlcmac_dl_block_exp_ack_nack(dl_block, sched_fn);</span><br><span> /* DL ACK/NACK sets poll+rrbp requesting PACKET CONTROL ACK */</span><br><span>@@ -2580,7 +2580,7 @@</span><br><span> * RLCMAC block being sent. */</span><br><span> ul_data.data.mac_hdr.e := true;</span><br><span> f_ultbf_inc_bsn(ms.ul_tbf);</span><br><span style="color: hsl(0, 100%, 40%);">- f_ms_tx_ul_block(ms, ul_data);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_ms_tx_ul_block(ms, ul_data, ms.ul_tbf.start_time_fn);</span><br><span> </span><br><span> /* UL RlcDataBlock(dataA finished, dataB starts) [BSN=1, CV=2] */</span><br><span> ul_data := t_RLCMAC_UL_DATA_TLLI(cs := CS_1,</span><br><span>@@ -2765,7 +2765,8 @@</span><br><span> </span><br><span> /* Send one UL block (with TLLI since we are in One-Phase Access</span><br><span> contention resoultion) and make sure it is ACKED fine */</span><br><span style="color: hsl(0, 100%, 40%);">- f_ms_tx_ul_data_block(ms, data, with_tlli := true, nr := f_ms_tx_TsTrxBtsNum(ms));</span><br><span style="color: hsl(120, 100%, 40%);">+ f_ms_tx_ul_data_block(ms, data, ms.ul_tbf.start_time_fn, with_tlli := true,</span><br><span style="color: hsl(120, 100%, 40%);">+ fn := ms.ul_tbf.start_time_fn, nr := f_ms_tx_TsTrxBtsNum(ms));</span><br><span> /* DL ACK/NACK sets poll+rrbp requesting PACKET CONTROL ACK */</span><br><span> f_rx_rlcmac_dl_block_exp_ack_nack(dl_block, poll_fn, nr := f_ms_tx_TsTrxBtsNum(ms));</span><br><span> </span><br><span>@@ -2908,7 +2909,7 @@</span><br><span> </span><br><span> /* Send one UL block (with TLLI since we are in One-Phase Access</span><br><span> contention resoultion) and make sure it is ACKED fine */</span><br><span style="color: hsl(0, 100%, 40%);">- f_ms_tx_ul_data_block_multi(ms, 1, with_tlli := true);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_ms_tx_ul_data_block_multi(ms, 1, with_tlli := true, fn := ms.ul_tbf.start_time_fn);</span><br><span> </span><br><span> /* UL block should be received in SGSN */</span><br><span> BSSGP[0].receive(tr_BSSGP_UL_UD(ms.tlli, mp_gb_cfg.bvc[0].cell_id));</span><br><span>@@ -3128,7 +3129,7 @@</span><br><span> f_ms_establish_ul_tbf(ms);</span><br><span> </span><br><span> /* Fake GMM GPRS Attach or similar, PCU doesn't care about upper layers here */</span><br><span style="color: hsl(0, 100%, 40%);">- f_ms_tx_ul_data_block_multi(ms, 1, with_tlli := true);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_ms_tx_ul_data_block_multi(ms, 1, with_tlli := true, fn := ms.ul_tbf.start_time_fn);</span><br><span> f_rx_rlcmac_dl_block_exp_ack_nack(dl_block, sched_fn);</span><br><span> /* DL ACK/NACK sets poll+rrbp requesting PACKET CONTROL ACK */</span><br><span> f_ms_tx_ul_block(ms, ts_RLCMAC_CTRL_ACK(ms.tlli), sched_fn);</span><br><span>@@ -3187,7 +3188,7 @@</span><br><span> f_ms_establish_ul_tbf(ms);</span><br><span> </span><br><span> /* Fake GMM GPRS Attach or similar, PCU doesn't care about upper layers here */</span><br><span style="color: hsl(0, 100%, 40%);">- f_ms_tx_ul_data_block_multi(ms, 1, with_tlli := true);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_ms_tx_ul_data_block_multi(ms, 1, with_tlli := true, fn := ms.ul_tbf.start_time_fn);</span><br><span> f_rx_rlcmac_dl_block_exp_ack_nack(dl_block, sched_fn);</span><br><span> /* DL ACK/NACK sets poll+rrbp requesting PACKET CONTROL ACK */</span><br><span> f_ms_tx_ul_block(ms, ts_RLCMAC_CTRL_ACK(ms.tlli), sched_fn);</span><br><span>@@ -3676,11 +3677,16 @@</span><br><span> /* Initialize the PCU interface abstraction */</span><br><span> f_init_raw(testcasename(), info_ind);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ /* Single block (two phase) packet access */</span><br><span style="color: hsl(120, 100%, 40%);">+ var uint16_t ra := bit2int(chan_req_sb);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_ms_use_ra(ms, ra, ra_is_11bit := 0);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* Establish an Uplink TBF */</span><br><span> f_ms_establish_ul_tbf(ms);</span><br><span> </span><br><span> /* Send Packet Resource Request, so the network will allocate an Uplink resource */</span><br><span style="color: hsl(0, 100%, 40%);">- f_ms_tx_ul_block(ms, ts_RLC_UL_CTRL_ACK(ts_RlcMacUlCtrl_PKT_RES_REQ(ms.tlli, omit)));</span><br><span style="color: hsl(120, 100%, 40%);">+ f_ms_tx_ul_block(ms, ts_RLC_UL_CTRL_ACK(ts_RlcMacUlCtrl_PKT_RES_REQ(ms.tlli, omit)),</span><br><span style="color: hsl(120, 100%, 40%);">+ fn := ms.ul_tbf.start_time_fn);</span><br><span> </span><br><span> /* Expect an RLC/MAC block with Packet Uplink Assignment on PACCH (see 11.2.29) */</span><br><span> f_ms_rx_pkt_ass_pacch(ms, poll_fn, tr_RLCMAC_UL_PACKET_ASS);</span><br><span>@@ -3729,7 +3735,7 @@</span><br><span> f_ms_establish_ul_tbf(ms);</span><br><span> </span><br><span> /* Send an Uplink block, so this TBF becomes "active" */</span><br><span style="color: hsl(0, 100%, 40%);">- f_ms_tx_ul_data_block(ms, data, with_tlli := true);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_ms_tx_ul_data_block(ms, data, with_tlli := true, fn := ms.ul_tbf.start_time_fn);</span><br><span> </span><br><span> /* DL ACK/NACK sets poll+rrbp requesting PACKET CONTROL ACK */</span><br><span> f_rx_rlcmac_dl_block_exp_ack_nack(dl_block, poll_fn);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23877">change 23877</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23877"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I6dad0f3167ace8d4a763fed971db94f32faf6ced </div>
<div style="display:none"> Gerrit-Change-Number: 23877 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>