<p>pespin <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/23795">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, but someone else must approve
dexter: Looks good to me, but someone else must approve
pespin: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gsm0808: Introduce gsm0808_old_bss_to_new_bss_info_att_tlvdef<br><br>Introduce TLV attribute definition for "Old BSS to New BSS Information"<br>container.<br><br>Related: SYS#5337<br>Change-Id: I0e55e947b6fef6dad0cf1a6c16b781bef4cc76c5<br>---<br>M TODO-RELEASE<br>M include/osmocom/gsm/gsm0808.h<br>M src/gsm/gsm0808.c<br>M src/gsm/libosmogsm.map<br>4 files changed, 29 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/TODO-RELEASE b/TODO-RELEASE</span><br><span>index 53401ec..ed04a14 100644</span><br><span>--- a/TODO-RELEASE</span><br><span>+++ b/TODO-RELEASE</span><br><span>@@ -8,4 +8,4 @@</span><br><span> # If any interfaces have been removed or changed since the last public release: c:r:0.</span><br><span> #library what description / commit summary line</span><br><span> libosmovty _LAST_OSMOVTY_NODE Raise _LAST_OSMOVTY_NODE by introducing some RESERVED*_NODE</span><br><span style="color: hsl(0, 100%, 40%);">-libosmogsm gsm0808_old_bss_to_new_bss_info ABI break (struct changes size)</span><br><span style="color: hsl(120, 100%, 40%);">+libosmogsm gsm0808_old_bss_to_new_bss_info ABI break (struct changes size), gsm0808_old_bss_to_new_bss_info_att_tlvdef symbol added</span><br><span>diff --git a/include/osmocom/gsm/gsm0808.h b/include/osmocom/gsm/gsm0808.h</span><br><span>index ecb9827..dc3610f 100644</span><br><span>--- a/include/osmocom/gsm/gsm0808.h</span><br><span>+++ b/include/osmocom/gsm/gsm0808.h</span><br><span>@@ -311,6 +311,7 @@</span><br><span> void gsm0808_prepend_dtap_header(struct msgb *msg, uint8_t link_id);</span><br><span> </span><br><span> const struct tlv_definition *gsm0808_att_tlvdef(void);</span><br><span style="color: hsl(120, 100%, 40%);">+extern const struct tlv_definition gsm0808_old_bss_to_new_bss_info_att_tlvdef;</span><br><span> </span><br><span> /*! Parse BSSAP TLV structure using \ref tlv_parse */</span><br><span> #define osmo_bssap_tlv_parse(dec, buf, len) tlv_parse(dec, gsm0808_att_tlvdef(), buf, len, 0, 0)</span><br><span>diff --git a/src/gsm/gsm0808.c b/src/gsm/gsm0808.c</span><br><span>index 578c7fa..3a39fd1 100644</span><br><span>--- a/src/gsm/gsm0808.c</span><br><span>+++ b/src/gsm/gsm0808.c</span><br><span>@@ -1576,6 +1576,32 @@</span><br><span> return &bss_att_tlvdef;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* As per 3GPP TS 48.008 version 16.0.0 Release 16 ยง 3.2.2.58 Old BSS to New BSS Information */</span><br><span style="color: hsl(120, 100%, 40%);">+const struct tlv_definition gsm0808_old_bss_to_new_bss_info_att_tlvdef = {</span><br><span style="color: hsl(120, 100%, 40%);">+ .def = {</span><br><span style="color: hsl(120, 100%, 40%);">+ [GSM0808_FE_IE_EXTRA_INFORMATION] = { TLV_TYPE_TLV },</span><br><span style="color: hsl(120, 100%, 40%);">+ [GSM0808_FE_IE_CURRENT_CHANNEL_TYPE_2] = { TLV_TYPE_TLV },</span><br><span style="color: hsl(120, 100%, 40%);">+ [GSM0808_FE_IE_TARGET_CELL_RADIO_INFORMATION] = { TLV_TYPE_TLV },</span><br><span style="color: hsl(120, 100%, 40%);">+ [GSM0808_FE_IE_GPRS_SUSPEND_INFORMATION] = { TLV_TYPE_TLV },</span><br><span style="color: hsl(120, 100%, 40%);">+ [GSM0808_FE_IE_MULTIRATE_CONFIGURATION_INFORMATION] = { TLV_TYPE_TLV },</span><br><span style="color: hsl(120, 100%, 40%);">+ [GSM0808_FE_IE_DUAL_TRANSFER_MODE_INFORMATION] = { TLV_TYPE_TLV },</span><br><span style="color: hsl(120, 100%, 40%);">+ [GSM0808_FE_IE_INTER_RAT_HANDOVER_INFO] = { TLV_TYPE_TLV },</span><br><span style="color: hsl(120, 100%, 40%);">+ [GSM0808_FE_IE_CDMA2000_CAPABILITY_INFORMATION] = { TLV_TYPE_TLV },</span><br><span style="color: hsl(120, 100%, 40%);">+ [GSM0808_FE_IE_DOWNLINK_CELL_LOAD_INFORMATION] = { TLV_TYPE_TLV },</span><br><span style="color: hsl(120, 100%, 40%);">+ [GSM0808_FE_IE_UPLINK_CELL_LOAD_INFORMATION] = { TLV_TYPE_TLV },</span><br><span style="color: hsl(120, 100%, 40%);">+ [GSM0808_FE_IE_CELL_LOAD_INFORMATION_GROUP] = { TLV_TYPE_TLV },</span><br><span style="color: hsl(120, 100%, 40%);">+ [GSM0808_FE_IE_CELL_LOAD_INFORMATION] = { TLV_TYPE_TLV },</span><br><span style="color: hsl(120, 100%, 40%);">+ [GSM0808_FE_IE_PS_INDICATION] = { TLV_TYPE_TLV },</span><br><span style="color: hsl(120, 100%, 40%);">+ [GSM0808_FE_IE_DTM_HANDOVER_COMMAND_INDICATION] = { TLV_TYPE_TLV },</span><br><span style="color: hsl(120, 100%, 40%);">+ [GSM0808_FE_IE_D_RNTI] = { TLV_TYPE_TLV },</span><br><span style="color: hsl(120, 100%, 40%);">+ [GSM0808_FE_IE_IRAT_MEASUREMENT_CONFIGURATION] = { TLV_TYPE_TLV },</span><br><span style="color: hsl(120, 100%, 40%);">+ [GSM0808_FE_IE_SOURCE_CELL_ID] = { TLV_TYPE_TLV },</span><br><span style="color: hsl(120, 100%, 40%);">+ [GSM0808_FE_IE_IRAT_MEASUREMENT_CONFIGURATION_EXTENDED_E_ARFCNS] = { TLV_TYPE_TLV },</span><br><span style="color: hsl(120, 100%, 40%);">+ [GSM0808_FE_IE_VGCS_TALKER_MODE] = { TLV_TYPE_TLV },</span><br><span style="color: hsl(120, 100%, 40%);">+ [GSM0808_FE_IE_LAST_USED_EUTRAN_PLMN_ID] = { TLV_TYPE_FIXED, 3 },</span><br><span style="color: hsl(120, 100%, 40%);">+ },</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> const struct value_string gsm0406_dlci_sapi_names[] = {</span><br><span> { DLCI_SAPI_RR_MM_CC, "RR/MM/CC" },</span><br><span> { DLCI_SAPI_SMS, "SMS" },</span><br><span>diff --git a/src/gsm/libosmogsm.map b/src/gsm/libosmogsm.map</span><br><span>index 56a57b8..3fd01db 100644</span><br><span>--- a/src/gsm/libosmogsm.map</span><br><span>+++ b/src/gsm/libosmogsm.map</span><br><span>@@ -154,6 +154,7 @@</span><br><span> gsm0503_mcs9;</span><br><span> </span><br><span> gsm0808_att_tlvdef;</span><br><span style="color: hsl(120, 100%, 40%);">+gsm0808_old_bss_to_new_bss_info_att_tlvdef;</span><br><span> gsm0808_bssap_name;</span><br><span> gsm0808_bssmap_name;</span><br><span> gsm0808_cause_name;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/23795">change 23795</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/23795"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I0e55e947b6fef6dad0cf1a6c16b781bef4cc76c5 </div>
<div style="display:none"> Gerrit-Change-Number: 23795 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>