<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/23825">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">osmo-bts-trx: reduce and share TRXC message buffer size<br><br>struct 'trx_ctrl_msg' limits the length of the command and its<br>parameters to 28 and 100 characters respectively.  And this is<br>generally enough for TRXC messages, no need to allocate 1500<br>bytes for that.  Define the macro in the header file.<br><br>Change-Id: I21c9ef37954c73ab74f07a3d226707744cbb2f01<br>Related: SYS#4895, OS#4941, OS#4006<br>---<br>M src/osmo-bts-trx/trx_if.c<br>M src/osmo-bts-trx/trx_if.h<br>2 files changed, 6 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/25/23825/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bts-trx/trx_if.c b/src/osmo-bts-trx/trx_if.c</span><br><span>index 495de92..0041b76 100644</span><br><span>--- a/src/osmo-bts-trx/trx_if.c</span><br><span>+++ b/src/osmo-bts-trx/trx_if.c</span><br><span>@@ -95,7 +95,7 @@</span><br><span> {</span><br><span>    struct phy_link *plink = ofd->data;</span><br><span>       struct phy_instance *pinst = phy_instance_by_num(plink, 0);</span><br><span style="color: hsl(0, 100%, 40%);">-     char buf[1500];</span><br><span style="color: hsl(120, 100%, 40%);">+       char buf[TRXC_MSG_BUF_SIZE];</span><br><span>         ssize_t len;</span><br><span>         uint32_t fn;</span><br><span> </span><br><span>@@ -148,7 +148,7 @@</span><br><span> static void trx_ctrl_send(struct trx_l1h *l1h)</span><br><span> {</span><br><span>        struct trx_ctrl_msg *tcm;</span><br><span style="color: hsl(0, 100%, 40%);">-       char buf[1500];</span><br><span style="color: hsl(120, 100%, 40%);">+       char buf[TRXC_MSG_BUF_SIZE];</span><br><span>         int len;</span><br><span>     ssize_t snd_len;</span><br><span> </span><br><span>@@ -634,7 +634,7 @@</span><br><span> {</span><br><span>      struct trx_l1h *l1h = ofd->data;</span><br><span>  struct phy_instance *pinst = l1h->phy_inst;</span><br><span style="color: hsl(0, 100%, 40%);">-  char buf[1500];</span><br><span style="color: hsl(120, 100%, 40%);">+       char buf[TRXC_MSG_BUF_SIZE];</span><br><span>         struct trx_ctrl_rsp rsp;</span><br><span>     int len, rc;</span><br><span>         struct trx_ctrl_msg *tcm;</span><br><span>diff --git a/src/osmo-bts-trx/trx_if.h b/src/osmo-bts-trx/trx_if.h</span><br><span>index 8adb22f..76dfbc4 100644</span><br><span>--- a/src/osmo-bts-trx/trx_if.h</span><br><span>+++ b/src/osmo-bts-trx/trx_if.h</span><br><span>@@ -1,5 +1,8 @@</span><br><span> #pragma once</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* TRXC read/send buffer size */</span><br><span style="color: hsl(120, 100%, 40%);">+#define TRXC_MSG_BUF_SIZE   128</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> struct trx_dl_burst_req;</span><br><span> struct trx_l1h;</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/23825">change 23825</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/23825"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I21c9ef37954c73ab74f07a3d226707744cbb2f01 </div>
<div style="display:none"> Gerrit-Change-Number: 23825 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>