<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/23792">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">rsl: add missing Channel Mode values to rsl_handle_chan_mod_ie()<br><br>Change-Id: I125cdaaf5adac0891a964c9834b99eb5a35ce262<br>Depends-On: I40eca759380c8895d7923b2b4259d37a50978160<br>Depends-On: Icf4c83fa443b8410f4362c119b0a85419036b9cd<br>---<br>M src/common/rsl.c<br>1 file changed, 17 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/92/23792/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/rsl.c b/src/common/rsl.c</span><br><span>index 6884712..8a7cd13 100644</span><br><span>--- a/src/common/rsl.c</span><br><span>+++ b/src/common/rsl.c</span><br><span>@@ -164,7 +164,15 @@</span><br><span>     case RSL_CMODE(RSL_CMOD_SPD_SPEECH, RSL_CMOD_SP_GSM3):</span><br><span>               lchan->tch_mode = GSM48_CMODE_SPEECH_AMR;</span><br><span>                 break;</span><br><span style="color: hsl(0, 100%, 40%);">-  /* TODO: also handle RSL_CMOD_SP_{GSM4,GSM5,GSM6} */</span><br><span style="color: hsl(120, 100%, 40%);">+  case RSL_CMODE(RSL_CMOD_SPD_SPEECH, RSL_CMOD_SP_GSM4):</span><br><span style="color: hsl(120, 100%, 40%);">+        case RSL_CMODE(RSL_CMOD_SPD_SPEECH, RSL_CMOD_SP_GSM5):</span><br><span style="color: hsl(120, 100%, 40%);">+        case RSL_CMODE(RSL_CMOD_SPD_SPEECH, RSL_CMOD_SP_GSM6):</span><br><span style="color: hsl(120, 100%, 40%);">+                /* TODO: also handle RSL_CMOD_SP_{GSM4,GSM5,GSM6} */</span><br><span style="color: hsl(120, 100%, 40%);">+          LOGPLCHAN(lchan, DRSL, LOGL_ERROR, "Channel Mode IE contains "</span><br><span style="color: hsl(120, 100%, 40%);">+                        "unhandled speech coding algorithm 0x%02x\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                       cm->chan_rate);</span><br><span style="color: hsl(120, 100%, 40%);">+          *cause = RSL_ERR_IE_CONTENT;</span><br><span style="color: hsl(120, 100%, 40%);">+          return -ENOTSUP;</span><br><span> </span><br><span>         /* If octet 4 indicates non-transparent data */</span><br><span>      case RSL_CMODE(RSL_CMOD_SPD_DATA, RSL_CMOD_CSD_NT_14k5):</span><br><span>@@ -178,7 +186,14 @@</span><br><span>              break;</span><br><span>       case RSL_CMODE(RSL_CMOD_SPD_DATA, RSL_CMOD_CSD_NT_43k5):</span><br><span>     case RSL_CMODE(RSL_CMOD_SPD_DATA, RSL_CMOD_CSD_NT_28k8):</span><br><span style="color: hsl(0, 100%, 40%);">-        /* TODO: also handle non-transparent asymmetric data rates */</span><br><span style="color: hsl(120, 100%, 40%);">+ case RSL_CMODE(RSL_CMOD_SPD_DATA, RSL_CMOD_CSD_NT_28k8):</span><br><span style="color: hsl(120, 100%, 40%);">+      case RSL_CMODE(RSL_CMOD_SPD_DATA, RSL_CMOD_CSD_NTA_43k5_14k5):</span><br><span style="color: hsl(120, 100%, 40%);">+        case RSL_CMODE(RSL_CMOD_SPD_DATA, RSL_CMOD_CSD_NTA_29k0_14k5):</span><br><span style="color: hsl(120, 100%, 40%);">+        case RSL_CMODE(RSL_CMOD_SPD_DATA, RSL_CMOD_CSD_NTA_43k5_29k0):</span><br><span style="color: hsl(120, 100%, 40%);">+        case RSL_CMODE(RSL_CMOD_SPD_DATA, RSL_CMOD_CSD_NTA_14k5_43k5):</span><br><span style="color: hsl(120, 100%, 40%);">+        case RSL_CMODE(RSL_CMOD_SPD_DATA, RSL_CMOD_CSD_NTA_14k5_29k0):</span><br><span style="color: hsl(120, 100%, 40%);">+        case RSL_CMODE(RSL_CMOD_SPD_DATA, RSL_CMOD_CSD_NTA_29k0_43k5):</span><br><span style="color: hsl(120, 100%, 40%);">+                /* TODO: also handle other non-transparent data rates */</span><br><span>             LOGPLCHAN(lchan, DRSL, LOGL_ERROR, "Channel Mode IE contains "</span><br><span>                       "unhandled non-transparent CSD data rate 0x%02x\n",</span><br><span>                        cm->chan_rate & 0x3f);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/23792">change 23792</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/23792"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I125cdaaf5adac0891a964c9834b99eb5a35ce262 </div>
<div style="display:none"> Gerrit-Change-Number: 23792 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>