<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/23800">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">RIM: Improve logging<br><br>Change-Id: I0adbb8ea4480912463dc1dded6c06a1b8f7ed807<br>---<br>M src/gprs_bssgp_rim.c<br>1 file changed, 19 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/00/23800/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gprs_bssgp_rim.c b/src/gprs_bssgp_rim.c</span><br><span>index 5f6f750..c1f9cec 100644</span><br><span>--- a/src/gprs_bssgp_rim.c</span><br><span>+++ b/src/gprs_bssgp_rim.c</span><br><span>@@ -87,6 +87,13 @@</span><br><span> /* Note: It is possible that the resulting PDU will not contain any system information, even if this is</span><br><span> * an unlikely case since the BTS immediately updates the system information after startup. The</span><br><span> * specification permits to send zero system information, see also: 3GPP TS 48.018 section 11.3.63.2.1 */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!bts->si1_is_set || !bts->si3_is_set || !bts->si13_is_set)</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DNACC, LOGL_INFO, "TX RAN INFO RESPONSE (NACC) %s: Some SI are missing:%s%s%s\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_cgi_ps_name(&app_cont->reprt_cell),</span><br><span style="color: hsl(120, 100%, 40%);">+ bts->si1_is_set ? "" : " SI1",</span><br><span style="color: hsl(120, 100%, 40%);">+ bts->si3_is_set ? "" : " SI3",</span><br><span style="color: hsl(120, 100%, 40%);">+ bts->si13_is_set ? "" : " SI13");</span><br><span> }</span><br><span> </span><br><span> /* Format a RAN INFORMATION PDU that contains the requested system information */</span><br><span>@@ -243,7 +250,7 @@</span><br><span> pdu->routing_info_dest.geran.cid);</span><br><span> bts = gprs_pcu_get_bts_by_cgi_ps(the_pcu, &dst_addr);</span><br><span> if (!bts) {</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPRIM(nsei, LOGL_ERROR, "Cell %s unknown to this pcu\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPRIM(nsei, LOGL_ERROR, "Destination cell %s unknown to this pcu\n",</span><br><span> osmo_cgi_ps_name(&dst_addr));</span><br><span> return bssgp_tx_status(BSSGP_CAUSE_UNKN_DST, NULL, msg);</span><br><span> }</span><br><span>@@ -251,7 +258,8 @@</span><br><span> /* Check if the incoming RIM PDU is parseable, if not we must report</span><br><span> * an error to the controlling BSS 3GPP TS 48.018, 8c.3.4 and 8c.3.4.2 */</span><br><span> if (!pdu->decoded_present) {</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPRIM(nsei, LOGL_ERROR, "Errornous RIM PDU received -- rejected.\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPRIM(nsei, LOGL_ERROR, "Erroneous RIM PDU received for cell %s -- reject.\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_cgi_ps_name(&dst_addr));</span><br><span> format_response_pdu_err(&resp_pdu, pdu);</span><br><span> return 0;</span><br><span> }</span><br><span>@@ -259,7 +267,9 @@</span><br><span> /* Check if the RIM container inside the incoming RIM PDU has the correct</span><br><span> * application ID */</span><br><span> if (!match_app_id(pdu, BSSGP_RAN_INF_APP_ID_NACC)) {</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPRIM(nsei, LOGL_ERROR, "RIM PDU with unknown/wrong application ID received -- rejected.\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPRIM(nsei, LOGL_ERROR,</span><br><span style="color: hsl(120, 100%, 40%);">+ "RIM PDU for cell %s with unknown/wrong application ID received -- reject.\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_cgi_ps_name(&dst_addr));</span><br><span> format_response_pdu_err(&resp_pdu, pdu);</span><br><span> return 0;</span><br><span> }</span><br><span>@@ -269,10 +279,14 @@</span><br><span> case BSSGP_IE_RI_REQ_RIM_CONTAINER:</span><br><span> rc = osmo_cgi_ps_cmp(&dst_addr, &pdu->decoded.req_rim_cont.u.app_cont_nacc.reprt_cell);</span><br><span> if (rc != 0) {</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPRIM(nsei, LOGL_ERROR, "reporting cell in RIM application container does not match destination cell in RIM routing info -- rejected.\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPRIM(nsei, LOGL_ERROR, "reporting cell in RIM application container %s "</span><br><span style="color: hsl(120, 100%, 40%);">+ "does not match destination cell in RIM routing info %s -- rejected.\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_cgi_ps_name(&pdu->decoded.req_rim_cont.u.app_cont_nacc.reprt_cell),</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_cgi_ps_name2(&dst_addr));</span><br><span> format_response_pdu_err(&resp_pdu, pdu);</span><br><span> } else {</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPRIM(nsei, LOGL_INFO, "Responding to RAN INFORMATION REQUEST ...\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPRIM(nsei, LOGL_INFO, "Responding to RAN INFORMATION REQUEST %s ...\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_cgi_ps_name(&pdu->decoded.req_rim_cont.u.app_cont_nacc.reprt_cell));</span><br><span> format_response_pdu(&resp_pdu, pdu, bts);</span><br><span> }</span><br><span> bssgp_tx_rim(&resp_pdu, nsei);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/23800">change 23800</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/23800"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I0adbb8ea4480912463dc1dded6c06a1b8f7ed807 </div>
<div style="display:none"> Gerrit-Change-Number: 23800 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>