<p>neels has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/23784">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">fix wrong ARFCNs in local-cell neighbor config<br><br>For neighbors configured without explicit ARFCN+BSIC ('neighbor bts N',<br>'neighbor lac-ci N M', ...), actually use the local neighbor cell's<br>ARFCN.<br><br>So far the code looked correct on first sight, but passed an unused part<br>of the struct neighbor union, always resulting in ARFCN 0.<br><br>Related: SYS#5367<br>Change-Id: Ifb54d9a91e9bca032c721f12c873c6216733e7b1<br>---<br>M src/osmo-bsc/system_information.c<br>1 file changed, 5 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/84/23784/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/system_information.c b/src/osmo-bsc/system_information.c</span><br><span>index 0dbf53c..7ec613c 100644</span><br><span>--- a/src/osmo-bsc/system_information.c</span><br><span>+++ b/src/osmo-bsc/system_information.c</span><br><span>@@ -673,12 +673,14 @@</span><br><span>                                   bitvec_set_bit_pos(bv, n->cell_id.ab.arfcn, 1);</span><br><span>                           } else {</span><br><span>                                     struct gsm_bts *neigh_bts;</span><br><span style="color: hsl(0, 100%, 40%);">-                                      if (resolve_local_neighbor(&neigh_bts, bts, n) == 0)</span><br><span style="color: hsl(0, 100%, 40%);">-                                                bitvec_set_bit_pos(bv, n->cell_id.ab.arfcn, 1);</span><br><span style="color: hsl(0, 100%, 40%);">-                                      else</span><br><span style="color: hsl(120, 100%, 40%);">+                                  if (resolve_local_neighbor(&neigh_bts, bts, n)) {</span><br><span>                                                LOGP(DHO, LOGL_ERROR,</span><br><span>                                                     "Neither local nor remote neighbor: BTS %u -> %s\n",</span><br><span>                                                    bts->nr, neighbor_to_str_c(OTC_SELECT, n));</span><br><span style="color: hsl(120, 100%, 40%);">+                                           continue;</span><br><span style="color: hsl(120, 100%, 40%);">+                                     }</span><br><span style="color: hsl(120, 100%, 40%);">+                                     if (neigh_bts->c0)</span><br><span style="color: hsl(120, 100%, 40%);">+                                         bitvec_set_bit_pos(bv, neigh_bts->c0->arfcn, 1);</span><br><span>                               }</span><br><span>                    }</span><br><span>            }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/23784">change 23784</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/23784"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ifb54d9a91e9bca032c721f12c873c6216733e7b1 </div>
<div style="display:none"> Gerrit-Change-Number: 23784 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>