<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23764">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Remove CSFB references from RR Chan Release CellSelectionIndicator IE<br><br>The IE contains a cell list for the MS to register after the channel<br>is released. The IE is used in CSFB, but not only in that case: it's<br>also used in SRVCC.<br>Hence let's remove the CSFB references since the scope is more wide.<br><br>Related: SYS#5337<br>Change-Id: Ia1eeda98fc21aa92bb2e41b5e4761c5cf6516a7e<br>---<br>M bsc/BSC_Tests.ttcn<br>M library/L3_Templates.ttcn<br>2 files changed, 9 insertions(+), 9 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/64/23764/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn</span><br><span>index e4e2d1a..6170e48 100644</span><br><span>--- a/bsc/BSC_Tests.ttcn</span><br><span>+++ b/bsc/BSC_Tests.ttcn</span><br><span>@@ -1748,7 +1748,7 @@</span><br><span> boolean expect_rll_rel_req := true,</span><br><span> boolean handle_rll_rel := true,</span><br><span> boolean is_csfb := false,</span><br><span style="color: hsl(0, 100%, 40%);">- template CellSelIndValue csfb_expect_cells := omit,</span><br><span style="color: hsl(120, 100%, 40%);">+ template CellSelIndValue expect_cells := omit,</span><br><span> template RR_Cause expect_rr_cause := ?</span><br><span> ) runs on test_CT {</span><br><span> </span><br><span>@@ -1767,7 +1767,7 @@</span><br><span> got_deact_sacch := true;</span><br><span> repeat;</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">- [is_csfb] IPA_RSL[bts_nr].receive(tr_ASP_RSL_UD(tr_RSL_DATA_REQ(rsl_chan_nr, ?, decmatch tr_RRM_RR_RELEASE_CSFB))) -> value ud {</span><br><span style="color: hsl(120, 100%, 40%);">+ [is_csfb] IPA_RSL[bts_nr].receive(tr_ASP_RSL_UD(tr_RSL_DATA_REQ(rsl_chan_nr, ?, decmatch tr_RRM_RR_RELEASE_CellSelectInd))) -> value ud {</span><br><span> got_rr_chan_rel := true;</span><br><span> </span><br><span> if (f_rsl_find_ie(ud.rsl, RSL_IE_L3_INFO, l3_ie) == false) {</span><br><span>@@ -1776,16 +1776,16 @@</span><br><span> }</span><br><span> l3 := dec_PDU_ML3_NW_MS(l3_ie.l3_info.payload);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- if (not istemplatekind(csfb_expect_cells, "omit")) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (not istemplatekind(expect_cells, "omit")) {</span><br><span> var CellSelIndValue cells := dec_CellSelIndValue(</span><br><span> l3.msgs.rrm.channelRelease.cellSelectionIndicator.cellSelectionIndicatorValue);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- log("GOT RR CHANNEL RELEASE CSFB CELLS: ", cells);</span><br><span style="color: hsl(0, 100%, 40%);">- if (match(cells, csfb_expect_cells)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ log("GOT RR CHANNEL RELEASE WITH CELLS: ", cells);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (match(cells, expect_cells)) {</span><br><span> setverdict(pass);</span><br><span> } else {</span><br><span style="color: hsl(0, 100%, 40%);">- log("EXPECTED CSFB CELLS: ", csfb_expect_cells);</span><br><span style="color: hsl(0, 100%, 40%);">- setverdict(fail, "Received CSFB cells list on RR Channel Release does not match expectations");</span><br><span style="color: hsl(120, 100%, 40%);">+ log("EXPECTED CELLS: ", expect_cells);</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail, "Received cells list on RR Channel Release does not match expectations");</span><br><span> }</span><br><span> }</span><br><span> </span><br><span>@@ -2323,7 +2323,7 @@</span><br><span> }</span><br><span> </span><br><span> f_expect_chan_rel(0, dt.rsl_chan_nr, expect_rll_rel_req := false, is_csfb := true,</span><br><span style="color: hsl(0, 100%, 40%);">- csfb_expect_cells := expect_cells);</span><br><span style="color: hsl(120, 100%, 40%);">+ expect_cells := expect_cells);</span><br><span> }</span><br><span> </span><br><span> for (var integer i := 1; i < total_earfcns; i := i + 1) {</span><br><span>diff --git a/library/L3_Templates.ttcn b/library/L3_Templates.ttcn</span><br><span>index 5bd87eb..5d688de 100644</span><br><span>--- a/library/L3_Templates.ttcn</span><br><span>+++ b/library/L3_Templates.ttcn</span><br><span>@@ -910,7 +910,7 @@</span><br><span> }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-template PDU_ML3_NW_MS tr_RRM_RR_RELEASE_CSFB(template OCT1 cause := ?) modifies tr_RRM_RR_RELEASE := {</span><br><span style="color: hsl(120, 100%, 40%);">+template PDU_ML3_NW_MS tr_RRM_RR_RELEASE_CellSelectInd(template OCT1 cause := ?) modifies tr_RRM_RR_RELEASE := {</span><br><span> msgs := {</span><br><span> rrm := {</span><br><span> channelRelease := {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23764">change 23764</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23764"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ia1eeda98fc21aa92bb2e41b5e4761c5cf6516a7e </div>
<div style="display:none"> Gerrit-Change-Number: 23764 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>