<p style="white-space: pre-wrap; word-wrap: break-word;">CR-1 due to fd leak.</p><p>Patch set 7:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p><a href="https://gerrit.osmocom.org/c/libosmo-abis/+/21118">View Change</a></p><p>5 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmo-abis/+/21118/7/include/osmocom/abis/e1_input.h">File include/osmocom/abis/e1_input.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmo-abis/+/21118/7/include/osmocom/abis/e1_input.h@324">Patch Set #7, Line 324:</a> <code style="font-family:monospace,monospace">e1_set_pcap_fd</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Should we deprecate the old symbol now?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmo-abis/+/21118/7/src/e1_input.c">File src/e1_input.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmo-abis/+/21118/7/src/e1_input.c@144">Patch Set #7, Line 144:</a> <code style="font-family:monospace,monospace">pcap_hdr</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">It can also be 'static' I think, so it will definitely end up in RODATA.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmo-abis/+/21118/7/src/e1_input_vty.c">File src/e1_input_vty.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmo-abis/+/21118/7/src/e1_input_vty.c@273">Patch Set #7, Line 273:</a> <code style="font-family:monospace,monospace">            return CMD_WARNING;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I think you need to close(fd) before you return from here.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmo-abis/+/21118/7/src/e1_input_vty.c@275">Patch Set #7, Line 275:</a> <code style="font-family:monospace,monospace">      if (line->pcap_file) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">osmo_talloc_replace_string() will free() it automatically, remove this block.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmo-abis/+/21118/7/src/e1_input_vty.c@295">Patch Set #7, Line 295:</a> <code style="font-family:monospace,monospace">void</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This pointer cast is not needed because it's not 'const'.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmo-abis/+/21118">change 21118</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmo-abis/+/21118"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmo-abis </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I316c3d6a839e84c2f52a148c6b8dd6f5933cf4bf </div>
<div style="display:none"> Gerrit-Change-Number: 21118 </div>
<div style="display:none"> Gerrit-PatchSet: 7 </div>
<div style="display:none"> Gerrit-Owner: keith <keith@rhizomatica.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: keith <keith@rhizomatica.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 13 Apr 2021 19:30:04 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>