<p>neels has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/23727">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">drop unused gsm_bts_trx->description<br><br>Change-Id: I3c0778322b8c630b0eb9d9cd3ac3cc71386c9c12<br>---<br>M include/osmocom/bsc/bts_trx.h<br>M src/osmo-bsc/bsc_vty.c<br>M src/osmo-bsc/osmo_bsc_main.c<br>3 files changed, 0 insertions(+), 11 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/27/23727/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/bsc/bts_trx.h b/include/osmocom/bsc/bts_trx.h</span><br><span>index 7c8ef52..e42e1e4 100644</span><br><span>--- a/include/osmocom/bsc/bts_trx.h</span><br><span>+++ b/include/osmocom/bsc/bts_trx.h</span><br><span>@@ -31,8 +31,6 @@</span><br><span>     struct gsm_bts *bts;</span><br><span>         /* number of this TRX in the BTS */</span><br><span>  uint8_t nr;</span><br><span style="color: hsl(0, 100%, 40%);">-     /* human readable name / description */</span><br><span style="color: hsl(0, 100%, 40%);">- char *description;</span><br><span>   /* how do we talk RSL with this TRX? */</span><br><span>      struct gsm_e1_subslot rsl_e1_link;</span><br><span>   uint8_t rsl_tei;</span><br><span>diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c</span><br><span>index 6a6411f..8ed9f0c 100644</span><br><span>--- a/src/osmo-bsc/bsc_vty.c</span><br><span>+++ b/src/osmo-bsc/bsc_vty.c</span><br><span>@@ -726,9 +726,6 @@</span><br><span>  int i;</span><br><span> </span><br><span>   vty_out(vty, "  trx %u%s", trx->nr, VTY_NEWLINE);</span><br><span style="color: hsl(0, 100%, 40%);">-  if (trx->description)</span><br><span style="color: hsl(0, 100%, 40%);">-                vty_out(vty, "   description %s%s", trx->description,</span><br><span style="color: hsl(0, 100%, 40%);">-                      VTY_NEWLINE);</span><br><span>        vty_out(vty, "   rf_locked %u%s",</span><br><span>          trx->mo.force_rf_lock ? 1 : 0,</span><br><span>            VTY_NEWLINE);</span><br><span>@@ -983,8 +980,6 @@</span><br><span> </span><br><span>      vty_out(vty, " bts %u%s", bts->nr, VTY_NEWLINE);</span><br><span>        vty_out(vty, "  type %s%s", btstype2str(bts->type), VTY_NEWLINE);</span><br><span style="color: hsl(0, 100%, 40%);">-  if (bts->description)</span><br><span style="color: hsl(0, 100%, 40%);">-                vty_out(vty, "  description %s%s", bts->description, VTY_NEWLINE);</span><br><span>      vty_out(vty, "  band %s%s", gsm_band_name(bts->band), VTY_NEWLINE);</span><br><span>     vty_out(vty, "  cell_identity %u%s", bts->cell_identity, VTY_NEWLINE);</span><br><span>  vty_out(vty, "  location_area_code %u%s", bts->location_area_code,</span><br><span>@@ -1335,8 +1330,6 @@</span><br><span> </span><br><span>  vty_out(vty, "TRX %u of BTS %u is on ARFCN %u%s",</span><br><span>          trx->nr, trx->bts->nr, trx->arfcn, VTY_NEWLINE);</span><br><span style="color: hsl(0, 100%, 40%);">-    vty_out(vty, "Description: %s%s",</span><br><span style="color: hsl(0, 100%, 40%);">-             trx->description ? trx->description : "(null)", VTY_NEWLINE);</span><br><span>        vty_out(vty, "  RF Nominal Power: %d dBm, reduced by %u dB, "</span><br><span>              "resulting BS power: %d dBm%s",</span><br><span>            trx->nominal_power, trx->max_power_red,</span><br><span>@@ -5308,7 +5301,6 @@</span><br><span>                return CMD_WARNING;</span><br><span> </span><br><span>      vty->index = trx;</span><br><span style="color: hsl(0, 100%, 40%);">-    vty->index_sub = &trx->description;</span><br><span>        vty->node = TRX_NODE;</span><br><span> </span><br><span>         return CMD_SUCCESS;</span><br><span>diff --git a/src/osmo-bsc/osmo_bsc_main.c b/src/osmo-bsc/osmo_bsc_main.c</span><br><span>index 6c7c275..595fcad 100644</span><br><span>--- a/src/osmo-bsc/osmo_bsc_main.c</span><br><span>+++ b/src/osmo-bsc/osmo_bsc_main.c</span><br><span>@@ -611,7 +611,6 @@</span><br><span>                       /* set vty->index correctly ! */</span><br><span>                  struct gsm_bts_trx_ts *ts = vty->index;</span><br><span>                   vty->index = ts->trx;</span><br><span style="color: hsl(0, 100%, 40%);">-                     vty->index_sub = &ts->trx->description;</span><br><span>                 }</span><br><span>            break;</span><br><span>       case OML_NODE:</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/23727">change 23727</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/23727"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I3c0778322b8c630b0eb9d9cd3ac3cc71386c9c12 </div>
<div style="display:none"> Gerrit-Change-Number: 23727 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>