<p>fixeria <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/23627">View Change</a></p><div style="white-space:pre-wrap">Approvals:
laforge: Looks good to me, but someone else must approve
dexter: Looks good to me, but someone else must approve
keith: Looks good to me, but someone else must approve
pespin: Looks good to me, approved
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Replace all references to 'sysmobts' with 'osmo-bts'<br><br>sysmoBTS is a BTS model sold by Sysmocom, which runs osmo-bts.<br>The later may also work with some other back-ends, including<br>the genaral purpose SDR hardware. Therefore, it's more<br>logical to call it 'osmo-bts'.<br><br>Change-Id: I93ab4dbf483e0786c35685b75ee4ea83bd591f7b<br>---<br>M include/osmocom/bsc/bss.h<br>M include/osmocom/bsc/bts.h<br>M src/osmo-bsc/Makefile.am<br>M src/osmo-bsc/bsc_ctrl_commands.c<br>M src/osmo-bsc/bsc_vty.c<br>M src/osmo-bsc/bts_init.c<br>A src/osmo-bsc/bts_osmobts.c<br>D src/osmo-bsc/bts_sysmobts.c<br>M src/osmo-bsc/lchan_fsm.c<br>9 files changed, 77 insertions(+), 77 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/bsc/bss.h b/include/osmocom/bsc/bss.h</span><br><span>index b8945db..199f981 100644</span><br><span>--- a/include/osmocom/bsc/bss.h</span><br><span>+++ b/include/osmocom/bsc/bss.h</span><br><span>@@ -16,5 +16,5 @@</span><br><span> extern int bts_model_rbs2k_init(void);</span><br><span> extern int bts_model_nanobts_init(void);</span><br><span> extern int bts_model_nokia_site_init(void);</span><br><span style="color: hsl(0, 100%, 40%);">-extern int bts_model_sysmobts_init(void);</span><br><span style="color: hsl(120, 100%, 40%);">+extern int bts_model_osmobts_init(void);</span><br><span> #endif</span><br><span>diff --git a/include/osmocom/bsc/bts.h b/include/osmocom/bsc/bts.h</span><br><span>index d883570..bcc215d 100644</span><br><span>--- a/include/osmocom/bsc/bts.h</span><br><span>+++ b/include/osmocom/bsc/bts.h</span><br><span>@@ -554,7 +554,7 @@</span><br><span> return 0;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static inline int is_sysmobts_v2(const struct gsm_bts *bts)</span><br><span style="color: hsl(120, 100%, 40%);">+static inline int is_osmobts(const struct gsm_bts *bts)</span><br><span> {</span><br><span> switch (bts->type) {</span><br><span> case GSM_BTS_TYPE_OSMOBTS:</span><br><span>diff --git a/src/osmo-bsc/Makefile.am b/src/osmo-bsc/Makefile.am</span><br><span>index 49b7890..ca39825 100644</span><br><span>--- a/src/osmo-bsc/Makefile.am</span><br><span>+++ b/src/osmo-bsc/Makefile.am</span><br><span>@@ -53,7 +53,7 @@</span><br><span> bts_nokia_site.c \</span><br><span> bts_siemens_bs11.c \</span><br><span> bts_sm.c \</span><br><span style="color: hsl(0, 100%, 40%);">- bts_sysmobts.c \</span><br><span style="color: hsl(120, 100%, 40%);">+ bts_osmobts.c \</span><br><span> bts_unknown.c \</span><br><span> chan_alloc.c \</span><br><span> codec_pref.c \</span><br><span>diff --git a/src/osmo-bsc/bsc_ctrl_commands.c b/src/osmo-bsc/bsc_ctrl_commands.c</span><br><span>index 9383167..96aeba2 100644</span><br><span>--- a/src/osmo-bsc/bsc_ctrl_commands.c</span><br><span>+++ b/src/osmo-bsc/bsc_ctrl_commands.c</span><br><span>@@ -102,7 +102,7 @@</span><br><span> * so let's us just reboot it. For the sysmoBTS we can just</span><br><span> * restart the process as all state is gone.</span><br><span> */</span><br><span style="color: hsl(0, 100%, 40%);">- if (!is_sysmobts_v2(bts) && strcmp(cmd->value, "restart") == 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!is_osmobts(bts) && strcmp(cmd->value, "restart") == 0) {</span><br><span> struct gsm_bts_trx *trx;</span><br><span> llist_for_each_entry_reverse(trx, &bts->trx_list, list)</span><br><span> abis_nm_ipaccess_restart(trx);</span><br><span>diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c</span><br><span>index 1a59fcb..0955ffe 100644</span><br><span>--- a/src/osmo-bsc/bsc_vty.c</span><br><span>+++ b/src/osmo-bsc/bsc_vty.c</span><br><span>@@ -3795,7 +3795,7 @@</span><br><span> {</span><br><span> struct gsm_bts *bts = vty->index;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- if (!is_ipaccess_bts(bts) || is_sysmobts_v2(bts)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!is_ipaccess_bts(bts) || is_osmobts(bts)) {</span><br><span> vty_out(vty, "%% This command is only intended for ipaccess nanoBTS. See OS#3707.%s",</span><br><span> VTY_NEWLINE);</span><br><span> return CMD_WARNING;</span><br><span>@@ -5801,7 +5801,7 @@</span><br><span> return CMD_WARNING;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- if (!is_ipaccess_bts(bts) || is_sysmobts_v2(bts)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!is_ipaccess_bts(bts) || is_osmobts(bts)) {</span><br><span> vty_out(vty, "%% This command only works for ipaccess nanoBTS.%s",</span><br><span> VTY_NEWLINE);</span><br><span> return CMD_WARNING;</span><br><span>diff --git a/src/osmo-bsc/bts_init.c b/src/osmo-bsc/bts_init.c</span><br><span>index 18f1ed4..0e3debc 100644</span><br><span>--- a/src/osmo-bsc/bts_init.c</span><br><span>+++ b/src/osmo-bsc/bts_init.c</span><br><span>@@ -24,7 +24,7 @@</span><br><span> bts_model_rbs2k_init();</span><br><span> bts_model_nanobts_init();</span><br><span> bts_model_nokia_site_init();</span><br><span style="color: hsl(0, 100%, 40%);">- bts_model_sysmobts_init();</span><br><span style="color: hsl(120, 100%, 40%);">+ bts_model_osmobts_init();</span><br><span> /* Your new BTS here. */</span><br><span> return 0;</span><br><span> }</span><br><span>diff --git a/src/osmo-bsc/bts_osmobts.c b/src/osmo-bsc/bts_osmobts.c</span><br><span>new file mode 100644</span><br><span>index 0000000..1814ada</span><br><span>--- /dev/null</span><br><span>+++ b/src/osmo-bsc/bts_osmobts.c</span><br><span>@@ -0,0 +1,69 @@</span><br><span style="color: hsl(120, 100%, 40%);">+/* Osmocom OsmoBTS specific code */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/* (C) 2010-2012 by Harald Welte <laforge@gnumonks.org></span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * All Rights Reserved</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * This program is free software; you can redistribute it and/or modify</span><br><span style="color: hsl(120, 100%, 40%);">+ * it under the terms of the GNU Affero General Public License as published by</span><br><span style="color: hsl(120, 100%, 40%);">+ * the Free Software Foundation; either version 3 of the License, or</span><br><span style="color: hsl(120, 100%, 40%);">+ * (at your option) any later version.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * This program is distributed in the hope that it will be useful,</span><br><span style="color: hsl(120, 100%, 40%);">+ * but WITHOUT ANY WARRANTY; without even the implied warranty of</span><br><span style="color: hsl(120, 100%, 40%);">+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the</span><br><span style="color: hsl(120, 100%, 40%);">+ * GNU Affero General Public License for more details.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * You should have received a copy of the GNU Affero General Public License</span><br><span style="color: hsl(120, 100%, 40%);">+ * along with this program. If not, see <http://www.gnu.org/licenses/>.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#include <arpa/inet.h></span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/gsm/tlv.h></span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/bsc/gsm_data.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/bsc/signal.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/bsc/abis_nm.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/bsc/bts.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/abis/e1_input.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/gsm/tlv.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/core/msgb.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/core/talloc.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/bsc/gsm_data.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/bsc/abis_nm.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/bsc/abis_rsl.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/bsc/debug.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/abis/subchan_demux.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/abis/ipaccess.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/core/logging.h></span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+extern struct gsm_bts_model bts_model_nanobts;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static struct gsm_bts_model model_osmobts;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+int bts_model_osmobts_init(void)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ model_osmobts = bts_model_nanobts;</span><br><span style="color: hsl(120, 100%, 40%);">+ model_osmobts.name = "osmo-bts";</span><br><span style="color: hsl(120, 100%, 40%);">+ model_osmobts.type = GSM_BTS_TYPE_OSMOBTS;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Unlike nanoBTS, osmo-bts does support SI2bis and SI2ter fine */</span><br><span style="color: hsl(120, 100%, 40%);">+ model_osmobts.force_combined_si = false;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ model_osmobts.features.data = &model_osmobts._features_data[0];</span><br><span style="color: hsl(120, 100%, 40%);">+ model_osmobts.features.data_len =</span><br><span style="color: hsl(120, 100%, 40%);">+ sizeof(model_osmobts._features_data);</span><br><span style="color: hsl(120, 100%, 40%);">+ memset(model_osmobts.features.data, 0, model_osmobts.features.data_len);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_bts_set_feature(&model_osmobts.features, BTS_FEAT_GPRS);</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_bts_set_feature(&model_osmobts.features, BTS_FEAT_EGPRS);</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_bts_set_feature(&model_osmobts.features, BTS_FEAT_PAGING_COORDINATION);</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_bts_set_feature(&model_osmobts.features, BTS_FEAT_IPV6_NSVC);</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_bts_set_feature(&model_osmobts.features, BTS_FEAT_CCN);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ model_osmobts.nm_att_tlvdef.def[NM_ATT_OSMO_NS_LINK_CFG].type = TLV_TYPE_TL16V;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ return gsm_bts_model_register(&model_osmobts);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span>diff --git a/src/osmo-bsc/bts_sysmobts.c b/src/osmo-bsc/bts_sysmobts.c</span><br><span>deleted file mode 100644</span><br><span>index f24c615..0000000</span><br><span>--- a/src/osmo-bsc/bts_sysmobts.c</span><br><span>+++ /dev/null</span><br><span>@@ -1,69 +0,0 @@</span><br><span style="color: hsl(0, 100%, 40%);">-/* sysmocom sysmoBTS specific code */</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-/* (C) 2010-2012 by Harald Welte <laforge@gnumonks.org></span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * All Rights Reserved</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * This program is free software; you can redistribute it and/or modify</span><br><span style="color: hsl(0, 100%, 40%);">- * it under the terms of the GNU Affero General Public License as published by</span><br><span style="color: hsl(0, 100%, 40%);">- * the Free Software Foundation; either version 3 of the License, or</span><br><span style="color: hsl(0, 100%, 40%);">- * (at your option) any later version.</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * This program is distributed in the hope that it will be useful,</span><br><span style="color: hsl(0, 100%, 40%);">- * but WITHOUT ANY WARRANTY; without even the implied warranty of</span><br><span style="color: hsl(0, 100%, 40%);">- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the</span><br><span style="color: hsl(0, 100%, 40%);">- * GNU Affero General Public License for more details.</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * You should have received a copy of the GNU Affero General Public License</span><br><span style="color: hsl(0, 100%, 40%);">- * along with this program. If not, see <http://www.gnu.org/licenses/>.</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- */</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-#include <arpa/inet.h></span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/gsm/tlv.h></span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/bsc/gsm_data.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/bsc/signal.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/bsc/abis_nm.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/bsc/bts.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/abis/e1_input.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/gsm/tlv.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/core/msgb.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/core/talloc.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/bsc/gsm_data.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/bsc/abis_nm.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/bsc/abis_rsl.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/bsc/debug.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/abis/subchan_demux.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/abis/ipaccess.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/core/logging.h></span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-extern struct gsm_bts_model bts_model_nanobts;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-static struct gsm_bts_model model_sysmobts;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-int bts_model_sysmobts_init(void)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">- model_sysmobts = bts_model_nanobts;</span><br><span style="color: hsl(0, 100%, 40%);">- model_sysmobts.name = "sysmobts";</span><br><span style="color: hsl(0, 100%, 40%);">- model_sysmobts.type = GSM_BTS_TYPE_OSMOBTS;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- /* Unlike nanoBTS, sysmoBTS supports SI2bis and SI2ter fine */</span><br><span style="color: hsl(0, 100%, 40%);">- model_sysmobts.force_combined_si = false;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- model_sysmobts.features.data = &model_sysmobts._features_data[0];</span><br><span style="color: hsl(0, 100%, 40%);">- model_sysmobts.features.data_len =</span><br><span style="color: hsl(0, 100%, 40%);">- sizeof(model_sysmobts._features_data);</span><br><span style="color: hsl(0, 100%, 40%);">- memset(model_sysmobts.features.data, 0, model_sysmobts.features.data_len);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- osmo_bts_set_feature(&model_sysmobts.features, BTS_FEAT_GPRS);</span><br><span style="color: hsl(0, 100%, 40%);">- osmo_bts_set_feature(&model_sysmobts.features, BTS_FEAT_EGPRS);</span><br><span style="color: hsl(0, 100%, 40%);">- osmo_bts_set_feature(&model_sysmobts.features, BTS_FEAT_PAGING_COORDINATION);</span><br><span style="color: hsl(0, 100%, 40%);">- osmo_bts_set_feature(&model_sysmobts.features, BTS_FEAT_IPV6_NSVC);</span><br><span style="color: hsl(0, 100%, 40%);">- osmo_bts_set_feature(&model_sysmobts.features, BTS_FEAT_CCN);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- model_sysmobts.nm_att_tlvdef.def[NM_ATT_OSMO_NS_LINK_CFG].type = TLV_TYPE_TL16V;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- return gsm_bts_model_register(&model_sysmobts);</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span>diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c</span><br><span>index ffcf2b1..0e2eb82 100644</span><br><span>--- a/src/osmo-bsc/lchan_fsm.c</span><br><span>+++ b/src/osmo-bsc/lchan_fsm.c</span><br><span>@@ -1304,7 +1304,7 @@</span><br><span> lchan->release.rr_cause = bsc_gsm48_rr_cause_from_rsl_cause(lchan->release.rsl_error_cause);</span><br><span> lchan_fsm_state_chg(LCHAN_ST_WAIT_AFTER_ERROR);</span><br><span> /* TODO: we used to do this only for sysmobts:</span><br><span style="color: hsl(0, 100%, 40%);">- int do_free = is_sysmobts_v2(ts->trx->bts);</span><br><span style="color: hsl(120, 100%, 40%);">+ int do_free = is_osmobts(ts->trx->bts);</span><br><span> LOGP(DRSL, LOGL_NOTICE,</span><br><span> "%s CHAN REL ACK for broken channel. %s.\n",</span><br><span> gsm_lchan_name(lchan),</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/23627">change 23627</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/23627"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I93ab4dbf483e0786c35685b75ee4ea83bd591f7b </div>
<div style="display:none"> Gerrit-Change-Number: 23627 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: keith <keith@rhizomatica.org> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>