<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/23682">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved
  fixeria: Looks good to me, but someone else must approve

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">deprecate osmo_bts_feature_name(), add osmo_bts_features_desc()<br><br>The function osmo_bts_feature_name() is ill-named for two reasons:<br>- it returns descriptive text instead of just a string representation of<br>  the name.<br>- The enum is named "osmo_bts_features", so the function name lacks the<br>  "s" for "features".<br><br>Rationale: An upcoming patch adds a function to return just the name,<br>properly called osmo_bts_features_name(), so deprecate the weirdly named<br>one first.<br><br>Change-Id: I9dfdb5e81037b6000effbd340af4e5db0dcfd69c<br>---<br>M include/osmocom/gsm/bts_features.h<br>1 file changed, 5 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/gsm/bts_features.h b/include/osmocom/gsm/bts_features.h</span><br><span>index ac2c760..b174d3f 100644</span><br><span>--- a/include/osmocom/gsm/bts_features.h</span><br><span>+++ b/include/osmocom/gsm/bts_features.h</span><br><span>@@ -34,7 +34,11 @@</span><br><span> </span><br><span> extern const struct value_string osmo_bts_features_descs[];</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-const char *osmo_bts_feature_name(enum osmo_bts_features feature);</span><br><span style="color: hsl(120, 100%, 40%);">+static inline const char *osmo_bts_features_desc(enum osmo_bts_features val)</span><br><span style="color: hsl(120, 100%, 40%);">+{ return get_value_string(osmo_bts_features_descs, val); }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+const char *osmo_bts_feature_name(enum osmo_bts_features feature)</span><br><span style="color: hsl(120, 100%, 40%);">+       OSMO_DEPRECATED("Use osmo_bts_features_desc() instead");</span><br><span> </span><br><span> static inline int osmo_bts_set_feature(struct bitvec *features, enum osmo_bts_features feature)</span><br><span> {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/23682">change 23682</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/23682"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I9dfdb5e81037b6000effbd340af4e5db0dcfd69c </div>
<div style="display:none"> Gerrit-Change-Number: 23682 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>