<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmocom-bb/+/23676">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">trx_toolkit/data_msg.py: add type hints to static methods<br><br>Change-Id: I06fd8bc7418700de40467fd63a08da2bc2abcea2<br>---<br>M src/target/trx_toolkit/data_msg.py<br>1 file changed, 5 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/76/23676/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/target/trx_toolkit/data_msg.py b/src/target/trx_toolkit/data_msg.py</span><br><span>index 742dce4..f5d570f 100644</span><br><span>--- a/src/target/trx_toolkit/data_msg.py</span><br><span>+++ b/src/target/trx_toolkit/data_msg.py</span><br><span>@@ -25,6 +25,7 @@</span><br><span> import struct</span><br><span> import abc</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+from typing import List</span><br><span> from enum import Enum</span><br><span> from gsm_shared import *</span><br><span> </span><br><span>@@ -187,22 +188,22 @@</span><br><span>           return result</span><br><span> </span><br><span>    @staticmethod</span><br><span style="color: hsl(0, 100%, 40%);">-   def usbit2sbit(bits):</span><br><span style="color: hsl(120, 100%, 40%);">+ def usbit2sbit(bits: List[int]) -> List[int]:</span><br><span>             ''' Convert unsigned soft-bits {254..0} to soft-bits {-127..127}. '''</span><br><span>                return [-127 if (b == 0xff) else 127 - b for b in bits]</span><br><span> </span><br><span>  @staticmethod</span><br><span style="color: hsl(0, 100%, 40%);">-   def sbit2usbit(bits):</span><br><span style="color: hsl(120, 100%, 40%);">+ def sbit2usbit(bits: List[int]) -> List[int]:</span><br><span>             ''' Convert soft-bits {-127..127} to unsigned soft-bits {254..0}. '''</span><br><span>                return [127 - b for b in bits]</span><br><span> </span><br><span>   @staticmethod</span><br><span style="color: hsl(0, 100%, 40%);">-   def sbit2ubit(bits):</span><br><span style="color: hsl(120, 100%, 40%);">+  def sbit2ubit(bits: List[int]) -> List[int]:</span><br><span>              ''' Convert soft-bits {-127..127} to bits {1..0}. '''</span><br><span>                return [int(b < 0) for b in bits]</span><br><span> </span><br><span>     @staticmethod</span><br><span style="color: hsl(0, 100%, 40%);">-   def ubit2sbit(bits):</span><br><span style="color: hsl(120, 100%, 40%);">+  def ubit2sbit(bits: List[int]) -> List[int]:</span><br><span>              ''' Convert bits {1..0} to soft-bits {-127..127}. '''</span><br><span>                return [-127 if b else 127 for b in bits]</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmocom-bb/+/23676">change 23676</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmocom-bb/+/23676"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmocom-bb </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I06fd8bc7418700de40467fd63a08da2bc2abcea2 </div>
<div style="display:none"> Gerrit-Change-Number: 23676 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>