<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/23629">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">vty/logging: ensure consistent '%' prefix for warnings<br><br>Change-Id: I2b2bab61e46668c3b4b0ccad88d02b6d00a83544<br>---<br>M src/vty/logging_vty.c<br>M tests/logging/logging_vty_test.vty<br>2 files changed, 7 insertions(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/vty/logging_vty.c b/src/vty/logging_vty.c</span><br><span>index cc250c0..5f31b39 100644</span><br><span>--- a/src/vty/logging_vty.c</span><br><span>+++ b/src/vty/logging_vty.c</span><br><span>@@ -131,7 +131,7 @@</span><br><span> </span><br><span>     conn = (struct telnet_connection *) vty->priv;</span><br><span>    if (conn->dbg) {</span><br><span style="color: hsl(0, 100%, 40%);">-             vty_out(vty, "Logging already enabled.%s", VTY_NEWLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+            vty_out(vty, "%% Logging already enabled.%s", VTY_NEWLINE);</span><br><span>                return CMD_WARNING;</span><br><span>  }</span><br><span> </span><br><span>@@ -158,7 +158,7 @@</span><br><span> </span><br><span>      conn = (struct telnet_connection *) vty->priv;</span><br><span>    if (!conn->dbg)</span><br><span style="color: hsl(0, 100%, 40%);">-              vty_out(vty, "Logging was not enabled.%s", VTY_NEWLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+            vty_out(vty, "%% Logging was not enabled.%s", VTY_NEWLINE);</span><br><span> </span><br><span>    return conn->dbg;</span><br><span> }</span><br><span>@@ -372,12 +372,12 @@</span><br><span>    int level = log_parse_level(argv[1]);</span><br><span> </span><br><span>    if (level < 0) {</span><br><span style="color: hsl(0, 100%, 40%);">-             vty_out(vty, "Invalid level '%s'%s", argv[1], VTY_NEWLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+         vty_out(vty, "%% Invalid level '%s'%s", argv[1], VTY_NEWLINE);</span><br><span>             return CMD_WARNING;</span><br><span>  }</span><br><span> </span><br><span>        if (category < 0) {</span><br><span style="color: hsl(0, 100%, 40%);">-          vty_out(vty, "Invalid category '%s'%s", argv[0], VTY_NEWLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+              vty_out(vty, "%% Invalid category '%s'%s", argv[0], VTY_NEWLINE);</span><br><span>          return CMD_WARNING;</span><br><span>  }</span><br><span> </span><br><span>@@ -595,7 +595,7 @@</span><br><span>  char **dptr = vty->index_sub;</span><br><span> </span><br><span>         if (!dptr) {</span><br><span style="color: hsl(0, 100%, 40%);">-            vty_out(vty, "vty->index_sub == NULL%s", VTY_NEWLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+           vty_out(vty, "%% vty->index_sub == NULL%s", VTY_NEWLINE);</span><br><span>               return CMD_WARNING;</span><br><span>  }</span><br><span> </span><br><span>@@ -616,7 +616,7 @@</span><br><span>  char **dptr = vty->index_sub;</span><br><span> </span><br><span>         if (!dptr) {</span><br><span style="color: hsl(0, 100%, 40%);">-            vty_out(vty, "vty->index_sub == NULL%s", VTY_NEWLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+           vty_out(vty, "%% vty->index_sub == NULL%s", VTY_NEWLINE);</span><br><span>               return CMD_WARNING;</span><br><span>  }</span><br><span> </span><br><span>diff --git a/tests/logging/logging_vty_test.vty b/tests/logging/logging_vty_test.vty</span><br><span>index 91c2a48..30e73ab 100644</span><br><span>--- a/tests/logging/logging_vty_test.vty</span><br><span>+++ b/tests/logging/logging_vty_test.vty</span><br><span>@@ -29,7 +29,7 @@</span><br><span> logging_vty_test(config)# exit</span><br><span> </span><br><span> logging_vty_test# logging level force-all notice</span><br><span style="color: hsl(0, 100%, 40%);">-Logging was not enabled.</span><br><span style="color: hsl(120, 100%, 40%);">+% Logging was not enabled.</span><br><span> </span><br><span> logging_vty_test# logging enable</span><br><span> logging_vty_test# logging filter all 1</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/23629">change 23629</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/23629"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I2b2bab61e46668c3b4b0ccad88d02b6d00a83544 </div>
<div style="display:none"> Gerrit-Change-Number: 23629 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>