<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/23672">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">l1sap: check BTS_FEAT_MULTI_TSC in l1sap_chan_act()<br><br>Instead of blindly assuming what the PHY does support, and what<br>it does not, let's check the related feature vector.<br><br>Change-Id: I699cdddbfab111855998853548d9cfe956f7c60c<br>Related: SYS#4895, OS#4941<br>---<br>M src/common/l1sap.c<br>1 file changed, 5 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/72/23672/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/l1sap.c b/src/common/l1sap.c</span><br><span>index 3ebe8e1..b8bfa31 100644</span><br><span>--- a/src/common/l1sap.c</span><br><span>+++ b/src/common/l1sap.c</span><br><span>@@ -1973,11 +1973,11 @@</span><br><span>           cd = (struct gsm48_chan_desc *)</span><br><span>              TLVP_VAL(tp, GSM48_IE_CHANDESC_2);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-          /* our L1 only supports one global TSC for all channels</span><br><span style="color: hsl(0, 100%, 40%);">-          * one one TRX, so we need to make sure not to activate</span><br><span style="color: hsl(0, 100%, 40%);">-          * channels with a different TSC!! */</span><br><span style="color: hsl(0, 100%, 40%);">-           if (cd->h0.tsc != (trx->bts->bsic & 7)) {</span><br><span style="color: hsl(0, 100%, 40%);">-                  LOGPLCHAN(lchan, DL1C, LOGL_ERROR, "lchan TSC %u != BSIC-TSC %u\n",</span><br><span style="color: hsl(120, 100%, 40%);">+         /* The PHY may not support using different TSCs */</span><br><span style="color: hsl(120, 100%, 40%);">+            if (!osmo_bts_has_feature(trx->bts->features, BTS_FEAT_MULTI_TSC)</span><br><span style="color: hsl(120, 100%, 40%);">+                   && cd->h0.tsc != (trx->bts->bsic & 7)) {</span><br><span style="color: hsl(120, 100%, 40%);">+                     LOGPLCHAN(lchan, DL1C, LOGL_ERROR, "This PHY does not support "</span><br><span style="color: hsl(120, 100%, 40%);">+                               "lchan TSC %u != BSIC-TSC %u, sending NACK\n",</span><br><span>                             cd->h0.tsc, trx->bts->bsic & 7);</span><br><span>                      return -RSL_ERR_SERV_OPT_UNIMPL;</span><br><span>             }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/23672">change 23672</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/23672"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I699cdddbfab111855998853548d9cfe956f7c60c </div>
<div style="display:none"> Gerrit-Change-Number: 23672 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>