<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/23510">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  daniel: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">stats: log error when missing stats values (v2)<br><br>Related: SYS#4877<br>Change-Id: I5140d967c2f1d36dadf93b03e52b9bbd42e2a3a6<br>---<br>M src/stat_item.c<br>M tests/stats/stats_test.c<br>M tests/stats/stats_test.err<br>3 files changed, 10 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/stat_item.c b/src/stat_item.c</span><br><span>index 2d96444..40374a7 100644</span><br><span>--- a/src/stat_item.c</span><br><span>+++ b/src/stat_item.c</span><br><span>@@ -261,6 +261,10 @@</span><br><span> </span><br><span>         *next_id = item_value->id + 1;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ if (id_delta > 1) {</span><br><span style="color: hsl(120, 100%, 40%);">+                LOGP(DLSTATS, LOGL_ERROR, "%s: %d stats values skipped\n", item->desc->name, id_delta - 1);</span><br><span style="color: hsl(120, 100%, 40%);">+   }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>  return id_delta;</span><br><span> }</span><br><span> </span><br><span>diff --git a/tests/stats/stats_test.c b/tests/stats/stats_test.c</span><br><span>index 1d53aaa..a4aedd3 100644</span><br><span>--- a/tests/stats/stats_test.c</span><br><span>+++ b/tests/stats/stats_test.c</span><br><span>@@ -195,6 +195,7 @@</span><br><span>                 osmo_stat_item_set(statg->items[TEST_B_ITEM], 1000 + i);</span><br><span>  }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ fprintf(stderr, "Skipping %d values\n", 93 - 65);</span><br><span>  rc = osmo_stat_item_get_next(statg->items[TEST_A_ITEM], &next_id_a, &value);</span><br><span>      OSMO_ASSERT(rc == 93 - 65 + 1);</span><br><span>      OSMO_ASSERT(value == 93);</span><br><span>@@ -205,6 +206,7 @@</span><br><span>              OSMO_ASSERT(value == i);</span><br><span>     }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ fprintf(stderr, "Skipping %d values\n", 90 - 65);</span><br><span>  rc = osmo_stat_item_get_next(statg->items[TEST_B_ITEM], &next_id_b, &value);</span><br><span>      OSMO_ASSERT(rc == 90 - 65 + 1);</span><br><span>      OSMO_ASSERT(value == 1000 + 90);</span><br><span>diff --git a/tests/stats/stats_test.err b/tests/stats/stats_test.err</span><br><span>index 3accf54..69104d9 100644</span><br><span>--- a/tests/stats/stats_test.err</span><br><span>+++ b/tests/stats/stats_test.err</span><br><span>@@ -1,3 +1,7 @@</span><br><span style="color: hsl(120, 100%, 40%);">+Skipping 28 values</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 28 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+Skipping 25 values</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 25 stats values skipped</span><br><span> Start test: test_reporting</span><br><span> DLGLOBAL ERROR counter group 'ctr-test:one' already exists for index 2, instead using index 3. This is a software bug that needs fixing.</span><br><span> DLGLOBAL ERROR 'ctr-test.one_dot' is not a valid counter group identifier</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/23510">change 23510</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/23510"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I5140d967c2f1d36dadf93b03e52b9bbd42e2a3a6 </div>
<div style="display:none"> Gerrit-Change-Number: 23510 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>