<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/23647">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">[hopping] gsm48_send_rr_ass_cmd(): use Cell Channel Description from SI1<br><br>Calling generate_cell_chan_list() on each Assignment Command is<br>quite expensive, because this function basically re-constructs<br>the Cell Allocation (using bitvec API) and the Frequency List<br>from scratch.  This IE can be borrowed from pre-calculated<br>SI1 message, so let's do this.<br><br>Change-Id: I9c8c5ae9059ff096765412b3f3c7181a94163afc<br>---<br>M src/osmo-bsc/gsm_04_08_rr.c<br>1 file changed, 5 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/47/23647/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/gsm_04_08_rr.c b/src/osmo-bsc/gsm_04_08_rr.c</span><br><span>index a448126..4a47c66 100644</span><br><span>--- a/src/osmo-bsc/gsm_04_08_rr.c</span><br><span>+++ b/src/osmo-bsc/gsm_04_08_rr.c</span><br><span>@@ -592,9 +592,11 @@</span><br><span> </span><br><span>       /* Cell Channel Description (freq. hopping), TV (see 3GPP TS 44.018, 10.5.2.1b) */</span><br><span>   if (lchan->ts->hopping.enabled) {</span><br><span style="color: hsl(0, 100%, 40%);">-         uint8_t *chan_desc = msgb_put(msg, 1 + 16); /* tag + fixed length */</span><br><span style="color: hsl(0, 100%, 40%);">-            generate_cell_chan_list(chan_desc + 1, dest_lchan->ts->trx->bts);</span><br><span style="color: hsl(0, 100%, 40%);">-              chan_desc[0] = GSM48_IE_CELL_CH_DESC;</span><br><span style="color: hsl(120, 100%, 40%);">+         const struct gsm48_system_information_type_1 *si1 = \</span><br><span style="color: hsl(120, 100%, 40%);">+                 GSM_BTS_SI(lchan->ts->trx->bts, 1);</span><br><span style="color: hsl(120, 100%, 40%);">+          msgb_tv_fixed_put(msg, GSM48_IE_CELL_CH_DESC,</span><br><span style="color: hsl(120, 100%, 40%);">+                           sizeof(si1->cell_channel_description),</span><br><span style="color: hsl(120, 100%, 40%);">+                             si1->cell_channel_description);</span><br><span>         }</span><br><span> </span><br><span>        msgb_tv_put(msg, GSM48_IE_CHANMODE_1, lchan->tch_mode);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/23647">change 23647</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/23647"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I9c8c5ae9059ff096765412b3f3c7181a94163afc </div>
<div style="display:none"> Gerrit-Change-Number: 23647 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>