<p>lynxis lazus <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/23565">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, but someone else must approve
  daniel: Looks good to me, but someone else must approve
  lynxis lazus: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gprs_ns2: nsvc_fsm: reorder notification st_alive_on_enter()<br><br>The start_procedure() can't be called after ns2_nse_notify_unblocked()<br>because ns2_nse_notify_unblocked() might free the nsvc.<br>Otherwise the fsm will do use-after-free on the NSVC memory.<br><br>Related: SYS#5416<br>Change-Id: If97dfd123eefd71fc6c3fe886a243a21784aeeb4<br>---<br>M src/gb/gprs_ns2_vc_fsm.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb/gprs_ns2_vc_fsm.c b/src/gb/gprs_ns2_vc_fsm.c</span><br><span>index a8cb570..85cd2ad 100644</span><br><span>--- a/src/gb/gprs_ns2_vc_fsm.c</span><br><span>+++ b/src/gb/gprs_ns2_vc_fsm.c</span><br><span>@@ -460,8 +460,8 @@</span><br><span>     if (old_state != GPRS_NS2_ST_RECOVERING)</span><br><span>             priv->N = 0;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-     ns2_nse_notify_unblocked(priv->nsvc, false);</span><br><span>      start_test_procedure(fi, true);</span><br><span style="color: hsl(120, 100%, 40%);">+       ns2_nse_notify_unblocked(priv->nsvc, false);</span><br><span> }</span><br><span> </span><br><span> static const struct osmo_fsm_state ns2_vc_states[] = {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/23565">change 23565</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/23565"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: If97dfd123eefd71fc6c3fe886a243a21784aeeb4 </div>
<div style="display:none"> Gerrit-Change-Number: 23565 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>