<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/23648">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">[hopping] generate_ma_for_ts() returns no meaningful value<br><br>Change-Id: Ic3ba3323459bba1336adb1f902cb2371edea1f71<br>---<br>M src/osmo-bsc/osmo_bsc_main.c<br>1 file changed, 2 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/48/23648/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/osmo_bsc_main.c b/src/osmo-bsc/osmo_bsc_main.c</span><br><span>index ec07410..6c7c275 100644</span><br><span>--- a/src/osmo-bsc/osmo_bsc_main.c</span><br><span>+++ b/src/osmo-bsc/osmo_bsc_main.c</span><br><span>@@ -256,7 +256,7 @@</span><br><span> }</span><br><span> </span><br><span> /* Produce a MA as specified in 10.5.2.21 */</span><br><span style="color: hsl(0, 100%, 40%);">-static int generate_ma_for_ts(struct gsm_bts_trx_ts *ts)</span><br><span style="color: hsl(120, 100%, 40%);">+static void generate_ma_for_ts(struct gsm_bts_trx_ts *ts)</span><br><span> {</span><br><span>      /* we have three bitvecs: the per-timeslot ARFCNs, the cell chan ARFCNs</span><br><span>       * and the MA */</span><br><span>@@ -271,7 +271,7 @@</span><br><span>       memset(ma->data, 0, ma->data_len);</span><br><span> </span><br><span>         if (!ts->hopping.enabled)</span><br><span style="color: hsl(0, 100%, 40%);">-            return 0;</span><br><span style="color: hsl(120, 100%, 40%);">+             return;</span><br><span> </span><br><span>  /* count the number of ARFCNs in the cell channel allocation */</span><br><span>      num_cell_arfcns = 0;</span><br><span>@@ -303,8 +303,6 @@</span><br><span>           else</span><br><span>                         bitvec_set_bit_pos(ma, ma->cur_bit, 0);</span><br><span>   }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-       return 0;</span><br><span> }</span><br><span> </span><br><span> static void bootstrap_rsl(struct gsm_bts_trx *trx)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/23648">change 23648</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/23648"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic3ba3323459bba1336adb1f902cb2371edea1f71 </div>
<div style="display:none"> Gerrit-Change-Number: 23648 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>