<p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18617">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18617/1/src/osmo-bsc/bts_osmobts.c">File src/osmo-bsc/bts_osmobts.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18617/1/src/osmo-bsc/bts_osmobts.c@54">Patch Set #1, Line 54:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">osmo_bts_set_feature(&model->features, BTS_FEAT_OML_ALERTS);<br>      osmo_bts_set_feature(&model->features, BTS_FEAT_CBCH);<br> osmo_bts_set_feature(&model->features, BTS_FEAT_SPEECH_F_V1);<br>  osmo_bts_set_feature(&model->features, BTS_FEAT_SPEECH_H_V1);<br>  osmo_bts_set_feature(&model->features, BTS_FEAT_SPEECH_F_EFR);<br> osmo_bts_set_feature(&model->features, BTS_FEAT_SPEECH_F_AMR);<br> osmo_bts_set_feature(&model->features, BTS_FEAT_SPEECH_H_AMR);<br> osmo_bts_set_feature(&model->features, BTS_FEAT_ETWS_PN);<br></pre></blockquote></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">how do you know that those are supported by the (remote, possibly old) osmo-bts version?  The point  […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I think I am not understanding the point of having this list of 'expected' features in osmo-bsc. When I was working on this patch, I thought this is what we expect the recent osmo-bts to support. From your response, it now feels more like it's a set of features that any, even a very old osmo-bts version would support. We have EGPRS here, but not SPEECH_* features? Was EGPRS support introduced even earlier than FR/HR/AMR speech coding? I am confused.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18617">change 18617</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/18617"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I431c8ab9478cbc40179903edc21043623d805da1 </div>
<div style="display:none"> Gerrit-Change-Number: 18617 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-CC: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Sun, 04 Apr 2021 17:33:49 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>