<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/23574">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Ignore CHANnel ReQuireD with Access Delay IE > 63<br><br>It is observed that a CHANnel ReQuireD with access delay<br>greater than 63 can be received from the Ericsson RBS.<br>This results in osmo-bsc sending back a CHANnel ACTIVation with<br>a Timing Advance IE containing the access delay value.<br>The RBS NACKs this, leading to a BORKEN Channel.<br><br>This patch makes the maximum acceptable access delay vty-configurable<br>and Ignores CHANnel ReQuireD RSL Messages with Access Delay IE greater<br>than that configured. Default value is 63.<br><br>Related: OS#5096<br>Change-Id: Ie8987bcc0e43921bc753162b77a0efc68799b3ce<br>---<br>M include/osmocom/bsc/bts.h<br>M src/osmo-bsc/abis_rsl.c<br>M src/osmo-bsc/bsc_vty.c<br>M src/osmo-bsc/bts.c<br>4 files changed, 33 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/bsc/bts.h b/include/osmocom/bsc/bts.h</span><br><span>index f40aa3e..c8cf8b3 100644</span><br><span>--- a/include/osmocom/bsc/bts.h</span><br><span>+++ b/include/osmocom/bsc/bts.h</span><br><span>@@ -28,6 +28,7 @@</span><br><span> BTS_CTR_CHREQ_ATTEMPTED_UNKNOWN,</span><br><span> BTS_CTR_CHREQ_SUCCESSFUL,</span><br><span> BTS_CTR_CHREQ_NO_CHANNEL,</span><br><span style="color: hsl(120, 100%, 40%);">+ BTS_CTR_CHREQ_MAX_DELAY_EXCEEDED,</span><br><span> BTS_CTR_CHAN_RF_FAIL,</span><br><span> BTS_CTR_CHAN_RF_FAIL_TCH,</span><br><span> BTS_CTR_CHAN_RF_FAIL_SDCCH,</span><br><span>@@ -529,6 +530,9 @@</span><br><span> /* MS/BS Power Control parameters */</span><br><span> struct gsm_power_ctrl_params ms_power_ctrl;</span><br><span> struct gsm_power_ctrl_params bs_power_ctrl;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* We will ignore CHAN RQD with access delay greater than rach_max_delay */</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t rach_max_delay;</span><br><span> };</span><br><span> </span><br><span> #define GSM_BTS_SI2Q(bts, i) (struct gsm48_system_information_type_2quater *)((bts)->si_buf[SYSINFO_TYPE_2quater][i])</span><br><span>diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c</span><br><span>index 67e7d27..6445b6d 100644</span><br><span>--- a/src/osmo-bsc/abis_rsl.c</span><br><span>+++ b/src/osmo-bsc/abis_rsl.c</span><br><span>@@ -1526,6 +1526,13 @@</span><br><span> return -EINVAL;</span><br><span> }</span><br><span> rqd->ta = rqd_hdr->data[sizeof(struct gsm48_req_ref)+2];</span><br><span style="color: hsl(120, 100%, 40%);">+ if (rqd->ta > bts->rach_max_delay) {</span><br><span style="color: hsl(120, 100%, 40%);">+ LOG_BTS(bts, DRSL, LOGL_INFO, "Ignoring CHAN RQD: Access Delay(%d) greater than %u\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ rqd->ta, bts->rach_max_delay);</span><br><span style="color: hsl(120, 100%, 40%);">+ rate_ctr_inc(&bts->bts_ctrs->ctr[BTS_CTR_CHREQ_MAX_DELAY_EXCEEDED]);</span><br><span style="color: hsl(120, 100%, 40%);">+ talloc_free(rqd);</span><br><span style="color: hsl(120, 100%, 40%);">+ return -EINVAL;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> </span><br><span> /* Determine channel request cause code */</span><br><span> rqd->reason = get_reason_by_chreq(rqd->ref.ra, bts->network->neci);</span><br><span>diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c</span><br><span>index 280fe9f..91eaee0 100644</span><br><span>--- a/src/osmo-bsc/bsc_vty.c</span><br><span>+++ b/src/osmo-bsc/bsc_vty.c</span><br><span>@@ -433,6 +433,8 @@</span><br><span> vty_out(vty, " RACH Max transmissions: %u%s",</span><br><span> rach_max_trans_raw2val(bts->si_common.rach_control.max_trans),</span><br><span> VTY_NEWLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+ vty_out(vty, " RACH Max Delay (Max Access Delay IE in CHANnel ReQuireD): %u%s",</span><br><span style="color: hsl(120, 100%, 40%);">+ bts->rach_max_delay, VTY_NEWLINE);</span><br><span> if (bts->si_common.rach_control.cell_bar)</span><br><span> vty_out(vty, " CELL IS BARRED%s", VTY_NEWLINE);</span><br><span> if (bts->dtxu != GSM48_DTX_SHALL_NOT_BE_USED)</span><br><span>@@ -1041,6 +1043,7 @@</span><br><span> vty_out(vty, " rach max transmission %u%s",</span><br><span> rach_max_trans_raw2val(bts->si_common.rach_control.max_trans),</span><br><span> VTY_NEWLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+ vty_out(vty, " rach max-delay %u%s", bts->rach_max_delay, VTY_NEWLINE);</span><br><span> </span><br><span> vty_out(vty, " channel-description attach %u%s",</span><br><span> bts->si_common.chan_desc.att, VTY_NEWLINE);</span><br><span>@@ -2746,6 +2749,19 @@</span><br><span> return CMD_SUCCESS;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+DEFUN_ATTR(cfg_bts_rach_max_delay,</span><br><span style="color: hsl(120, 100%, 40%);">+ cfg_bts_rach_max_delay_cmd,</span><br><span style="color: hsl(120, 100%, 40%);">+ "rach max-delay <1-127>",</span><br><span style="color: hsl(120, 100%, 40%);">+ RACH_STR</span><br><span style="color: hsl(120, 100%, 40%);">+ "Set the max Access Delay IE value to accept in CHANnel ReQuireD\n"</span><br><span style="color: hsl(120, 100%, 40%);">+ "Maximum Access Delay IE value to accept in CHANnel ReQuireD\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ CMD_ATTR_IMMEDIATE)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ struct gsm_bts *bts = vty->index;</span><br><span style="color: hsl(120, 100%, 40%);">+ bts->rach_max_delay = atoi(argv[0]);</span><br><span style="color: hsl(120, 100%, 40%);">+ return CMD_SUCCESS;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> #define REP_ACCH_STR "FACCH/SACCH repetition\n"</span><br><span> </span><br><span> DEFUN_USRATTR(cfg_bts_rep_dl_facch,</span><br><span>@@ -7668,6 +7684,7 @@</span><br><span> install_element(BTS_NODE, &cfg_bts_challoc_cmd);</span><br><span> install_element(BTS_NODE, &cfg_bts_rach_tx_integer_cmd);</span><br><span> install_element(BTS_NODE, &cfg_bts_rach_max_trans_cmd);</span><br><span style="color: hsl(120, 100%, 40%);">+ install_element(BTS_NODE, &cfg_bts_rach_max_delay_cmd);</span><br><span> install_element(BTS_NODE, &cfg_bts_chan_desc_att_cmd);</span><br><span> install_element(BTS_NODE, &cfg_bts_chan_dscr_att_cmd);</span><br><span> install_element(BTS_NODE, &cfg_bts_chan_desc_bs_pa_mfrms_cmd);</span><br><span>diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c</span><br><span>index 398f26f..b5b7136 100644</span><br><span>--- a/src/osmo-bsc/bts.c</span><br><span>+++ b/src/osmo-bsc/bts.c</span><br><span>@@ -357,6 +357,8 @@</span><br><span> bts->bs_power_ctrl = power_ctrl_params_def;</span><br><span> bts->bs_power_ctrl.dir = GSM_PWR_CTRL_DIR_DL;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ bts->rach_max_delay = 63;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> return bts;</span><br><span> }</span><br><span> </span><br><span>@@ -767,6 +769,9 @@</span><br><span> [BTS_CTR_CHREQ_NO_CHANNEL] = \</span><br><span> { "chreq:no_channel",</span><br><span> "Sent to MS no channel available" },</span><br><span style="color: hsl(120, 100%, 40%);">+ [BTS_CTR_CHREQ_MAX_DELAY_EXCEEDED] = \</span><br><span style="color: hsl(120, 100%, 40%);">+ { "chreq:max_delay_exceeded",</span><br><span style="color: hsl(120, 100%, 40%);">+ "Received channel requests with greater than permitted access delay" },</span><br><span> [BTS_CTR_CHAN_RF_FAIL] = \</span><br><span> { "chan:rf_fail",</span><br><span> "Received a RF failure indication from BTS" },</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/23574">change 23574</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/23574"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie8987bcc0e43921bc753162b77a0efc68799b3ce </div>
<div style="display:none"> Gerrit-Change-Number: 23574 </div>
<div style="display:none"> Gerrit-PatchSet: 8 </div>
<div style="display:none"> Gerrit-Owner: keith <keith@rhizomatica.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>