<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23571">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ggsn: Fix TC_pdp4_act_deact_with_single_dns()<br><br>In TC_pdp4_act_deact_with_single_dns we activate, deactivate and then<br>re-activate a PDP context. Hoewver, we re-use the same variable and<br>don't reset the state in between.  This results in the second PDP CTX<br>activation to include an end-user-address (static IP allocation), which<br>OsmoGGSN doesn't implement.<br><br>Before osmo-ggsn Change-Id Iac8868438655fe4e5e07d167d7dbd6273dbb7678,<br>the test passed as osmo-ggsn simply ignored the requested static address.<br>After that change, we reject static addresses and hence the test starts<br>to fail.<br><br>Change-Id: I1b1869bc2cee39c8fddd8fa63f48bdaa6a65e462<br>Related: OS#5097<br>---<br>M ggsn_tests/GGSN_Tests.ttcn<br>1 file changed, 1 insertion(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/71/23571/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/ggsn_tests/GGSN_Tests.ttcn b/ggsn_tests/GGSN_Tests.ttcn</span><br><span>index be0e565..a0c7b16 100644</span><br><span>--- a/ggsn_tests/GGSN_Tests.ttcn</span><br><span>+++ b/ggsn_tests/GGSN_Tests.ttcn</span><br><span>@@ -1147,6 +1147,7 @@</span><br><span>                 f_pdp_ctx_del(ctx, '1'B);</span><br><span> </span><br><span>                /* PCO with secondary DNS only */</span><br><span style="color: hsl(120, 100%, 40%);">+             ctx := valueof(t_DefinePDP(f_rnd_imsi('26242'H), '1234'O, c_ApnInternet, valueof(t_EuaIPv4Dyn)));</span><br><span>            ctx.pco_req := valueof(ts_PCO_IPv4_SEC_DNS_IPCP);</span><br><span>            f_pdp_ctx_act(ctx);</span><br><span>          pco_neg_dns := f_PCO_extract_proto(ctx.pco_neg, '8021'O, 1);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23571">change 23571</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23571"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I1b1869bc2cee39c8fddd8fa63f48bdaa6a65e462 </div>
<div style="display:none"> Gerrit-Change-Number: 23571 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>