<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23548">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Make f_{block,unblock}_ptp_bvc_from_pcu handle multiple SGSNs<br><br>Those tests predated SGSN pooling support and needed to update<br>their assumptions to also cover other SGSNs in the pool.<br><br>We could come up with more complex, auto-scaling mechanisms to handle<br>different numbers of SGSNs, but that would make the code quite<br>unreadable, as it means we cannot use interleave but have to dynamically<br>activate altsteps for counting.  I went for the simpler approach<br>instead.<br><br>Change-Id: I8c3ec4e00b78cff40ac72bc857161fa7abc352b0<br>Related: OS#4968<br>---<br>M gbproxy/GBProxy_Tests.ttcn<br>1 file changed, 9 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/48/23548/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/gbproxy/GBProxy_Tests.ttcn b/gbproxy/GBProxy_Tests.ttcn</span><br><span>index 5ae153f..91ccbb0 100644</span><br><span>--- a/gbproxy/GBProxy_Tests.ttcn</span><br><span>+++ b/gbproxy/GBProxy_Tests.ttcn</span><br><span>@@ -325,6 +325,9 @@</span><br><span> type record of NSConfiguration NSConfigurations;</span><br><span> type record of BssgpCellId BssgpCellIds;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* you cannot simply change this to any larger number of SGSNs and expect all test</span><br><span style="color: hsl(120, 100%, 40%);">+ * cases to work.  This would have overly complicated the code.  Check below for</span><br><span style="color: hsl(120, 100%, 40%);">+ * tests that use interleave on SGSN_MGMT.receive() for each SGSN NSEI for example */</span><br><span> const integer NUM_SGSN := 2;</span><br><span> </span><br><span> type component test_CT {</span><br><span>@@ -2399,7 +2402,9 @@</span><br><span>        /* expect state on both PCU and SGSN side to change */</span><br><span>       interleave {</span><br><span>         [] PCU_MGMT.receive(tr_BssgpStsInd(nsei_pcu, bvc_cfg.bvci, BVC_S_BLOCKED)) from bvc_ct;</span><br><span style="color: hsl(0, 100%, 40%);">- [] SGSN_MGMT.receive(tr_BssgpStsInd(*, bvc_cfg.bvci, BVC_S_BLOCKED));</span><br><span style="color: hsl(120, 100%, 40%);">+ [] SGSN_MGMT.receive(tr_BssgpStsInd(mp_nsconfig_sgsn[0].nsei, bvc_cfg.bvci, BVC_S_BLOCKED));</span><br><span style="color: hsl(120, 100%, 40%);">+  [] SGSN_MGMT.receive(tr_BssgpStsInd(mp_nsconfig_sgsn[1].nsei, bvc_cfg.bvci, BVC_S_BLOCKED));</span><br><span style="color: hsl(120, 100%, 40%);">+  /* Doesn't auto-scale with NUM_SGSN */</span><br><span>   }</span><br><span>    setverdict(pass);</span><br><span> }</span><br><span>@@ -2425,7 +2430,9 @@</span><br><span>       /* expect state on both PCU and SGSN side to change */</span><br><span>       interleave {</span><br><span>         [] PCU_MGMT.receive(tr_BssgpStsInd(nsei_pcu, bvc_cfg.bvci, BVC_S_UNBLOCKED)) from bvc_ct;</span><br><span style="color: hsl(0, 100%, 40%);">-       [] SGSN_MGMT.receive(tr_BssgpStsInd(*, bvc_cfg.bvci, BVC_S_UNBLOCKED));</span><br><span style="color: hsl(120, 100%, 40%);">+       [] SGSN_MGMT.receive(tr_BssgpStsInd(mp_nsconfig_sgsn[0].nsei, bvc_cfg.bvci, BVC_S_UNBLOCKED));</span><br><span style="color: hsl(120, 100%, 40%);">+        [] SGSN_MGMT.receive(tr_BssgpStsInd(mp_nsconfig_sgsn[1].nsei, bvc_cfg.bvci, BVC_S_UNBLOCKED));</span><br><span style="color: hsl(120, 100%, 40%);">+        /* Doesn't auto-scale with NUM_SGSN */</span><br><span>   }</span><br><span>    setverdict(pass);</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23548">change 23548</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23548"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I8c3ec4e00b78cff40ac72bc857161fa7abc352b0 </div>
<div style="display:none"> Gerrit-Change-Number: 23548 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>