<p>dexter <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/pysim/+/23537">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">filesystem: avoid outputting empty lines when there is no data<br><br>The do_update_... functions do always print the returned data. However,<br>there may be no data. If this is the case than an empty line is printed.<br>This may cause ugly log output, especially when working with scripts.<br><br>Change-Id: Ia9715d46ec957544cfbeea98d2fe15eb74f5b884<br>Related: OS#4963<br>---<br>M pySim/filesystem.py<br>1 file changed, 8 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pySim/filesystem.py b/pySim/filesystem.py</span><br><span>index 04fa250..cb39b94 100644</span><br><span>--- a/pySim/filesystem.py</span><br><span>+++ b/pySim/filesystem.py</span><br><span>@@ -313,7 +313,8 @@</span><br><span>         def do_update_binary(self, opts):</span><br><span>             """Update (Write) data of a transparent EF"""</span><br><span>             (data, sw) = self._cmd.rs.update_binary(opts.data, opts.offset)</span><br><span style="color: hsl(0, 100%, 40%);">-            self._cmd.poutput(data)</span><br><span style="color: hsl(120, 100%, 40%);">+            if data:</span><br><span style="color: hsl(120, 100%, 40%);">+                self._cmd.poutput(data)</span><br><span> </span><br><span>         upd_bin_dec_parser = argparse.ArgumentParser()</span><br><span>         upd_bin_dec_parser.add_argument('data', help='Abstract data (JSON format) to write')</span><br><span>@@ -322,7 +323,8 @@</span><br><span>             """Encode + Update (Write) data of a transparent EF"""</span><br><span>             data_json = json.loads(opts.data)</span><br><span>             (data, sw) = self._cmd.rs.update_binary_dec(data_json)</span><br><span style="color: hsl(0, 100%, 40%);">-            self._cmd.poutput(json.dumps(data, indent=4))</span><br><span style="color: hsl(120, 100%, 40%);">+            if data:</span><br><span style="color: hsl(120, 100%, 40%);">+                self._cmd.poutput(json.dumps(data, indent=4))</span><br><span> </span><br><span>     def __init__(self, fid, sfid=None, name=None, desc=None, parent=None, size={1,None}):</span><br><span>         super().__init__(fid=fid, sfid=sfid, name=name, desc=desc, parent=parent)</span><br><span>@@ -410,7 +412,8 @@</span><br><span>         def do_update_record(self, opts):</span><br><span>             """Update (write) data to a record-oriented EF"""</span><br><span>             (data, sw) = self._cmd.rs.update_record(opts.record_nr, opts.data)</span><br><span style="color: hsl(0, 100%, 40%);">-            self._cmd.poutput(data)</span><br><span style="color: hsl(120, 100%, 40%);">+            if data:</span><br><span style="color: hsl(120, 100%, 40%);">+                self._cmd.poutput(data)</span><br><span> </span><br><span>         upd_rec_dec_parser = argparse.ArgumentParser()</span><br><span>         upd_rec_dec_parser.add_argument('record_nr', type=int, help='Number of record to be read')</span><br><span>@@ -419,7 +422,8 @@</span><br><span>         def do_update_record_decoded(self, opts):</span><br><span>             """Encode + Update (write) data to a record-oriented EF"""</span><br><span>             (data, sw) = self._cmd.rs.update_record_dec(opts.record_nr, opts.data)</span><br><span style="color: hsl(0, 100%, 40%);">-            self._cmd.poutput(data)</span><br><span style="color: hsl(120, 100%, 40%);">+            if data:</span><br><span style="color: hsl(120, 100%, 40%);">+                self._cmd.poutput(data)</span><br><span> </span><br><span>     def __init__(self, fid, sfid=None, name=None, desc=None, parent=None, rec_len={1,None}):</span><br><span>         super().__init__(fid=fid, sfid=sfid, name=name, desc=desc, parent=parent)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/pysim/+/23537">change 23537</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/pysim/+/23537"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: pysim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ia9715d46ec957544cfbeea98d2fe15eb74f5b884 </div>
<div style="display:none"> Gerrit-Change-Number: 23537 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>