<p>neels has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/23524">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">fixup for neighbor config for coverity<br><br>Check against NULL pointers to allow only resolving local or only remote<br>neighbors in resolve_neighbors(). (Though no caller exists currently<br>that would need this feature, it is trivial and more future-safe.)<br><br>Related: CID#220459 CID#220460<br>Change-Id: I8c2046335ec6f8a5d6b757446c98d8e630ee015f<br>---<br>M src/osmo-bsc/neighbor_ident.c<br>1 file changed, 4 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/24/23524/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/neighbor_ident.c b/src/osmo-bsc/neighbor_ident.c</span><br><span>index 263d410..6e70625 100644</span><br><span>--- a/src/osmo-bsc/neighbor_ident.c</span><br><span>+++ b/src/osmo-bsc/neighbor_ident.c</span><br><span>@@ -130,8 +130,10 @@</span><br><span>         struct gsm_bts *local_neighbor = NULL;</span><br><span>       struct gsm0808_cell_id_list2 remotes = {};</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-  *local_neighbor_p = NULL;</span><br><span style="color: hsl(0, 100%, 40%);">-       *remote_neighbors = (struct gsm0808_cell_id_list2){ 0 };</span><br><span style="color: hsl(120, 100%, 40%);">+      if (local_neighbor_p)</span><br><span style="color: hsl(120, 100%, 40%);">+         *local_neighbor_p = NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+     if (remote_neighbors)</span><br><span style="color: hsl(120, 100%, 40%);">+         *remote_neighbors = (struct gsm0808_cell_id_list2){ 0 };</span><br><span> </span><br><span>         llist_for_each_entry(n, &from_bts->neighbors, entry) {</span><br><span>                struct gsm_bts *neigh_bts;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/23524">change 23524</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/23524"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I8c2046335ec6f8a5d6b757446c98d8e630ee015f </div>
<div style="display:none"> Gerrit-Change-Number: 23524 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>