<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/23528">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Remove unneeded poll_state check<br><br>The related ul_ass_state already implies polling is ongoing since we are<br>waiting for an ACK to be received from MS. Hence there's no need to<br>check poll_state there.<br><br>Change-Id: I5e12280a6835407fa452bd4d5df799d2672790ec<br>---<br>M src/tbf.cpp<br>1 file changed, 2 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/28/23528/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/tbf.cpp b/src/tbf.cpp</span><br><span>index 8520a1b..4a57375 100644</span><br><span>--- a/src/tbf.cpp</span><br><span>+++ b/src/tbf.cpp</span><br><span>@@ -866,8 +866,7 @@</span><br><span>                 poll_ass_dl = 0;</span><br><span>     }</span><br><span>    if (poll_ass_dl) {</span><br><span style="color: hsl(0, 100%, 40%);">-              if (poll_state == GPRS_RLCMAC_POLL_SCHED &&</span><br><span style="color: hsl(0, 100%, 40%);">-                     ul_ass_state == GPRS_RLCMAC_UL_ASS_WAIT_ACK)</span><br><span style="color: hsl(120, 100%, 40%);">+          if (ul_ass_state == GPRS_RLCMAC_UL_ASS_WAIT_ACK)</span><br><span>             {</span><br><span>                    LOGPTBF(this, LOGL_DEBUG,</span><br><span>                              "Polling is already scheduled, so we must wait for the uplink assignment...\n");</span><br><span>@@ -997,8 +996,7 @@</span><br><span>   unsigned int rrbp;</span><br><span>   uint32_t new_poll_fn;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-       if (poll_state == GPRS_RLCMAC_POLL_SCHED &&</span><br><span style="color: hsl(0, 100%, 40%);">-             ul_ass_state == GPRS_RLCMAC_UL_ASS_WAIT_ACK) {</span><br><span style="color: hsl(120, 100%, 40%);">+        if (ul_ass_state == GPRS_RLCMAC_UL_ASS_WAIT_ACK) {</span><br><span>           LOGPTBFUL(this, LOGL_DEBUG,</span><br><span>                    "Polling is already scheduled, so we must wait for the uplink assignment...\n");</span><br><span>                 return NULL;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/23528">change 23528</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/23528"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I5e12280a6835407fa452bd4d5df799d2672790ec </div>
<div style="display:none"> Gerrit-Change-Number: 23528 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>