<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/23530">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Get rid of param 'poll' with constant value<br><br>Value 'false' is always passed by all callers of the function, so<br>there's no need to pass it. Furthermore, since it's false, there's no<br>need to access poll_fn since RRBP will always be invalid.<br><br>Change-Id: Ia48ce2a021865e76e813dedb22aca9c2522c5693<br>---<br>M src/bts.cpp<br>M src/bts.h<br>M src/tbf.cpp<br>M src/tbf_dl.cpp<br>M tests/tbf/TbfTest.err<br>5 files changed, 43 insertions(+), 43 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/30/23530/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/bts.cpp b/src/bts.cpp</span><br><span>index fee36be..0443df6 100644</span><br><span>--- a/src/bts.cpp</span><br><span>+++ b/src/bts.cpp</span><br><span>@@ -965,7 +965,7 @@</span><br><span> return 0;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-void bts_snd_dl_ass(struct gprs_rlcmac_bts *bts, struct gprs_rlcmac_tbf *tbf, bool poll, uint16_t pgroup)</span><br><span style="color: hsl(120, 100%, 40%);">+void bts_snd_dl_ass(struct gprs_rlcmac_bts *bts, struct gprs_rlcmac_tbf *tbf, uint16_t pgroup)</span><br><span> {</span><br><span> uint8_t trx_no = tbf->trx->trx_no;</span><br><span> uint8_t ts_no = tbf->first_ts;</span><br><span>@@ -976,12 +976,12 @@</span><br><span> bitvec_unhex(immediate_assignment, DUMMY_VEC); /* standard '2B'O padding */</span><br><span> /* use request reference that has maximum distance to current time,</span><br><span> * so the assignment will not conflict with possible RACH requests. */</span><br><span style="color: hsl(0, 100%, 40%);">- LOGP(DRLCMAC, LOGL_DEBUG, " - TRX=%d (%d) TS=%d TA=%d pollFN=%d\n",</span><br><span style="color: hsl(0, 100%, 40%);">- trx_no, tbf->trx->arfcn, ts_no, tbf->ta(), poll ? tbf->poll_fn : -1);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DRLCMAC, LOGL_DEBUG, " - TRX=%d (%d) TS=%d TA=%d\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ trx_no, tbf->trx->arfcn, ts_no, tbf->ta());</span><br><span> plen = Encoding::write_immediate_assignment(&bts->trx[trx_no].pdch[ts_no],</span><br><span> tbf, immediate_assignment, true, 125,</span><br><span> (tbf->pdch[ts_no]->last_rts_fn + 21216) % GSM_MAX_FN,</span><br><span style="color: hsl(0, 100%, 40%);">- tbf->ta(), 7, poll, tbf->poll_fn,</span><br><span style="color: hsl(120, 100%, 40%);">+ tbf->ta(), 7, false, 0,</span><br><span> bts_get_ms_pwr_alpha(bts), bts->pcu->vty.gamma, -1,</span><br><span> GSM_L1_BURST_TYPE_ACCESS_0);</span><br><span> if (plen >= 0) {</span><br><span>diff --git a/src/bts.h b/src/bts.h</span><br><span>index ab8a973..a8b4d7b 100644</span><br><span>--- a/src/bts.h</span><br><span>+++ b/src/bts.h</span><br><span>@@ -273,7 +273,7 @@</span><br><span> struct gprs_rlcmac_dl_tbf *bts_dl_tbf_by_tfi(struct gprs_rlcmac_bts *bts, uint8_t tfi, uint8_t trx, uint8_t ts);</span><br><span> struct gprs_rlcmac_ul_tbf *bts_ul_tbf_by_tfi(struct gprs_rlcmac_bts *bts, uint8_t tfi, uint8_t trx, uint8_t ts);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-void bts_snd_dl_ass(struct gprs_rlcmac_bts *bts, struct gprs_rlcmac_tbf *tbf, bool poll, uint16_t pgroup);</span><br><span style="color: hsl(120, 100%, 40%);">+void bts_snd_dl_ass(struct gprs_rlcmac_bts *bts, struct gprs_rlcmac_tbf *tbf, uint16_t pgroup);</span><br><span> </span><br><span> void bts_set_current_frame_number(struct gprs_rlcmac_bts *bts, uint32_t frame_number);</span><br><span> void bts_set_current_block_frame_number(struct gprs_rlcmac_bts *bts, int frame_number);</span><br><span>diff --git a/src/tbf.cpp b/src/tbf.cpp</span><br><span>index 1dc052a..0ea0ceb 100644</span><br><span>--- a/src/tbf.cpp</span><br><span>+++ b/src/tbf.cpp</span><br><span>@@ -717,7 +717,7 @@</span><br><span> /* send immediate assignment */</span><br><span> if ((pgroup = imsi2paging_group(imsi())) > 999)</span><br><span> LOGPTBF(dl_tbf, LOGL_ERROR, "IMSI to paging group failed! (%s)\n", imsi());</span><br><span style="color: hsl(0, 100%, 40%);">- bts_snd_dl_ass(dl_tbf->bts, dl_tbf, false, pgroup);</span><br><span style="color: hsl(120, 100%, 40%);">+ bts_snd_dl_ass(dl_tbf->bts, dl_tbf, pgroup);</span><br><span> dl_tbf->m_wait_confirm = 1;</span><br><span> }</span><br><span> } else</span><br><span>diff --git a/src/tbf_dl.cpp b/src/tbf_dl.cpp</span><br><span>index de32a1d..19415f1 100644</span><br><span>--- a/src/tbf_dl.cpp</span><br><span>+++ b/src/tbf_dl.cpp</span><br><span>@@ -616,7 +616,7 @@</span><br><span> /* send immediate assignment */</span><br><span> if ((pgroup = imsi2paging_group(imsi())) > 999)</span><br><span> LOGPTBFDL(this, LOGL_ERROR, "IMSI to paging group failed! (%s)\n", imsi());</span><br><span style="color: hsl(0, 100%, 40%);">- bts_snd_dl_ass(bts, this, false, pgroup);</span><br><span style="color: hsl(120, 100%, 40%);">+ bts_snd_dl_ass(bts, this, pgroup);</span><br><span> m_wait_confirm = 1;</span><br><span> }</span><br><span> }</span><br><span>diff --git a/tests/tbf/TbfTest.err b/tests/tbf/TbfTest.err</span><br><span>index dde62a1..811cfaa 100644</span><br><span>--- a/tests/tbf/TbfTest.err</span><br><span>+++ b/tests/tbf/TbfTest.err</span><br><span>@@ -555,7 +555,7 @@</span><br><span> TBF(TFI=0 TLLI=0xc0000000 DIR=DL STATE=NULL) Send dowlink assignment on PCH, no TBF exist (IMSI=001001000000000)</span><br><span> TBF(TFI=0 TLLI=0xc0000000 DIR=DL STATE=NULL) changes state from NULL to ASSIGN</span><br><span> TBF(TFI=0 TLLI=0xc0000000 DIR=DL STATE=ASSIGN) TX: START Immediate Assignment Downlink (PCH)</span><br><span style="color: hsl(0, 100%, 40%);">- - TRX=0 (0) TS=4 TA=220 pollFN=-1</span><br><span style="color: hsl(120, 100%, 40%);">+ - TRX=0 (0) TS=4 TA=220</span><br><span> TBF(TFI=0 TLLI=0xc0000000 DIR=DL STATE=ASSIGN) appending 256 bytes</span><br><span> Creating MS object, TLLI = 0xffffffff</span><br><span> Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45</span><br><span>@@ -580,7 +580,7 @@</span><br><span> TBF(TFI=1 TLLI=0xc0000001 DIR=DL STATE=NULL) Send dowlink assignment on PCH, no TBF exist (IMSI=001001000000001)</span><br><span> TBF(TFI=1 TLLI=0xc0000001 DIR=DL STATE=NULL) changes state from NULL to ASSIGN</span><br><span> TBF(TFI=1 TLLI=0xc0000001 DIR=DL STATE=ASSIGN) TX: START Immediate Assignment Downlink (PCH)</span><br><span style="color: hsl(0, 100%, 40%);">- - TRX=0 (0) TS=4 TA=220 pollFN=-1</span><br><span style="color: hsl(120, 100%, 40%);">+ - TRX=0 (0) TS=4 TA=220</span><br><span> TBF(TFI=1 TLLI=0xc0000001 DIR=DL STATE=ASSIGN) appending 256 bytes</span><br><span> Creating MS object, TLLI = 0xffffffff</span><br><span> Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45</span><br><span>@@ -605,7 +605,7 @@</span><br><span> TBF(TFI=2 TLLI=0xc0000002 DIR=DL STATE=NULL) Send dowlink assignment on PCH, no TBF exist (IMSI=001001000000002)</span><br><span> TBF(TFI=2 TLLI=0xc0000002 DIR=DL STATE=NULL) changes state from NULL to ASSIGN</span><br><span> TBF(TFI=2 TLLI=0xc0000002 DIR=DL STATE=ASSIGN) TX: START Immediate Assignment Downlink (PCH)</span><br><span style="color: hsl(0, 100%, 40%);">- - TRX=0 (0) TS=4 TA=220 pollFN=-1</span><br><span style="color: hsl(120, 100%, 40%);">+ - TRX=0 (0) TS=4 TA=220</span><br><span> TBF(TFI=2 TLLI=0xc0000002 DIR=DL STATE=ASSIGN) appending 256 bytes</span><br><span> Creating MS object, TLLI = 0xffffffff</span><br><span> Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45</span><br><span>@@ -630,7 +630,7 @@</span><br><span> TBF(TFI=3 TLLI=0xc0000003 DIR=DL STATE=NULL) Send dowlink assignment on PCH, no TBF exist (IMSI=001001000000003)</span><br><span> TBF(TFI=3 TLLI=0xc0000003 DIR=DL STATE=NULL) changes state from NULL to ASSIGN</span><br><span> TBF(TFI=3 TLLI=0xc0000003 DIR=DL STATE=ASSIGN) TX: START Immediate Assignment Downlink (PCH)</span><br><span style="color: hsl(0, 100%, 40%);">- - TRX=0 (0) TS=4 TA=220 pollFN=-1</span><br><span style="color: hsl(120, 100%, 40%);">+ - TRX=0 (0) TS=4 TA=220</span><br><span> TBF(TFI=3 TLLI=0xc0000003 DIR=DL STATE=ASSIGN) appending 256 bytes</span><br><span> Creating MS object, TLLI = 0xffffffff</span><br><span> Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45</span><br><span>@@ -655,7 +655,7 @@</span><br><span> TBF(TFI=4 TLLI=0xc0000004 DIR=DL STATE=NULL) Send dowlink assignment on PCH, no TBF exist (IMSI=001001000000004)</span><br><span> TBF(TFI=4 TLLI=0xc0000004 DIR=DL STATE=NULL) changes state from NULL to ASSIGN</span><br><span> TBF(TFI=4 TLLI=0xc0000004 DIR=DL STATE=ASSIGN) TX: START Immediate Assignment Downlink (PCH)</span><br><span style="color: hsl(0, 100%, 40%);">- - TRX=0 (0) TS=4 TA=220 pollFN=-1</span><br><span style="color: hsl(120, 100%, 40%);">+ - TRX=0 (0) TS=4 TA=220</span><br><span> TBF(TFI=4 TLLI=0xc0000004 DIR=DL STATE=ASSIGN) appending 256 bytes</span><br><span> Creating MS object, TLLI = 0xffffffff</span><br><span> Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45</span><br><span>@@ -680,7 +680,7 @@</span><br><span> TBF(TFI=5 TLLI=0xc0000005 DIR=DL STATE=NULL) Send dowlink assignment on PCH, no TBF exist (IMSI=001001000000005)</span><br><span> TBF(TFI=5 TLLI=0xc0000005 DIR=DL STATE=NULL) changes state from NULL to ASSIGN</span><br><span> TBF(TFI=5 TLLI=0xc0000005 DIR=DL STATE=ASSIGN) TX: START Immediate Assignment Downlink (PCH)</span><br><span style="color: hsl(0, 100%, 40%);">- - TRX=0 (0) TS=4 TA=220 pollFN=-1</span><br><span style="color: hsl(120, 100%, 40%);">+ - TRX=0 (0) TS=4 TA=220</span><br><span> TBF(TFI=5 TLLI=0xc0000005 DIR=DL STATE=ASSIGN) appending 256 bytes</span><br><span> Creating MS object, TLLI = 0xffffffff</span><br><span> Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45</span><br><span>@@ -705,7 +705,7 @@</span><br><span> TBF(TFI=6 TLLI=0xc0000006 DIR=DL STATE=NULL) Send dowlink assignment on PCH, no TBF exist (IMSI=001001000000006)</span><br><span> TBF(TFI=6 TLLI=0xc0000006 DIR=DL STATE=NULL) changes state from NULL to ASSIGN</span><br><span> TBF(TFI=6 TLLI=0xc0000006 DIR=DL STATE=ASSIGN) TX: START Immediate Assignment Downlink (PCH)</span><br><span style="color: hsl(0, 100%, 40%);">- - TRX=0 (0) TS=4 TA=220 pollFN=-1</span><br><span style="color: hsl(120, 100%, 40%);">+ - TRX=0 (0) TS=4 TA=220</span><br><span> TBF(TFI=6 TLLI=0xc0000006 DIR=DL STATE=ASSIGN) appending 256 bytes</span><br><span> Creating MS object, TLLI = 0xffffffff</span><br><span> Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45</span><br><span>@@ -730,7 +730,7 @@</span><br><span> TBF(TFI=7 TLLI=0xc0000007 DIR=DL STATE=NULL) Send dowlink assignment on PCH, no TBF exist (IMSI=001001000000007)</span><br><span> TBF(TFI=7 TLLI=0xc0000007 DIR=DL STATE=NULL) changes state from NULL to ASSIGN</span><br><span> TBF(TFI=7 TLLI=0xc0000007 DIR=DL STATE=ASSIGN) TX: START Immediate Assignment Downlink (PCH)</span><br><span style="color: hsl(0, 100%, 40%);">- - TRX=0 (0) TS=4 TA=220 pollFN=-1</span><br><span style="color: hsl(120, 100%, 40%);">+ - TRX=0 (0) TS=4 TA=220</span><br><span> TBF(TFI=7 TLLI=0xc0000007 DIR=DL STATE=ASSIGN) appending 256 bytes</span><br><span> Creating MS object, TLLI = 0xffffffff</span><br><span> Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45</span><br><span>@@ -755,7 +755,7 @@</span><br><span> TBF(TFI=8 TLLI=0xc0000008 DIR=DL STATE=NULL) Send dowlink assignment on PCH, no TBF exist (IMSI=001001000000008)</span><br><span> TBF(TFI=8 TLLI=0xc0000008 DIR=DL STATE=NULL) changes state from NULL to ASSIGN</span><br><span> TBF(TFI=8 TLLI=0xc0000008 DIR=DL STATE=ASSIGN) TX: START Immediate Assignment Downlink (PCH)</span><br><span style="color: hsl(0, 100%, 40%);">- - TRX=0 (0) TS=4 TA=220 pollFN=-1</span><br><span style="color: hsl(120, 100%, 40%);">+ - TRX=0 (0) TS=4 TA=220</span><br><span> TBF(TFI=8 TLLI=0xc0000008 DIR=DL STATE=ASSIGN) appending 256 bytes</span><br><span> Creating MS object, TLLI = 0xffffffff</span><br><span> Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45</span><br><span>@@ -780,7 +780,7 @@</span><br><span> TBF(TFI=9 TLLI=0xc0000009 DIR=DL STATE=NULL) Send dowlink assignment on PCH, no TBF exist (IMSI=001001000000009)</span><br><span> TBF(TFI=9 TLLI=0xc0000009 DIR=DL STATE=NULL) changes state from NULL to ASSIGN</span><br><span> TBF(TFI=9 TLLI=0xc0000009 DIR=DL STATE=ASSIGN) TX: START Immediate Assignment Downlink (PCH)</span><br><span style="color: hsl(0, 100%, 40%);">- - TRX=0 (0) TS=4 TA=220 pollFN=-1</span><br><span style="color: hsl(120, 100%, 40%);">+ - TRX=0 (0) TS=4 TA=220</span><br><span> TBF(TFI=9 TLLI=0xc0000009 DIR=DL STATE=ASSIGN) appending 256 bytes</span><br><span> Creating MS object, TLLI = 0xffffffff</span><br><span> Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45</span><br><span>@@ -805,7 +805,7 @@</span><br><span> TBF(TFI=10 TLLI=0xc000000a DIR=DL STATE=NULL) Send dowlink assignment on PCH, no TBF exist (IMSI=001001000000010)</span><br><span> TBF(TFI=10 TLLI=0xc000000a DIR=DL STATE=NULL) changes state from NULL to ASSIGN</span><br><span> TBF(TFI=10 TLLI=0xc000000a DIR=DL STATE=ASSIGN) TX: START Immediate Assignment Downlink (PCH)</span><br><span style="color: hsl(0, 100%, 40%);">- - TRX=0 (0) TS=4 TA=220 pollFN=-1</span><br><span style="color: hsl(120, 100%, 40%);">+ - TRX=0 (0) TS=4 TA=220</span><br><span> TBF(TFI=10 TLLI=0xc000000a DIR=DL STATE=ASSIGN) appending 256 bytes</span><br><span> Creating MS object, TLLI = 0xffffffff</span><br><span> Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45</span><br><span>@@ -830,7 +830,7 @@</span><br><span> TBF(TFI=11 TLLI=0xc000000b DIR=DL STATE=NULL) Send dowlink assignment on PCH, no TBF exist (IMSI=001001000000011)</span><br><span> TBF(TFI=11 TLLI=0xc000000b DIR=DL STATE=NULL) changes state from NULL to ASSIGN</span><br><span> TBF(TFI=11 TLLI=0xc000000b DIR=DL STATE=ASSIGN) TX: START Immediate Assignment Downlink (PCH)</span><br><span style="color: hsl(0, 100%, 40%);">- - TRX=0 (0) TS=4 TA=220 pollFN=-1</span><br><span style="color: hsl(120, 100%, 40%);">+ - TRX=0 (0) TS=4 TA=220</span><br><span> TBF(TFI=11 TLLI=0xc000000b DIR=DL STATE=ASSIGN) appending 256 bytes</span><br><span> Creating MS object, TLLI = 0xffffffff</span><br><span> Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45</span><br><span>@@ -855,7 +855,7 @@</span><br><span> TBF(TFI=12 TLLI=0xc000000c DIR=DL STATE=NULL) Send dowlink assignment on PCH, no TBF exist (IMSI=001001000000012)</span><br><span> TBF(TFI=12 TLLI=0xc000000c DIR=DL STATE=NULL) changes state from NULL to ASSIGN</span><br><span> TBF(TFI=12 TLLI=0xc000000c DIR=DL STATE=ASSIGN) TX: START Immediate Assignment Downlink (PCH)</span><br><span style="color: hsl(0, 100%, 40%);">- - TRX=0 (0) TS=4 TA=220 pollFN=-1</span><br><span style="color: hsl(120, 100%, 40%);">+ - TRX=0 (0) TS=4 TA=220</span><br><span> TBF(TFI=12 TLLI=0xc000000c DIR=DL STATE=ASSIGN) appending 256 bytes</span><br><span> Creating MS object, TLLI = 0xffffffff</span><br><span> Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45</span><br><span>@@ -880,7 +880,7 @@</span><br><span> TBF(TFI=13 TLLI=0xc000000d DIR=DL STATE=NULL) Send dowlink assignment on PCH, no TBF exist (IMSI=001001000000013)</span><br><span> TBF(TFI=13 TLLI=0xc000000d DIR=DL STATE=NULL) changes state from NULL to ASSIGN</span><br><span> TBF(TFI=13 TLLI=0xc000000d DIR=DL STATE=ASSIGN) TX: START Immediate Assignment Downlink (PCH)</span><br><span style="color: hsl(0, 100%, 40%);">- - TRX=0 (0) TS=4 TA=220 pollFN=-1</span><br><span style="color: hsl(120, 100%, 40%);">+ - TRX=0 (0) TS=4 TA=220</span><br><span> TBF(TFI=13 TLLI=0xc000000d DIR=DL STATE=ASSIGN) appending 256 bytes</span><br><span> Creating MS object, TLLI = 0xffffffff</span><br><span> Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45</span><br><span>@@ -905,7 +905,7 @@</span><br><span> TBF(TFI=14 TLLI=0xc000000e DIR=DL STATE=NULL) Send dowlink assignment on PCH, no TBF exist (IMSI=001001000000014)</span><br><span> TBF(TFI=14 TLLI=0xc000000e DIR=DL STATE=NULL) changes state from NULL to ASSIGN</span><br><span> TBF(TFI=14 TLLI=0xc000000e DIR=DL STATE=ASSIGN) TX: START Immediate Assignment Downlink (PCH)</span><br><span style="color: hsl(0, 100%, 40%);">- - TRX=0 (0) TS=4 TA=220 pollFN=-1</span><br><span style="color: hsl(120, 100%, 40%);">+ - TRX=0 (0) TS=4 TA=220</span><br><span> TBF(TFI=14 TLLI=0xc000000e DIR=DL STATE=ASSIGN) appending 256 bytes</span><br><span> Creating MS object, TLLI = 0xffffffff</span><br><span> Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45</span><br><span>@@ -930,7 +930,7 @@</span><br><span> TBF(TFI=15 TLLI=0xc000000f DIR=DL STATE=NULL) Send dowlink assignment on PCH, no TBF exist (IMSI=001001000000015)</span><br><span> TBF(TFI=15 TLLI=0xc000000f DIR=DL STATE=NULL) changes state from NULL to ASSIGN</span><br><span> TBF(TFI=15 TLLI=0xc000000f DIR=DL STATE=ASSIGN) TX: START Immediate Assignment Downlink (PCH)</span><br><span style="color: hsl(0, 100%, 40%);">- - TRX=0 (0) TS=4 TA=220 pollFN=-1</span><br><span style="color: hsl(120, 100%, 40%);">+ - TRX=0 (0) TS=4 TA=220</span><br><span> TBF(TFI=15 TLLI=0xc000000f DIR=DL STATE=ASSIGN) appending 256 bytes</span><br><span> Creating MS object, TLLI = 0xffffffff</span><br><span> Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45</span><br><span>@@ -955,7 +955,7 @@</span><br><span> TBF(TFI=16 TLLI=0xc0000010 DIR=DL STATE=NULL) Send dowlink assignment on PCH, no TBF exist (IMSI=001001000000016)</span><br><span> TBF(TFI=16 TLLI=0xc0000010 DIR=DL STATE=NULL) changes state from NULL to ASSIGN</span><br><span> TBF(TFI=16 TLLI=0xc0000010 DIR=DL STATE=ASSIGN) TX: START Immediate Assignment Downlink (PCH)</span><br><span style="color: hsl(0, 100%, 40%);">- - TRX=0 (0) TS=4 TA=220 pollFN=-1</span><br><span style="color: hsl(120, 100%, 40%);">+ - TRX=0 (0) TS=4 TA=220</span><br><span> TBF(TFI=16 TLLI=0xc0000010 DIR=DL STATE=ASSIGN) appending 256 bytes</span><br><span> Creating MS object, TLLI = 0xffffffff</span><br><span> Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45</span><br><span>@@ -980,7 +980,7 @@</span><br><span> TBF(TFI=17 TLLI=0xc0000011 DIR=DL STATE=NULL) Send dowlink assignment on PCH, no TBF exist (IMSI=001001000000017)</span><br><span> TBF(TFI=17 TLLI=0xc0000011 DIR=DL STATE=NULL) changes state from NULL to ASSIGN</span><br><span> TBF(TFI=17 TLLI=0xc0000011 DIR=DL STATE=ASSIGN) TX: START Immediate Assignment Downlink (PCH)</span><br><span style="color: hsl(0, 100%, 40%);">- - TRX=0 (0) TS=4 TA=220 pollFN=-1</span><br><span style="color: hsl(120, 100%, 40%);">+ - TRX=0 (0) TS=4 TA=220</span><br><span> TBF(TFI=17 TLLI=0xc0000011 DIR=DL STATE=ASSIGN) appending 256 bytes</span><br><span> Creating MS object, TLLI = 0xffffffff</span><br><span> Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45</span><br><span>@@ -1005,7 +1005,7 @@</span><br><span> TBF(TFI=18 TLLI=0xc0000012 DIR=DL STATE=NULL) Send dowlink assignment on PCH, no TBF exist (IMSI=001001000000018)</span><br><span> TBF(TFI=18 TLLI=0xc0000012 DIR=DL STATE=NULL) changes state from NULL to ASSIGN</span><br><span> TBF(TFI=18 TLLI=0xc0000012 DIR=DL STATE=ASSIGN) TX: START Immediate Assignment Downlink (PCH)</span><br><span style="color: hsl(0, 100%, 40%);">- - TRX=0 (0) TS=4 TA=220 pollFN=-1</span><br><span style="color: hsl(120, 100%, 40%);">+ - TRX=0 (0) TS=4 TA=220</span><br><span> TBF(TFI=18 TLLI=0xc0000012 DIR=DL STATE=ASSIGN) appending 256 bytes</span><br><span> Creating MS object, TLLI = 0xffffffff</span><br><span> Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45</span><br><span>@@ -1030,7 +1030,7 @@</span><br><span> TBF(TFI=19 TLLI=0xc0000013 DIR=DL STATE=NULL) Send dowlink assignment on PCH, no TBF exist (IMSI=001001000000019)</span><br><span> TBF(TFI=19 TLLI=0xc0000013 DIR=DL STATE=NULL) changes state from NULL to ASSIGN</span><br><span> TBF(TFI=19 TLLI=0xc0000013 DIR=DL STATE=ASSIGN) TX: START Immediate Assignment Downlink (PCH)</span><br><span style="color: hsl(0, 100%, 40%);">- - TRX=0 (0) TS=4 TA=220 pollFN=-1</span><br><span style="color: hsl(120, 100%, 40%);">+ - TRX=0 (0) TS=4 TA=220</span><br><span> TBF(TFI=19 TLLI=0xc0000013 DIR=DL STATE=ASSIGN) appending 256 bytes</span><br><span> Creating MS object, TLLI = 0xffffffff</span><br><span> Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45</span><br><span>@@ -1055,7 +1055,7 @@</span><br><span> TBF(TFI=20 TLLI=0xc0000014 DIR=DL STATE=NULL) Send dowlink assignment on PCH, no TBF exist (IMSI=001001000000020)</span><br><span> TBF(TFI=20 TLLI=0xc0000014 DIR=DL STATE=NULL) changes state from NULL to ASSIGN</span><br><span> TBF(TFI=20 TLLI=0xc0000014 DIR=DL STATE=ASSIGN) TX: START Immediate Assignment Downlink (PCH)</span><br><span style="color: hsl(0, 100%, 40%);">- - TRX=0 (0) TS=4 TA=220 pollFN=-1</span><br><span style="color: hsl(120, 100%, 40%);">+ - TRX=0 (0) TS=4 TA=220</span><br><span> TBF(TFI=20 TLLI=0xc0000014 DIR=DL STATE=ASSIGN) appending 256 bytes</span><br><span> Creating MS object, TLLI = 0xffffffff</span><br><span> Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45</span><br><span>@@ -1080,7 +1080,7 @@</span><br><span> TBF(TFI=21 TLLI=0xc0000015 DIR=DL STATE=NULL) Send dowlink assignment on PCH, no TBF exist (IMSI=001001000000021)</span><br><span> TBF(TFI=21 TLLI=0xc0000015 DIR=DL STATE=NULL) changes state from NULL to ASSIGN</span><br><span> TBF(TFI=21 TLLI=0xc0000015 DIR=DL STATE=ASSIGN) TX: START Immediate Assignment Downlink (PCH)</span><br><span style="color: hsl(0, 100%, 40%);">- - TRX=0 (0) TS=4 TA=220 pollFN=-1</span><br><span style="color: hsl(120, 100%, 40%);">+ - TRX=0 (0) TS=4 TA=220</span><br><span> TBF(TFI=21 TLLI=0xc0000015 DIR=DL STATE=ASSIGN) appending 256 bytes</span><br><span> Creating MS object, TLLI = 0xffffffff</span><br><span> Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45</span><br><span>@@ -1105,7 +1105,7 @@</span><br><span> TBF(TFI=22 TLLI=0xc0000016 DIR=DL STATE=NULL) Send dowlink assignment on PCH, no TBF exist (IMSI=001001000000022)</span><br><span> TBF(TFI=22 TLLI=0xc0000016 DIR=DL STATE=NULL) changes state from NULL to ASSIGN</span><br><span> TBF(TFI=22 TLLI=0xc0000016 DIR=DL STATE=ASSIGN) TX: START Immediate Assignment Downlink (PCH)</span><br><span style="color: hsl(0, 100%, 40%);">- - TRX=0 (0) TS=4 TA=220 pollFN=-1</span><br><span style="color: hsl(120, 100%, 40%);">+ - TRX=0 (0) TS=4 TA=220</span><br><span> TBF(TFI=22 TLLI=0xc0000016 DIR=DL STATE=ASSIGN) appending 256 bytes</span><br><span> Creating MS object, TLLI = 0xffffffff</span><br><span> Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45</span><br><span>@@ -1130,7 +1130,7 @@</span><br><span> TBF(TFI=23 TLLI=0xc0000017 DIR=DL STATE=NULL) Send dowlink assignment on PCH, no TBF exist (IMSI=001001000000023)</span><br><span> TBF(TFI=23 TLLI=0xc0000017 DIR=DL STATE=NULL) changes state from NULL to ASSIGN</span><br><span> TBF(TFI=23 TLLI=0xc0000017 DIR=DL STATE=ASSIGN) TX: START Immediate Assignment Downlink (PCH)</span><br><span style="color: hsl(0, 100%, 40%);">- - TRX=0 (0) TS=4 TA=220 pollFN=-1</span><br><span style="color: hsl(120, 100%, 40%);">+ - TRX=0 (0) TS=4 TA=220</span><br><span> TBF(TFI=23 TLLI=0xc0000017 DIR=DL STATE=ASSIGN) appending 256 bytes</span><br><span> Creating MS object, TLLI = 0xffffffff</span><br><span> Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45</span><br><span>@@ -1155,7 +1155,7 @@</span><br><span> TBF(TFI=24 TLLI=0xc0000018 DIR=DL STATE=NULL) Send dowlink assignment on PCH, no TBF exist (IMSI=001001000000024)</span><br><span> TBF(TFI=24 TLLI=0xc0000018 DIR=DL STATE=NULL) changes state from NULL to ASSIGN</span><br><span> TBF(TFI=24 TLLI=0xc0000018 DIR=DL STATE=ASSIGN) TX: START Immediate Assignment Downlink (PCH)</span><br><span style="color: hsl(0, 100%, 40%);">- - TRX=0 (0) TS=4 TA=220 pollFN=-1</span><br><span style="color: hsl(120, 100%, 40%);">+ - TRX=0 (0) TS=4 TA=220</span><br><span> TBF(TFI=24 TLLI=0xc0000018 DIR=DL STATE=ASSIGN) appending 256 bytes</span><br><span> Creating MS object, TLLI = 0xffffffff</span><br><span> Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45</span><br><span>@@ -1180,7 +1180,7 @@</span><br><span> TBF(TFI=25 TLLI=0xc0000019 DIR=DL STATE=NULL) Send dowlink assignment on PCH, no TBF exist (IMSI=001001000000025)</span><br><span> TBF(TFI=25 TLLI=0xc0000019 DIR=DL STATE=NULL) changes state from NULL to ASSIGN</span><br><span> TBF(TFI=25 TLLI=0xc0000019 DIR=DL STATE=ASSIGN) TX: START Immediate Assignment Downlink (PCH)</span><br><span style="color: hsl(0, 100%, 40%);">- - TRX=0 (0) TS=4 TA=220 pollFN=-1</span><br><span style="color: hsl(120, 100%, 40%);">+ - TRX=0 (0) TS=4 TA=220</span><br><span> TBF(TFI=25 TLLI=0xc0000019 DIR=DL STATE=ASSIGN) appending 256 bytes</span><br><span> Creating MS object, TLLI = 0xffffffff</span><br><span> Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45</span><br><span>@@ -1205,7 +1205,7 @@</span><br><span> TBF(TFI=26 TLLI=0xc000001a DIR=DL STATE=NULL) Send dowlink assignment on PCH, no TBF exist (IMSI=001001000000026)</span><br><span> TBF(TFI=26 TLLI=0xc000001a DIR=DL STATE=NULL) changes state from NULL to ASSIGN</span><br><span> TBF(TFI=26 TLLI=0xc000001a DIR=DL STATE=ASSIGN) TX: START Immediate Assignment Downlink (PCH)</span><br><span style="color: hsl(0, 100%, 40%);">- - TRX=0 (0) TS=4 TA=220 pollFN=-1</span><br><span style="color: hsl(120, 100%, 40%);">+ - TRX=0 (0) TS=4 TA=220</span><br><span> TBF(TFI=26 TLLI=0xc000001a DIR=DL STATE=ASSIGN) appending 256 bytes</span><br><span> Creating MS object, TLLI = 0xffffffff</span><br><span> Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45</span><br><span>@@ -1230,7 +1230,7 @@</span><br><span> TBF(TFI=27 TLLI=0xc000001b DIR=DL STATE=NULL) Send dowlink assignment on PCH, no TBF exist (IMSI=001001000000027)</span><br><span> TBF(TFI=27 TLLI=0xc000001b DIR=DL STATE=NULL) changes state from NULL to ASSIGN</span><br><span> TBF(TFI=27 TLLI=0xc000001b DIR=DL STATE=ASSIGN) TX: START Immediate Assignment Downlink (PCH)</span><br><span style="color: hsl(0, 100%, 40%);">- - TRX=0 (0) TS=4 TA=220 pollFN=-1</span><br><span style="color: hsl(120, 100%, 40%);">+ - TRX=0 (0) TS=4 TA=220</span><br><span> TBF(TFI=27 TLLI=0xc000001b DIR=DL STATE=ASSIGN) appending 256 bytes</span><br><span> Creating MS object, TLLI = 0xffffffff</span><br><span> Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45</span><br><span>@@ -1255,7 +1255,7 @@</span><br><span> TBF(TFI=28 TLLI=0xc000001c DIR=DL STATE=NULL) Send dowlink assignment on PCH, no TBF exist (IMSI=001001000000028)</span><br><span> TBF(TFI=28 TLLI=0xc000001c DIR=DL STATE=NULL) changes state from NULL to ASSIGN</span><br><span> TBF(TFI=28 TLLI=0xc000001c DIR=DL STATE=ASSIGN) TX: START Immediate Assignment Downlink (PCH)</span><br><span style="color: hsl(0, 100%, 40%);">- - TRX=0 (0) TS=4 TA=220 pollFN=-1</span><br><span style="color: hsl(120, 100%, 40%);">+ - TRX=0 (0) TS=4 TA=220</span><br><span> TBF(TFI=28 TLLI=0xc000001c DIR=DL STATE=ASSIGN) appending 256 bytes</span><br><span> Creating MS object, TLLI = 0xffffffff</span><br><span> Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45</span><br><span>@@ -1280,7 +1280,7 @@</span><br><span> TBF(TFI=29 TLLI=0xc000001d DIR=DL STATE=NULL) Send dowlink assignment on PCH, no TBF exist (IMSI=001001000000029)</span><br><span> TBF(TFI=29 TLLI=0xc000001d DIR=DL STATE=NULL) changes state from NULL to ASSIGN</span><br><span> TBF(TFI=29 TLLI=0xc000001d DIR=DL STATE=ASSIGN) TX: START Immediate Assignment Downlink (PCH)</span><br><span style="color: hsl(0, 100%, 40%);">- - TRX=0 (0) TS=4 TA=220 pollFN=-1</span><br><span style="color: hsl(120, 100%, 40%);">+ - TRX=0 (0) TS=4 TA=220</span><br><span> TBF(TFI=29 TLLI=0xc000001d DIR=DL STATE=ASSIGN) appending 256 bytes</span><br><span> Creating MS object, TLLI = 0xffffffff</span><br><span> Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45</span><br><span>@@ -1305,7 +1305,7 @@</span><br><span> TBF(TFI=30 TLLI=0xc000001e DIR=DL STATE=NULL) Send dowlink assignment on PCH, no TBF exist (IMSI=001001000000030)</span><br><span> TBF(TFI=30 TLLI=0xc000001e DIR=DL STATE=NULL) changes state from NULL to ASSIGN</span><br><span> TBF(TFI=30 TLLI=0xc000001e DIR=DL STATE=ASSIGN) TX: START Immediate Assignment Downlink (PCH)</span><br><span style="color: hsl(0, 100%, 40%);">- - TRX=0 (0) TS=4 TA=220 pollFN=-1</span><br><span style="color: hsl(120, 100%, 40%);">+ - TRX=0 (0) TS=4 TA=220</span><br><span> TBF(TFI=30 TLLI=0xc000001e DIR=DL STATE=ASSIGN) appending 256 bytes</span><br><span> Creating MS object, TLLI = 0xffffffff</span><br><span> Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45</span><br><span>@@ -1330,7 +1330,7 @@</span><br><span> TBF(TFI=31 TLLI=0xc000001f DIR=DL STATE=NULL) Send dowlink assignment on PCH, no TBF exist (IMSI=001001000000031)</span><br><span> TBF(TFI=31 TLLI=0xc000001f DIR=DL STATE=NULL) changes state from NULL to ASSIGN</span><br><span> TBF(TFI=31 TLLI=0xc000001f DIR=DL STATE=ASSIGN) TX: START Immediate Assignment Downlink (PCH)</span><br><span style="color: hsl(0, 100%, 40%);">- - TRX=0 (0) TS=4 TA=220 pollFN=-1</span><br><span style="color: hsl(120, 100%, 40%);">+ - TRX=0 (0) TS=4 TA=220</span><br><span> TBF(TFI=31 TLLI=0xc000001f DIR=DL STATE=ASSIGN) appending 256 bytes</span><br><span> Creating MS object, TLLI = 0xffffffff</span><br><span> Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45</span><br><span>@@ -1368,7 +1368,7 @@</span><br><span> TBF(TFI=0 TLLI=0xc0123456 DIR=DL STATE=NULL) Send dowlink assignment on PCH, no TBF exist (IMSI=001001000123456)</span><br><span> TBF(TFI=0 TLLI=0xc0123456 DIR=DL STATE=NULL) changes state from NULL to ASSIGN</span><br><span> TBF(TFI=0 TLLI=0xc0123456 DIR=DL STATE=ASSIGN) TX: START Immediate Assignment Downlink (PCH)</span><br><span style="color: hsl(0, 100%, 40%);">- - TRX=0 (0) TS=4 TA=220 pollFN=-1</span><br><span style="color: hsl(120, 100%, 40%);">+ - TRX=0 (0) TS=4 TA=220</span><br><span> TBF(TFI=0 TLLI=0xc0123456 DIR=DL STATE=ASSIGN) appending 19 bytes</span><br><span> Modifying MS object, TLLI = 0xc0123456, TA 220 -> 0</span><br><span> TBF(TFI=0 TLLI=0xc0123456 DIR=DL STATE=ASSIGN) appending 19 bytes</span><br><span>@@ -1399,7 +1399,7 @@</span><br><span> TBF(TFI=0 TLLI=0xc0123456 DIR=DL STATE=NULL) Send dowlink assignment on PCH, no TBF exist (IMSI=001001000123456)</span><br><span> TBF(TFI=0 TLLI=0xc0123456 DIR=DL STATE=NULL) changes state from NULL to ASSIGN</span><br><span> TBF(TFI=0 TLLI=0xc0123456 DIR=DL STATE=ASSIGN) TX: START Immediate Assignment Downlink (PCH)</span><br><span style="color: hsl(0, 100%, 40%);">- - TRX=0 (0) TS=4 TA=0 pollFN=-1</span><br><span style="color: hsl(120, 100%, 40%);">+ - TRX=0 (0) TS=4 TA=0</span><br><span> TBF(TFI=0 TLLI=0xc0123456 DIR=DL STATE=ASSIGN) appending 19 bytes</span><br><span> TBF(TFI=0 TLLI=0xc0123456 DIR=DL STATE=ASSIGN) downlink (V(A)==0 .. V(S)==0) mcs_mode_restrict=EGPRS</span><br><span> TBF(TFI=0 TLLI=0xc0123456 DIR=DL STATE=ASSIGN) Sending new block at BSN 0, CS=CS-1</span><br><span>@@ -1503,7 +1503,7 @@</span><br><span> TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NULL) Send dowlink assignment on PCH, no TBF exist (IMSI=0011223344)</span><br><span> TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NULL) changes state from NULL to ASSIGN</span><br><span> TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=ASSIGN) TX: START Immediate Assignment Downlink (PCH)</span><br><span style="color: hsl(0, 100%, 40%);">- - TRX=0 (0) TS=7 TA=7 pollFN=-1</span><br><span style="color: hsl(120, 100%, 40%);">+ - TRX=0 (0) TS=7 TA=7</span><br><span> TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=ASSIGN) appending 4 bytes</span><br><span> === end test_tbf_single_phase ===</span><br><span> === start test_tbf_two_phase ===</span><br><span>@@ -3153,7 +3153,7 @@</span><br><span> TBF(TFI=0 TLLI=0xc0006789 DIR=DL STATE=NULL) Send dowlink assignment on PCH, no TBF exist (IMSI=001001123456789)</span><br><span> TBF(TFI=0 TLLI=0xc0006789 DIR=DL STATE=NULL) changes state from NULL to ASSIGN</span><br><span> TBF(TFI=0 TLLI=0xc0006789 DIR=DL STATE=ASSIGN) TX: START Immediate Assignment Downlink (PCH)</span><br><span style="color: hsl(0, 100%, 40%);">- - TRX=0 (0) TS=4 TA=220 pollFN=-1</span><br><span style="color: hsl(120, 100%, 40%);">+ - TRX=0 (0) TS=4 TA=220</span><br><span> TBF(TFI=0 TLLI=0xc0006789 DIR=DL STATE=ASSIGN) appending 256 bytes</span><br><span> === end test_tbf_gprs_egprs ===</span><br><span> === start test_tbf_ws ===</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/23530">change 23530</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/23530"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ia48ce2a021865e76e813dedb22aca9c2522c5693 </div>
<div style="display:none"> Gerrit-Change-Number: 23530 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>