<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ggsn/+/23517">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">vty: Inform user that static IP addresses are not supported<br><br>Currently, osmo-ggsn doesn't implement PDP contexts with static IP<br>addresses.  The code for specifying ranges that can be used for<br>static IPs was always present even from OpenGGSN days, but we never<br>really treated them.  Let's not raise the impression we do by<br>warning accordingly if the user configures them.<br><br>Change-Id: I7787dae037c46c0c5052aa6dd000be330984f144<br>Related: OS#5097<br>---<br>M ggsn/ggsn_vty.c<br>1 file changed, 8 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/17/23517/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/ggsn/ggsn_vty.c b/ggsn/ggsn_vty.c</span><br><span>index 71d8ff6..1738e70 100644</span><br><span>--- a/ggsn/ggsn_vty.c</span><br><span>+++ b/ggsn/ggsn_vty.c</span><br><span>@@ -533,9 +533,11 @@</span><br><span>     struct in46_prefix *pfx;</span><br><span> </span><br><span>         /* first update our parsed prefix */</span><br><span style="color: hsl(0, 100%, 40%);">-    if (!strcmp(argv[0], "static"))</span><br><span style="color: hsl(120, 100%, 40%);">+     if (!strcmp(argv[0], "static")) {</span><br><span>          pfx = &apn->v4.cfg.static_prefix;</span><br><span style="color: hsl(0, 100%, 40%);">-        else</span><br><span style="color: hsl(120, 100%, 40%);">+          vty_out(vty, "%% static IP addresses currently not yet supported%s", VTY_NEWLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+          return CMD_WARNING;</span><br><span style="color: hsl(120, 100%, 40%);">+   } else</span><br><span>               pfx = &apn->v4.cfg.dynamic_prefix;</span><br><span>    str2prefix(pfx, argv[1]);</span><br><span> </span><br><span>@@ -567,9 +569,11 @@</span><br><span>         struct apn_ctx *apn = (struct apn_ctx *) vty->index;</span><br><span>      struct in46_prefix *pfx;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-    if (!strcmp(argv[0], "static"))</span><br><span style="color: hsl(120, 100%, 40%);">+     if (!strcmp(argv[0], "static")) {</span><br><span>          pfx = &apn->v6.cfg.static_prefix;</span><br><span style="color: hsl(0, 100%, 40%);">-        else</span><br><span style="color: hsl(120, 100%, 40%);">+          vty_out(vty, "%% static IP addresses currently not yet supported%s", VTY_NEWLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+          return CMD_WARNING;</span><br><span style="color: hsl(120, 100%, 40%);">+   } else</span><br><span>               pfx = &apn->v6.cfg.dynamic_prefix;</span><br><span>    str2prefix(pfx, argv[1]);</span><br><span>    return CMD_SUCCESS;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ggsn/+/23517">change 23517</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ggsn/+/23517"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ggsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I7787dae037c46c0c5052aa6dd000be330984f144 </div>
<div style="display:none"> Gerrit-Change-Number: 23517 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>