<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/23505">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Skip RPM checks if no *.spec.in available<br><br>Some projects don't necessarily have RPM packaging yet. Hence, avoid<br>running into unexpected check results in that case.<br><br>Related: OS#5094<br>Change-Id: Id306256af1ab3bf081b7df5a6c271628e3b8715c<br>---<br>M osmo-release.sh<br>1 file changed, 12 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/osmo-release.sh b/osmo-release.sh</span><br><span>index c0b0b4a..aecbfd1 100755</span><br><span>--- a/osmo-release.sh</span><br><span>+++ b/osmo-release.sh</span><br><span>@@ -73,6 +73,12 @@</span><br><span> # Make sure that depedency requirement versions match in configure.ac vs contrib/*.spec.in.</span><br><span> #eg: "PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.1.0)" vs "pkgconfig(libosmocore-dev) >= 1.0.0,"</span><br><span> check_configureac_rpmspecin_deps_match() {</span><br><span style="color: hsl(120, 100%, 40%);">+ # Some projects don't have rpm spec files:</span><br><span style="color: hsl(120, 100%, 40%);">+        if [ "z$(find "${GIT_TOPDIR}/contrib" -name "*.spec.in" | wc -l)" = "z0" ]; then</span><br><span style="color: hsl(120, 100%, 40%);">+              echo "INFO: Project has no 'contrib/*.spec.in' files, skipping RPM specific configure.ac dependency version checks"</span><br><span style="color: hsl(120, 100%, 40%);">+         return</span><br><span style="color: hsl(120, 100%, 40%);">+        fi</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>         get_configureac_pkg_check_modules_list | \</span><br><span>   { return_error=0</span><br><span>     while read -r dep ver; do</span><br><span>@@ -169,6 +175,12 @@</span><br><span> }</span><br><span> </span><br><span> libversion_rpmspecin_match() {</span><br><span style="color: hsl(120, 100%, 40%);">+   # Some projects don't have rpm spec files:</span><br><span style="color: hsl(120, 100%, 40%);">+        if [ "z$(find "${GIT_TOPDIR}/contrib" -name "*.spec.in" | wc -l)" = "z0" ]; then</span><br><span style="color: hsl(120, 100%, 40%);">+              echo "INFO: Project has no 'contrib/*.spec.in' files, skipping RPM specific LIBVERSION checks"</span><br><span style="color: hsl(120, 100%, 40%);">+              return</span><br><span style="color: hsl(120, 100%, 40%);">+        fi</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>         echo "$LIBVERS" | while read -r line; do</span><br><span>           libversion=$(echo "$line" | cut -d "=" -f 2 | tr -d "[:space:]")</span><br><span>               major="$(libversion_to_lib_major "$libversion")"</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/23505">change 23505</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/23505"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Id306256af1ab3bf081b7df5a6c271628e3b8715c </div>
<div style="display:none"> Gerrit-Change-Number: 23505 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>